Commit Graph

2733 Commits

Author SHA1 Message Date
Otavio Cordeiro 7ea9b733ff Allow multi-line parameters rule to always break lines (#3494) 2021-02-02 13:27:29 -08:00
JP Simard bbf1ad4a18 [ExplicitSelfRule] Fix violation location and misplaced corrections (#3507) 2021-01-29 10:59:28 -08:00
Otavio Cordeiro 59eb887cfa Add opt-in rule discouraged_assert (#3506)
Co-authored-by: Keith Smiley <keithbsmiley@gmail.com>
2021-01-29 09:30:57 -08:00
JP Simard 6a38b15657 Revert "Merge pull request #3473 from realm/feature/3472-fix-custom-rules-merging" (#3503)
This reverts commit 537e53f6b3, reversing
changes made to ba49f7d309.
2021-01-22 10:31:05 -08:00
Frederick Pietschmann 2d17045b11 [#3477] Fix bug that prevented the reconfiguration of a custom rule in a child config 2021-01-14 23:35:21 +01:00
Frederick Pietschmann 56e4f175ac Fix if statement formatting 2021-01-14 23:35:21 +01:00
Frederick Pietschmann 5bffc77af6 Fix custom_rules merging when a configuration is based on only_rules 2021-01-14 23:35:21 +01:00
Frederick Pietschmann 256288ab88 Separate custom rules merging & filtering to avoid misleading warnings 2021-01-14 23:35:21 +01:00
Yurii Kotov 6dba929b4f Fix typos in configuration options for file_name rule 2020-12-16 19:56:50 +02:00
JP Simard d53fc2664d release 0.42.0 2020-12-14 15:26:56 -05:00
JP Simard ebca5238a7 Fix false positives on unused_declaration for outlets with accessors 2020-12-11 10:07:22 -05:00
JP Simard f8bc10aaaa Merge pull request #3460 from realm/dont-log-a-warning-if-no-configuration-files-were-explicitly-specified
Don't log a warning if no configuration files were explicitly specified
2020-12-11 10:02:41 -05:00
JP Simard 01b1001a81 fixup! Don't log a warning if no configuration files were explicitly specified 2020-12-11 10:02:16 -05:00
JP Simard cb3eed544c Add FileGraphInitializationResult to make error handling more explicit 2020-12-11 09:27:51 -05:00
JP Simard 12cea6b9c7 fixup! Don't log a warning if no configuration files were explicitly specified 2020-12-10 09:39:49 -05:00
JP Simard ab700a3262 Re-add warning message if the config file was implicit and misconfigured
Thanks fredpi!
2020-12-10 09:37:09 -05:00
JP Simard d75b9c45df Remove unused error case 2020-12-09 17:18:21 -05:00
JP Simard 35d75809c9 Fix typo 2020-12-09 17:16:50 -05:00
JP Simard 2b50902d1a Revert most changes, just don't log a warning 2020-12-09 17:14:04 -05:00
JP Simard d010569f1d Extract out error string generation 2020-12-09 16:26:10 -05:00
Keith Smiley 800030ad11 Remove NonPrivateXCTestMembersRule (#3459)
* Remove NonPrivateXCTestMembersRule

I accidentally implemented this rule twice. So TestCaseAccessibilityRule
did the same thing but with a bit more behavior. This change deletes
NonPrivateXCTestMembersRule but also ports over the autocorrection from
it to TestCaseAccessibilityRule.
2020-12-09 13:16:40 -08:00
JP Simard 82e5870a16 Don't log a warning if no configuration files were explicitly specified
And none was found at the default location of `.swiftlint.yml`.
2020-12-09 16:16:04 -05:00
Keith Smiley 22ee449971 Fix @IBInspectable unused declarations with get/set (#3458) 2020-12-07 11:07:16 -08:00
richard.turton 103cf7504a Fixed whitespace violations 2020-12-04 17:01:47 +00:00
richard.turton 62298de662 Add exception for UIApplicationDelegateAdaptor 2020-12-04 16:45:51 +00:00
Keith Smiley 03f13e5bb7 Remove @IBOutlet and @IBInspectable from UnusedDeclarationRule (#3432)
The original implementation wasn't tested so it regressed.

https://github.com/realm/SwiftLint/pull/3184
2020-12-03 11:00:53 -08:00
JP Simard f0f0086aca Merge pull request #3443 from realm/remove-info.plist-files
Remove Info.plist files
2020-11-23 10:47:36 -05:00
Frederick Pietschmann 495d742f65 Fix issues originating from new set semantics 2020-11-21 00:05:42 +01:00
Frederick Pietschmann 4c5a3f0577 Add remote, parent & child configuration features 2020-11-20 23:08:37 +01:00
JP Simard e143a18e5c Remove Info.plist files
These are no longer needed now that we removed the Xcode project.
2020-11-20 15:01:09 -05:00
Dalton Claybrook ba5e6d2e1c Fix false positives in inclusive_language rule (#3439)
* Add support for allowed terms in inclusive language rule

* Update changelog

* Move changelog entry to Enhancements section

Co-authored-by: JP Simard <jp@jpsim.com>
2020-11-20 14:12:24 -05:00
JP Simard 42373a94b6 Remove example failing test
This is hard to fix, and already covered by the corrections.
2020-11-20 11:18:07 -05:00
Keith Smiley e50e34a60a Add another 2020-11-16 15:54:23 -08:00
Keith Smiley b7ec75b68b Add support for testing Examples with configuration
This was extracting from another change that no longer needed it. It
should be helpful for anyone testing custom configuration with their
non-analyzer rules.

I added a random example of something that wasn't previously tested as
an example.
2020-11-16 15:37:15 -08:00
Keith Smiley 866102c3fc Add XCTestCase examples to unused declaration rule (#3192) 2020-11-16 15:32:51 -08:00
Keith Smiley 3151e6c45f Add NonPrivateXCTestMembersRule (#3248)
Co-authored-by: JP Simard <jp@jpsim.com>
2020-11-16 09:50:56 -08:00
JP Simard 07f559549a Rename OverridenSuperCallConfiguration to fix typo (#3426)
* BREAKING CHANGE: As `OverridenSuperCallConfiguration` is a
publicly-exposed struct, this rename should be considered breaking.

* Fix consoleDescription for OverriddenSuperCallConfiguration
2020-11-11 13:37:12 -05:00
Jan-Otto Kröpke 874cacbd1f Add codeclimate reporter (#3425) 2020-11-11 10:29:00 -08:00
Bryan Ricker 999bfbdefa Fix consoleDescription for OverriddenSuperCallConfiguration 2020-11-10 20:40:41 -08:00
Bryan Ricker 8a0eb67561 chore: rename OverridenSuperCallConfiguration to OverriddenSuperCallConfiguration
BREAKING CHANGE: As `OverridenSuperCallConfiguration` is a
publicly-exposed struct, this rename should be considered breaking.
2020-11-10 20:40:41 -08:00
JP Simard bf2790df54 Enable CommentSpacingRule by default
And fix violations in SwiftLint
2020-11-10 12:50:39 -05:00
JP Simard 869fe868b3 Apply minor refactorings
1. Add some comments
2. Name variables when used in multiline closures
3. Change violation range length from 1 to 0, which simplifies the
   substitution
4. Tweak indentation
2020-11-10 12:42:40 -05:00
Noah Gilmore 5108233ac5 Further PR comments 2020-11-09 21:54:14 -08:00
Noah Gilmore 6bd38e8607 Update Source/SwiftLintFramework/Rules/Lint/CommentSpacingRule.swift
Co-authored-by: JP Simard <jp@jpsim.com>
2020-11-09 21:54:14 -08:00
Noah Gilmore 442eac2556 Update Source/SwiftLintFramework/Rules/Lint/CommentSpacingRule.swift
Co-authored-by: JP Simard <jp@jpsim.com>
2020-11-09 21:54:14 -08:00
Noah Gilmore 1a104e4dc4 Add comments 2020-11-09 21:54:14 -08:00
Noah Gilmore dd5c0d3599 Add CommentSpacingRule (#3233) 2020-11-09 21:54:14 -08:00
JP Simard d9b5df2d72 Merge pull request #3254 from realm/ks/add-always_keep_imports-to-unusedimportrule
Add 'always_keep_imports' to UnusedImportRule
2020-11-09 17:43:20 -05:00
JP Simard 6c370caa77 Fix indentation 2020-11-09 12:06:45 -05:00
JP Simard 46ed5e2ece Add print statement for deprecation
To indicate that `statement_level` has been renamed to `function_level`.
2020-11-09 12:06:45 -05:00