Commit Graph

1662 Commits

Author SHA1 Message Date
Marcelo Fabri 74abfc93a6 Merge pull request #2543 from BenStaveleyTaylor/issue_2538
Issue 2538: vertical_whitespace_between_cases gives false warning if blank line has whitespace
2019-01-06 12:50:08 -08:00
Ben Staveley-Taylor 09c266613d Implement review changes
Add new nonTriggeringExample for testing, with trailing spaces
2019-01-06 16:21:51 +00:00
JP Simard 0a42e64de0 Fix order in which corrections are applied
They're already ordered last to first in the file from the sorting
applied in `violationRanges(in file:)`
2019-01-05 21:33:42 -08:00
JP Simard 135a997c9c Re-use bridged string
and inline firstToken(afterByteOffset:)
2019-01-05 21:30:58 -08:00
Marcelo Fabri 41868b35cb Improvements on unused_control_flow_label correction 2019-01-05 19:21:18 -08:00
JP Simard eb8f398683 Add shitty implementation of correction 2019-01-05 19:11:39 -08:00
Marcelo Fabri d863fc9fb7 Add unused_control_flow_label rule
Fixes #2227
2019-01-05 18:59:32 -08:00
Ben Staveley-Taylor de3a24008f Fix false positives on vertical_whitespace_between_cases
Fixes #2538
2019-01-05 16:00:32 +00:00
Marcelo Fabri 91f37afcd1 Remove unused declaration 2019-01-03 02:02:32 -08:00
Marcelo Fabri d08b3888ad Add missing ↓ on triggering example 2019-01-03 01:53:07 -08:00
Marcelo Fabri 0c92b948a9 Warn on private declaration inside @objc extension 2019-01-03 01:48:08 -08:00
Marcelo Fabri 972bb0d347 Fix false positives on redundant_objc_attribute rule when using nested types
Fixes #2539
2019-01-03 00:57:15 -08:00
Marcelo Fabri eafd98971d Fix false positives on sorted_first_last with Realm
Fixes #2533
2018-12-25 19:25:53 -08:00
Marcelo Fabri 4b12e08731 Fix false positives on Realm collections 2018-12-25 18:41:53 -08:00
Marcelo Fabri 506e3086ba Enable last_where on SwiftLint 2018-12-25 18:12:26 -08:00
Marcelo Fabri c17e269cee Add last_where opt-in rule 2018-12-25 01:34:42 -08:00
JP Simard 61a5daa073 Fix false positives in UnusedPrivateDeclarationRule (#2530) 2018-12-24 12:55:17 -08:00
Marcelo Fabri 0cc6ccfcf5 Remove unneeded import 2018-12-24 01:36:57 -08:00
Marcelo Fabri e6ee8f7145 Fix violations after rebase 2018-12-24 01:04:25 -08:00
Ornithologist Coder 13d51e7b4c Rebase and remove file headers 2018-12-24 01:01:12 -08:00
Ornithologist Coder 8c7a0e0499 Sets min. Swift version to 4.1 2018-12-24 01:01:12 -08:00
Ornithologist Coder 6f668a6087 Uses compactMap instead of flatMap 2018-12-24 01:01:11 -08:00
Ornithologist Coder 488488ef0d Prepare for SR-5717 apple/swift#11542 2018-12-24 01:01:11 -08:00
Ornithologist Coder fb179a9760 Uses offset/length instead of bodyOffset/bodyLength 2018-12-24 01:01:11 -08:00
Ornithologist Coder e37baf106c Handles optinals when argument is true/false 2018-12-24 01:01:11 -08:00
Ornithologist Coder 8e4e68fe13 Removes tests SwiftLint already takes care of 2018-12-24 01:01:11 -08:00
Ornithologist Coder 3c30d6f519 Renames variables 2018-12-24 01:01:11 -08:00
Ornithologist Coder 22a21c8fe1 Renames variable 2018-12-24 01:01:11 -08:00
Ornithologist Coder 4b391d188d Moves validation to guard statement 2018-12-24 01:01:11 -08:00
Ornithologist Coder e497f63fe0 Adds additional tests for the reasons 2018-12-24 01:01:11 -08:00
Ornithologist Coder 6d60d03fca Moves tests to its own file 2018-12-24 01:01:11 -08:00
Ornithologist Coder 8bf9e7fb29 Adds additional examples 2018-12-24 01:01:11 -08:00
Ornithologist Coder ba31336cb3 Uses AST instead of regular expressions 2018-12-24 01:01:11 -08:00
Ornithologist Coder a9a2927814 Simplifies the regular expressions
but... removes the validation when the call has a message.
2018-12-24 01:01:11 -08:00
Ornithologist Coder b760ef2362 Adds more examples 2018-12-24 01:01:11 -08:00
Ornithologist Coder 74bb9150fd Improves regular expressions 2018-12-24 01:01:11 -08:00
Ornithologist Coder 96c434e21a Adds xct_specific_matcher opt-in rule 2018-12-24 01:01:11 -08:00
Marcelo Fabri 4fa417e06f Add configuration to discouraged_object_literal
Fixes #2439
2018-12-23 23:00:08 -08:00
Timofey Solonin 735567dcb4 Make modifier_order rule autocorrectable (#2521)
* #2353 - Move violating modifiers search to a private function

* #2353 - Add offset and length to the ModifierDescription

* #2353 - Make modifier_oder rule correctable

* #2353 - Add modifier_oder rule correction tests

* #2353 - Upadte the changelog

* #2353 - Add missing Foundation import

* #2353 - Fix linux tests

* Small edits to ModifierOrderRule and changelog entry
2018-12-23 19:53:38 -08:00
Kim de Vos 5da6028054 Convert rule examples to multiline string literals (#2506) 2018-12-23 15:11:03 -08:00
JP Simard 2d0d56985f Clean up CryptoSwift references (#2522)
* Clean up CryptoSwift references

* Add a changelog entry

* Remove unused import
2018-12-20 10:59:49 -08:00
Kim de Vos 3f081b2a70 Allow private objc classes in private_unit_test (#2505) 2018-12-06 09:15:22 -08:00
Kim de Vos d62e187b5c Add Legacy Hashing rule (#2496) 2018-12-05 15:43:39 -08:00
dirtydanee 58a54db21b Fix non accessible declarations under @objcMembers (#2501)
* Fix non accessible declarations under @objcMembers

* Refactor to avoid false optionality

* fixup changelog
2018-12-04 22:47:07 -08:00
Niil Öhlin cdbf50e753 Improve performance for unused_import and unused_private_declaration 2018-12-02 21:48:40 -08:00
JP Simard 0e862ca9c4 Enable vertical whitespace rules in SwiftLint
and fix violations
2018-12-02 14:01:23 -08:00
JP Simard 7afd7ccaf8 Rename cleanedKeysDict() to removingViolationMarkers() 2018-12-02 13:52:41 -08:00
Cihat Gündüz 89c88517e1 Vertical whitespace opening & closing braces (#2291)
* Add VerticalWhitespaceOpening/ClosingBraces rules with description

* Implement validate, correct & add rules to lists

* Fix minor issues & update docs

* Fix copy & paste issue

* Improve autocorrection + Cleanup triggering examples

* Update changelog with new rule entries

* Add more validation examples

* [CHANGELOG.md] Mark new rules as opt-in

* Point to exact location of violation + update tests

* Make rules severity configurable

* Fix issues after rebasing

* Fix issue with CHANGELOG.md

* Add more violating examples, improve pattern to catch more cases

* Move changelog entries to new version

* Fix issues after rebase

* Move Changelog entry to current master

* Fix failing tests

* Fixes after refactoring

* Fix changelog entry position

* Make range unicode-safe (as suggested by @jpsim)

* Share duplicate Dictionary extension code
2018-12-02 13:41:50 -08:00
JP Simard a855ac27b0 Fix false positives and invalid corrections with unused import rule (#2492)
* Fix wrong correction when removing testable imports with UnusedImportRule

* Fix false positive with UnusedImportRule when importing Foundation when there are attributes in that file requiring Foundation.

* Update rules documentation

* Add changelog entries
2018-11-29 10:55:26 -08:00
Timofey Solonin efa68177b2 #2435 - Make modifier_order rule rely on an explicit set of rules (#2458)
* #2435 - Adjust modifier_order rule to require explicit modifier order specified to conclude a violation

* #2435 - Move modifier order rule examples to a separate file

* #2435 - Add modifier interference tests

* #2435 - Fix whitespaces

* Minor edits

* Add changelog entry
2018-11-28 15:10:49 -08:00