Commit Graph

1844 Commits

Author SHA1 Message Date
Marcelo Fabri 4c8df19c84 Use SourceKit to validate associatedtype and typealias in type_name rule when linting with Swift 4.1
Part of #2021
2018-01-26 22:08:59 -08:00
Marcelo Fabri b204c18d04 Improve type_name rule violations to be positioned on the type name
Part of #2021
2018-01-25 20:28:33 -08:00
Marcelo Fabri 5d7346b8a2 Don’t validate local vars in let_var_whitespace rule
As part of #2021
2018-01-25 20:00:31 -08:00
Marcelo Fabri 19edf2608b Fix enclosedSwiftAttributes in Swift 4.1
Fixes #2019
2018-01-25 09:47:11 -08:00
Marcelo Fabri 203d2439bd Merge pull request #2015 from realm/mf-explict-acl-false-positives
Fix false positives in `explicit_acl` rule
2018-01-25 09:43:25 -08:00
Marcelo Fabri 19c8536500 Fix false negative in unneeded_parentheses_in_closure_argument
Fixes #2017
2018-01-24 14:07:56 -08:00
Marcelo Fabri a4f701b96e Fix false positives in explicit_acl rule
Fixes #2014
2018-01-22 11:22:49 -08:00
Manabu Nakazawa daeb13c2bb Add testcases to ColonRule.description 2018-01-16 01:45:49 +09:00
Manabu Nakazawa e2bd9f8ed8 Fix: Colon Rule's autocorrect not working properly 2018-01-16 01:00:56 +09:00
JP Simard 7bf32346cc release 0.24.2 2018-01-10 10:13:57 -08:00
JP Simard e70710bedb Don't log if indentation isn't set in config
Fixes #1998
2018-01-10 10:08:39 -08:00
JP Simard 7ad77df690 release 0.24.1 2018-01-08 15:21:59 -08:00
Ornithologist Coder a2c8233d95 Ignores computed variables 2018-01-05 10:41:05 +01:00
Ornithologist Coder 561e10a71f Uses .setterAccessibility to differentiate variables from constant
As suggested by @marcelofabri.
2018-01-05 08:36:09 +01:00
Ornithologist Coder ecd8ac67b6 Fixes file name on header 2018-01-05 07:29:41 +01:00
Ornithologist Coder 2039ee6b7b Improves 'let' keyword validation 2018-01-05 06:48:54 +01:00
Ornithologist Coder 1295c5d182 Adds opt-in prefixed_toplevel_constant rule
Implements #1907.
2018-01-05 04:07:10 +01:00
JP Simard 34d2fb3949 Move Configuration.defaultIndentation() to IndentationStyle init 2018-01-03 23:31:12 -08:00
JP Simard fa13551af1 Rename Configuration.Indentation to IndentationStyle
and move to its own file
2018-01-03 23:21:23 -08:00
JP Simard 5fd67018bb Fix comment alignment 2018-01-03 23:16:37 -08:00
Noah McCann fa5815e9f5 Extracted rule logic to separate function to address linting errors 2018-01-03 23:05:48 -08:00
Noah McCann ab29b75d20 Addressed most linting errors 2018-01-03 23:05:48 -08:00
Noah McCann 093367073a Renamed IndentationMode to Indentation, better handled default value 2018-01-03 23:05:48 -08:00
Noah McCann 38f869bf81 Added indentationMode to configuration, updated parsing to handle it 2018-01-03 23:05:48 -08:00
Ornithologist Coder a3c6a7f40c Adds opt-in discouraged_object_literal rule
Implements #1987.
2018-01-03 23:00:54 -08:00
JP Simard 5966896575 Fix missing word in comment 2018-01-03 21:42:55 -08:00
Donald Ritter 1deddf2334 Adds a new rule which allows for enums that conform to protocol to
require cases.
2017-12-22 13:08:51 -05:00
JP Simard 1541f519b2 Merge pull request #1966 from joseprl89/feature/explicit_acl_rule
Add explicit acl rule to satisfy Issue #1649
2017-12-22 12:51:48 -05:00
JP Simard a9b6a6f07e Fix false positives in unused_closure_parameter rule
when closure is wrapped in parentheses. Fixes #1979.

Definitely not elegant, but it should help.
2017-12-21 17:52:06 -05:00
JP Simard c7c77f55ea Merge pull request #1965 from dirtydanee/yoda-condition
Introduction of Yoda condition checking.
2017-12-20 15:18:54 -05:00
JP Simard a35e231417 Fix Linux compilation 2017-12-20 14:50:56 -05:00
JP Simard a973a89818 Refactor YodaConditionRule a bit 2017-12-20 14:44:54 -05:00
JP Simard f1a3374261 Add .repeatWhile to list of conditional statement kinds 2017-12-20 14:44:54 -05:00
JP Simard 47c47262ff Minor style fixes to YodaConditionRule 2017-12-20 14:44:54 -05:00
JP Simard 84a39a57a6 Replace use of YodaConditionConfiguration with SeverityConfiguration
since YodaConditionConfiguration had no additional configuration points
2017-12-20 14:44:54 -05:00
Marcelo Fabri c1da2bd194 Fix false positives in for_where with pattern matching
Fixes #1968
2017-12-20 11:23:05 -08:00
Daniel Metzing f8f9c0e7f1 Introduction of Yoda condition checking.
This PR aims to implement [#1924][1].
[1]: https://github.com/realm/SwiftLint/issues/1924
2017-12-18 15:42:13 +01:00
Marcelo Fabri 02792c1a01 Fix false positives in control_statement when methods with keyword names are used
Fixes #1946
2017-12-04 23:18:16 -08:00
Marcelo Fabri f01ed995c7 Merge pull request #1935 from ornithocoder/private_ibaction
Adds private_action opt-in rule
2017-12-04 22:49:08 -08:00
Josep Rodríguez e150e5b92f Add explicit acl rule to satisfy Issue #1649 2017-12-02 20:39:42 +00:00
JP Simard a02d4e17dd Small refactor in NimbleOperatorRule.swift 2017-11-30 11:05:45 -08:00
Ornithologist Coder 9d2c113ba8 Adds new opt-in rule, private_action
Implements #1931.
2017-11-17 18:13:48 +01:00
Norio Nomura 13768b70f6 Stop using numerical comparison in SwiftVersion 2017-11-16 11:53:29 +09:00
Norio Nomura d460c6d124 Invalidate cache when Swift patch version changes 2017-11-16 11:03:08 +09:00
JP Simard 06ece1ea8d release 0.24.0 2017-11-10 15:49:41 -08:00
JP Simard 93ded518a7 Remove uses of String.characters, deprecated in Swift 4.0.2 2017-11-10 14:37:53 -08:00
JP Simard 170ad413f0 Lock accesses to assert handler storage
This fixes races seen "in the wild" causing crashes.
2017-11-09 12:28:45 -08:00
JP Simard aa73566b39 Convert Cache struct to a class
to avoid having to lock calls to mutating functions that don't
actually perform mutating operations.

This fixes races seen "in the wild" causing crashes.
2017-11-09 12:28:45 -08:00
Tom Quist a2099abb9d Added changelog entry and added new triggering examples from firefox project 2017-11-08 07:02:34 +01:00
Tom Quist 9d75e39b3c * Added documentation for validate method in CallPairRule
* Made CallPairRule internal
* Fixed indentation of guard bodies
2017-11-07 08:41:40 +01:00