Commit Graph

928 Commits

Author SHA1 Message Date
Marcelo Fabri 754887d342 Accept global and local variables in implicit_getter rule 2017-02-14 12:55:20 -02:00
Marcelo Fabri 0abc114895 Add redundant_discardable_let rule
Fixes #1232
2017-02-10 11:46:13 -08:00
Marcelo Fabri f90b25e2e1 Refactor elements to not be optional 2017-02-09 17:59:31 -08:00
Marcelo Fabri 55457ceeae Fix closure_end_indentation false positive
Fixes #1216
2017-02-09 17:07:41 -08:00
Marcelo Fabri b26bb95d25 unused_enumerated should check if only index is used
Fixes #1278
2017-02-09 17:03:15 -08:00
Marcelo Fabri d5b0d1b208 Reimplement switch_case_on_newline as an ASTRule
Fixes #1268
2017-02-09 16:37:26 -08:00
JP Simard fa3ab00183 fix merge 2017-02-09 15:53:16 -08:00
JP Simard 8c4bfcc58d Merge branch 'master' into identifier-rule
* master: (44 commits)
  make valid_docs rule opt-in
  update LineLengthConfiguration.consoleDescription after #1264
  small refactoring after #1264
  fix for_where violation in CompilerProtocolInitRule.swift
  Add for_where rule
  explicitly set podspec dependency versions
  Add changelog entry
  Fix existing violations
  Navigate substructure even for different kinds
  Small style changes
  Modified so that kinds(forByteOffset:) does not require a separate filter() setup of the results
  Changes from PR feedback. Long comments following code in a line will now trigger,  configuration will now fail if invalud value types are set for options
  Fix false positive on large_tuple when using generics inside a tuple
  fix wording in changelog
  disable docs rules in Swift 2.3 and later
  Fix deadlock when stderr fills up OS buffer
  small Danger/oss-check improvements
  Fix links
  Fix cleanup
  Always use Xcode reporter on oss-check
  ...
2017-02-09 15:50:06 -08:00
JP Simard 35ce34d919 make valid_docs rule opt-in 2017-02-09 15:15:30 -08:00
JP Simard a10156b5eb update LineLengthConfiguration.consoleDescription after #1264 2017-02-09 14:42:10 -08:00
JP Simard 69f885cf08 small refactoring after #1264 2017-02-09 14:42:09 -08:00
JP Simard 7ab9855831 fix for_where violation in CompilerProtocolInitRule.swift 2017-02-09 14:42:09 -08:00
Marcelo Fabri f0c8fba3b6 Add for_where rule
Fixes #1228
2017-02-09 13:43:58 -08:00
Marcelo Fabri ecc3c85f68 Fix existing violations 2017-02-06 22:04:05 -02:00
Marcelo Fabri ac4ea29150 Navigate substructure even for different kinds 2017-02-06 22:04:05 -02:00
Marcelo Fabri ad10f81a44 Merge pull request #1259 from marcelofabri/bugfix_1257
Fix false positive on large_tuple when using generics inside a tuple
2017-02-06 22:01:33 -02:00
Marcelo Fabri 2300ae3daf Small style changes 2017-02-06 21:59:30 -02:00
Michael Welles 15a7a88297 Modified so that kinds(forByteOffset:) does not require a separate
filter() setup of the results
2017-02-06 15:58:45 -05:00
Michael Welles 7d48153d4a fixed merge conflicts 2017-02-06 15:38:19 -05:00
Michael Welles c9ff0aa07f Changes from PR feedback. Long comments following code in a line will now trigger, configuration will now fail if invalud value types are set for options 2017-02-06 15:33:44 -05:00
Marcelo Fabri 4037b932f6 Fix false positive on large_tuple when using generics inside a tuple
Fixes #1257
2017-02-03 21:43:34 -02:00
JP Simard a01cb69a83 disable docs rules in Swift 2.3 and later 2017-02-03 14:42:11 -08:00
Marcelo Fabri e1bc54d6a2 Merge pull request #1252 from marcelofabri/bugfix_1161
Ignore unused_closure_parameter on inline closures
2017-02-02 19:56:03 -02:00
Marcelo Fabri 260dded4e7 Small refactoring 2017-02-02 19:22:49 -02:00
Jon Shier 19912431e8 Update implementation and CHANGELOG markdown. 2017-02-01 15:30:13 -05:00
Jon Shier 7ab14e65f2 Update ClassDelegateProtocolRule to accept AnyObject and NSObjectProtocol. 2017-01-31 19:33:44 -05:00
Michael Welles ccc840b340 Changed LineLengthConfigurationFlag enum to be an OptionSet struct, per pull request feedback 2017-01-31 13:56:26 -05:00
Michael Welles 04437ed30d Merge branch 'master' of github.com:realm/SwiftLint into line-length-rule-configurable 2017-01-30 17:55:34 -05:00
Michael Welles cd843e7fcd Added "ignores_comments" and "ignores_function_declarations" as boolean options to LineLengthRule 2017-01-30 17:51:56 -05:00
Marcelo Fabri 87a03d769a Merge branch 'master' into bugfix_1161 2017-01-26 15:05:57 -02:00
Marcelo Fabri c0c7aa2993 Ignore unused_closure_parameter on inline closures
Fixes #1161
2017-01-26 14:08:46 -02:00
t_hayashi d4ccec2657 Remove unneeded positive lookahead pattern 2017-01-27 00:56:53 +09:00
t_hayashi 50b0febdb4 Modify regex pattern more simple 2017-01-26 23:01:27 +09:00
t_hayashi 851e6ec0db Fix redundant_void_return execution if return type starts with Void 2017-01-26 22:28:39 +09:00
Allen Zeng c3b4a43950 ascertain name lengths 2017-01-26 10:55:46 +11:00
Allen Zeng 6acf36bc97 use calculated property 2017-01-26 01:37:39 +11:00
Marcelo Fabri c8e08181e0 Merge branch 'master' into identifier-rule 2017-01-25 12:17:05 -02:00
Allen Zeng 9f1e81bb67 retain closure parameter types when they are specified during autocorrect 2017-01-26 00:04:43 +11:00
Marcelo Fabri d3693e1171 Merge pull request #1196 from marcelofabri/notification_center_detachment
Add notification_center_detachment rule
2017-01-24 23:00:17 -02:00
Marcelo Fabri 776484ded7 Merge pull request #1243 from marcelofabri/bugfix_1242
Fix number_separator rule for upcase exponentials
2017-01-24 22:34:21 -02:00
Marcelo Fabri a11e836c51 Refactor to use Dictionary extension 2017-01-24 22:27:46 -02:00
Marcelo Fabri 3800915e88 Swift 2.3 compatibility 2017-01-24 22:27:46 -02:00
Marcelo Fabri 46a2c25af4 Add notification_center_detachment rule
Fixes #1061
2017-01-24 22:27:45 -02:00
Marcelo Fabri 6772ef6668 Merge pull request #1192 from marcelofabri/discarded_notification_center_observer
Add discarded_notification_center_observer rule
2017-01-24 22:16:50 -02:00
Marcelo Fabri f03a0eda9a Fix number_separator rule for upcase exponentials
Fixes #1242
2017-01-24 22:15:49 -02:00
Aaron McTavish cb53af5cd6 Fix bool negation false positive for force_unwrap
Resolves #918 `force_unwrapping: false positive when using ! as boolean
operator`.
2017-01-24 07:35:13 +00:00
Marcelo Fabri ba33d10ee8 Merge branch 'master' into faster-vertical-whitespace 2017-01-23 22:54:28 -02:00
Marcelo Fabri 67b60c4d18 Merge branch 'master' into faster-first-where 2017-01-23 22:52:31 -02:00
Marcelo Fabri 96c81d126e Merge branch 'master' into faster-mark-rule 2017-01-23 22:51:27 -02:00
Marcelo Fabri 014531e051 Refactor to use new Dictionary methods 2017-01-23 21:38:57 -02:00