Commit Graph

1509 Commits

Author SHA1 Message Date
Marcelo Fabri 2045780476 Merge pull request #1581 from marcelofabri/fix-1525
Don't trigger `discarded_notification_center_observer` when the observer is returned
2017-06-02 21:06:37 +02:00
Anders Hasselqvist 7126d9afa1 Match (Void) as return type in the void_return rule
Update the regexp to match on 0 or 1 occurence of `Void` within
the parentheses.
2017-05-29 16:55:06 +09:00
Marcelo Fabri 9b0e25977a Don't trigger discarded_notification_center_observer when the observer is returned
Fixes #1525
2017-05-28 18:17:07 +02:00
Marcelo Fabri 6fdf80be29 Don't trigger private_unit_test when a method has parameters
Fixes #1532.
2017-05-28 17:54:31 +02:00
Marcelo Fabri 33955234b3 Skip files with valid cache & no violations when auto correcting 2017-05-28 12:47:52 +02:00
Markus Gasser a7db3208cd Ignore overriddes in FunctionParameterCountRule 2017-05-27 09:59:52 +02:00
Ornithologist Coder 5584bd5710 Includes all function declarations 2017-05-26 16:01:18 +02:00
Ornithologist Coder 48bb6c77d4 Adds multiline method definition rule
Parameters of methods and functions should be either on the same line,
or one per line.
2017-05-26 14:54:01 +02:00
JP Simard 0aa93380e7 release 0.19.0 2017-05-25 14:25:31 -07:00
JP Simard b59743f848 refactor ForceUnwrappingRule
* use 'nsstring.length' instead of computing 'contents.utf16.count'
* avoid over-bridging
* use 'guard let' instead of 'if let' with large body
* use shorter, more focused functions
* remove function_body_length rule disabling no longer necessary
* delay computation of certain variables until necessary
* fix misleading variable names
* generally reduce indentation
2017-05-25 14:01:53 -07:00
JP Simard 51833fe1a1 avoid over-bridging 2017-05-25 11:34:55 -07:00
JP Simard 20f57df3a9 pass function to flatMap in ShorthandOperatorRule 2017-05-25 11:31:10 -07:00
JP Simard bc622e803d fix ExplicitTopLevelACLRule
when 'internal' keyword isn't for the declaration being evaluated
2017-05-25 11:18:00 -07:00
JP Simard acc7808b04 use kinds(inByteRange:) in more places
CommaRule, ExplicitTopLevelACLRule, ForceUnwrappingRule, ForWhereRule
2017-05-25 11:18:00 -07:00
JP Simard 99d13d14a3 remove workaround for SR-3448/SR-3449
as they were fixed in the 3.1 release
2017-05-25 07:58:04 -07:00
Marcelo Fabri fd5ce1c4b0 Fix false positive in empty_enum_arguments rule
Fixes #1549
2017-05-25 04:57:11 +02:00
Marcelo Fabri 32e38c96cf Add kinds(inByteRange:) 2017-05-25 04:55:47 +02:00
JP Simard 0071b8c50d remove redundant protocol inheritance
since 'ConfigurationProviderRule' already inherits from 'Rule'
2017-05-24 15:36:58 -07:00
JP Simard 8a9b1023e1 fix style issues in ClosureSpacingRule 2017-05-24 13:26:19 -07:00
J Cheyo Jimenez 4b927d1479 made closure_spacing correctable 2017-05-24 13:07:38 -07:00
JP Simard 0e50216114 Merge pull request #1557 from realm/jp-fix-overlapping-regions
Fix overlapping commands causing incorrect Region generation
2017-05-24 12:22:01 -07:00
JP Simard 592537966c make Region & Command structs conform to Equatable 2017-05-24 11:33:39 -07:00
Marcelo Fabri bdcfe1b2cf Merge pull request #1551 from realm/write-cache
Split cache into read cache and write cache
2017-05-24 17:38:15 +02:00
Marcelo Fabri 9a5e30e794 Split cache into read cache and write cache 2017-05-24 17:03:51 +02:00
JP Simard bb50a4e8e5 fix overlapping commands causing incorrect Region generation
fixes #1388
2017-05-23 13:38:24 -07:00
JP Simard eef39595f6 move cache-related Configuration code into Configuration+Cache.swift 2017-05-23 11:22:55 -07:00
JP Simard b19e0de6e4 fix non-root configs logging warnings more than once 2017-05-23 11:22:55 -07:00
JP Simard 201a74ef0b recursively call extractCallsToSuper(methodName:) 2017-05-23 10:26:13 -07:00
JP Simard 8ed4424a9a release 0.19.0-rc.1 2017-05-22 14:09:33 -07:00
JP Simard 572754f707 Merge pull request #1530 from realm/jp-reenable-cache-v2
Reenable cache
2017-05-21 22:43:12 -07:00
Marcelo Fabri 9d67308a92 Merge pull request #1511 from marcelofabri/protocol_property_accessors_order
Add protocol_property_accessors_order rule
2017-05-22 00:37:46 +02:00
Marcelo Fabri 12360cc386 Use ASTRule and check if token is ACL 2017-05-22 00:13:19 +02:00
J Cheyo Jimenez aef7f81056 Added NoExtensionAccessModifierRule 2017-05-21 23:53:56 +02:00
Marcelo Fabri 32913fe03e Merge pull request #1410 from sammy-SC/shorthand_operator-false-positive
Prevent false positive in shorthand_operator rule
2017-05-21 23:40:11 +02:00
Marcelo Fabri 09c29b169d Fix false positive in syntactic_sugar rule when using nested types
Fixes #1508
2017-05-21 23:17:53 +02:00
JP Simard 3968b01bb6 update tests to reflect unicode fixes in SourceKitten 2017-05-19 14:10:24 -07:00
JP Simard cea6f43f37 make PrivateUnitTestRule & its configuration conform to CacheDescriptionProvider 2017-05-19 09:30:09 -07:00
JP Simard 0c0952046c ensure deterministic consoleDescription & cacheDescription generation 2017-05-19 09:25:53 -07:00
JP Simard 416384c4a5 Merge pull request #1526 from realm/jp-xcode-reporter-line-fallback
Fall back to line 1 when no line is provided & reporting with `xcode`
2017-05-18 15:42:50 -07:00
JP Simard 2704b3e1de report file_header violations on line 1 for all reporters 2017-05-18 15:11:50 -07:00
JP Simard ca08d6598a move LinterCache+CommandLine to SwiftLintFramework
and make cacheURL an internal member of Configuration
2017-05-18 14:53:39 -07:00
JP Simard 97bdac211a keep a single cache file for all of SwiftLint 2017-05-18 14:45:46 -07:00
JP Simard 690b567421 simplify serialized cache structure 2017-05-18 14:40:40 -07:00
JP Simard bd7169e40c cache each file with its own configuration cache description
to make the cache play nicely with nested configurations
2017-05-18 14:31:33 -07:00
JP Simard 258a80b5cc don't overwrite cache results from different versions 2017-05-18 14:31:33 -07:00
JP Simard f639ae95f1 add CacheDescriptionProvider protocol
to provide more complete descriptions for cache invalidation
purposes.
2017-05-18 14:31:33 -07:00
JP Simard 903b48f4da derive Configuration.cacheDescription in all cases
rather than just when using one of many code paths in one of many
initializers
2017-05-18 13:59:24 -07:00
JP Simard 70bcb2c4e5 add LinterCache.Key enum
rather than use hardcoded, duplicate string literals
2017-05-18 13:59:24 -07:00
JP Simard 923f38c11b simplify FileManager.modificationDate(forFileAtPath:) impl 2017-05-18 13:59:24 -07:00
Víctor Pimentel 5ed010c9c0 Change LinterCache to use file modification dates instead of hashing files with a weak algorithm. 2017-05-18 13:39:05 -07:00