Commit Graph

417 Commits

Author SHA1 Message Date
JP Simard 4ae7f2fca9 use verifyRule to test FileLengthRule 2016-01-24 13:18:19 -08:00
JP Simard e0e0ec4e68 use verifyRule to test LineLengthRule 2016-01-24 13:15:31 -08:00
JP Simard a9f681955b use verifyRule to test TypeBodyLengthRule 2016-01-24 13:06:50 -08:00
JP Simard 2b286b67b7 refactor testTypeNames to use verifyRule 2016-01-24 12:44:17 -08:00
JP Simard 485c23fe7b make measureComplexity a bit more functional 2016-01-24 12:34:32 -08:00
JP Simard 34441da963 stylistic edits for CyclomaticComplexityRule 2016-01-24 12:34:32 -08:00
Denis Lebedev 2d4be3aca8 Cleanup rule code 2016-01-24 12:34:32 -08:00
Denis Lebedev dbb7938f54 Add POC of complexity rule 2016-01-24 12:34:32 -08:00
Scott Hoyt 75f2068299 Switch to if/early return for VariableNameRule. 2016-01-23 17:53:27 -08:00
Scott Hoyt 44ff8effc9 Reset VariableNameRule to if check on return as opposed to guard. 2016-01-23 17:42:13 -08:00
Scott Hoyt b145bf1212 Reset VariableNameRule to instantiating Location at the call site. 2016-01-23 17:42:13 -08:00
Scott Hoyt 610782220c Make ConfigurationError marginally more useful by not squashing it in Configuration.rulesFromDict. 2016-01-23 17:42:13 -08:00
Scott Hoyt e2265cf9a7 Removed ViolationSeverity extension. Moved into a private function of SeverityConfig. 2016-01-23 17:42:13 -08:00
Scott Hoyt 95a7352760 Remove unnecessary Swift namespace for min and max calls. 2016-01-23 17:42:13 -08:00
Scott Hoyt 9f20fc2232 Switch SeverityConfig.setConfig to guard for better semantics. 2016-01-23 17:42:13 -08:00
Scott Hoyt 42a6e9fde4 Use guard in NameConfig.setConfig for better semantics. 2016-01-23 17:42:13 -08:00
Scott Hoyt 6132d5d282 Provide default implementation for RuleConfig.isEqualTo when it is Equatable. 2016-01-23 17:42:13 -08:00
Scott Hoyt 123d06e585 Switch VariableNameRule to use a guard for early exit if name is excluded. 2016-01-23 17:42:13 -08:00
Scott Hoyt 284d4e1cca Extracted ViolationSeverity initialization via unnormalized String to extension. 2016-01-23 17:42:13 -08:00
Scott Hoyt 885b47d8e7 Extract severity function to ConfigProviderRule extension for better encapsulation. 2016-01-23 17:42:13 -08:00
Scott Hoyt 943ed306a3 Modified names for brevity. 2016-01-23 17:42:13 -08:00
Scott Hoyt f722bcf360 All Rules (with the exception of MissingDocs) now provide some severity configuration. 2016-01-23 17:42:13 -08:00
Scott Hoyt 7af4756e73 Added SeverityConfig and tests. 2016-01-23 17:42:13 -08:00
Scott Hoyt 989bac7ec8 Renamed SeverityLevelConfig to SeverityLevelsConfig. 2016-01-23 17:42:13 -08:00
Scott Hoyt 8ff15625c4 Added exclusions to TypeNameRule. 2016-01-23 17:42:13 -08:00
Scott Hoyt cd5f4570c6 Switched to Set for excluded for performance and semantics. 2016-01-23 17:42:13 -08:00
Scott Hoyt 1f13e1621a Renamed return nil to return .None for semantics. 2016-01-23 17:42:13 -08:00
Scott Hoyt 60546e4c0d Renamed violationSeverity to severity for brevity. 2016-01-23 17:42:13 -08:00
Scott Hoyt 3230c6413e Replaced things in rule configurations named configuration for config to save space. 2016-01-23 17:42:13 -08:00
Scott Hoyt 421aa6e4c8 Added tests for NameConfig. 2016-01-23 17:42:13 -08:00
Scott Hoyt a64f9eddbd SeverityLevelConfig stores levels as Ints now. 2016-01-23 17:42:13 -08:00
Scott Hoyt 53e30574e1 Extracted violationSeverity to NameConfig. 2016-01-23 17:42:13 -08:00
Scott Hoyt 20e8038a91 Changed min/max names to reflect that they belong to name length. 2016-01-23 17:42:13 -08:00
Scott Hoyt bf5a569104 Renamed MinMaxLengthConfig to NameConfig to reflect combined responsibilities. 2016-01-23 17:42:13 -08:00
Scott Hoyt d137dcdbf2 Remove VariableNameRuleConfig in leu of adding excluded to MinMaxLengthConfig. Reduced length of length violation message. 2016-01-23 17:42:13 -08:00
Scott Hoyt 810f813d70 Add min/max thresholds to MinMaxLengthConfig for convenience. 2016-01-23 17:42:13 -08:00
Scott Hoyt d2c697d1bc Rename dictionary keys for length config. 2016-01-23 17:42:13 -08:00
Scott Hoyt 0691b79a08 Rename Rule Configurations. 2016-01-23 17:42:13 -08:00
Scott Hoyt 84aa4793bc Fixed description for VariableNameRule to reflect new responsibility. 2016-01-23 17:42:13 -08:00
Scott Hoyt ddcde17f04 Add min and max length checking responsibilities to VariableNameRule. 2016-01-23 17:42:13 -08:00
Scott Hoyt 873edb724b Provided convenience property params for RuleLevelsConfig. 2016-01-23 17:42:13 -08:00
Scott Hoyt 05a65afc72 Removed ViolationLeveLRule in favor of ConfigurationProviderRule. 2016-01-23 17:42:13 -08:00
Scott Hoyt 0b61c63937 Extracted Rule Configuration structs to own files. 2016-01-23 17:42:13 -08:00
Scott Hoyt 0883f56424 Rename Rule Configuration structures. 2016-01-23 17:42:13 -08:00
Scott Hoyt 6d385736c9 Delete unused ViolationLevelConfiguration protocol. 2016-01-23 17:42:13 -08:00
Scott Hoyt 4ad287d25a Fixed TypeNameRule to match previous definition. 2016-01-23 17:42:13 -08:00
Scott Hoyt 6522addc10 TypeNameRule conforms to ConfigurationProviderRule. 2016-01-23 17:42:13 -08:00
Scott Hoyt d2ec3fb621 Added associated type for ConfigurationProviderRule. 2016-01-23 17:42:13 -08:00
Scott Hoyt 619a3450c2 Fix spacing. 2016-01-23 17:42:13 -08:00
Scott Hoyt 1a2bb1be79 Add MinMaxConfiguration. 2016-01-23 17:42:13 -08:00