Commit Graph
3038 Commits
Author SHA1 Message Date
JP SimardandGitHub 1a76a882ca Ignore incorrect keypath parser diagnostics (#4325)
Works around https://github.com/apple/swift-syntax/issues/888
2022-10-07 10:33:13 -04:00
Marcelo FabriandGitHub 515587fb9f Convert strict_fileprivate rule to SwiftSyntax (#4319) 2022-10-07 02:11:32 -07:00
Marcelo FabriandGitHub f174a55c94 Migrate explicit_enum_raw_value rule to SwiftSyntax (#4281)
* Migrate `explicit_enum_raw_value` rule to SwiftSyntax

* Handle nested enums
2022-10-07 00:56:15 -07:00
Marcelo FabriandGitHub c0a4dd1be7 Rewrite IdenticalOperandsRule with SwiftSyntax (#3894)
* Rewrite IdenticalOperandsRule with SwiftSyntax

* Use folding algorithm from swift-format

* Add workaround for debug builds

* Update implementation after rebasing

* Use SwiftOperators

* Remove focused
2022-10-07 00:55:41 -07:00
JP SimardandGitHub 549c71a27c Introduce LegacyFunctionRuleHelper (#4312) 2022-10-06 16:48:51 -04:00
JP SimardandGitHub a6c90dd942 Rewrite legacy_cggeometry_functions with SwiftSyntax (#4309) 2022-10-06 15:16:49 -04:00
Danny MöschandGitHub 2a95f1bde9 Add tests for fileprivate to private_outlet rule (#4308) 2022-10-06 19:13:25 +02:00
JP SimardandGitHub 5ba9d60f8d Rewrite legacy_nsgeometry_functions with SwiftSyntax (#4307) 2022-10-06 12:46:27 -04:00
Danny MöschandGitHub 8345545865 Make private_unit_test rule correctable (#4293) 2022-10-06 18:03:03 +02:00
JP SimardandGitHub d6fd754679 Rewrite contains_over_range_nil_comparison with SwiftSyntax (#4225)
Use SwiftOperators.
2022-10-06 01:18:31 -04:00
JP SimardandGitHub 4552facb7e [LegacyConstantRule] Remove unused patterns (#4302)
We now just need these patterns for the mapping of legacy to new.
2022-10-05 22:42:09 -04:00
JP SimardandGitHub c29e1673dd Rewrite legacy_constant with SwiftSyntax (#4299) 2022-10-05 21:55:48 -04:00
JP SimardandGitHub 54ec0c9b28 Rewrite trailing_semicolon with SwiftSyntax (#4296) 2022-10-05 18:46:14 -04:00
JP SimardandGitHub 3834e52ac4 Rewrite empty_parameters with SwiftSyntax (#4295) 2022-10-05 18:26:57 -04:00
JP SimardandGitHub 5d9a72b2a5 Make allow_private_set allow fileprivate(set) too (#4294)
As was previously the case.
2022-10-05 17:32:28 -04:00
Danny MöschandGitHub af222a5754 Ignore static methods in private_unit_test rule (#4292)
Static methods cannot be tests.
2022-10-05 21:00:06 +00:00
Danny MöschandGitHub 8eec5e6997 Rewrite private_unit_test with SwiftSyntax (#4285) 2022-10-05 21:15:25 +02:00
JP SimardandGitHub 44382ea397 Avoid making SourceKit requests to get parser diagnostics (#4286)
By using SwiftSyntax instead, we avoid the overhead of a SourceKit
request, which has a significant impact if none of the rules being
corrected use SourceKit.
2022-10-05 15:38:11 +00:00
JP SimardandGitHub 41b8834a13 Rewrite private_outlet with SwiftSyntax (#4228) 2022-10-05 11:29:01 -04:00
Marcelo FabriandGitHub a40cc70478 Migrate no_extension_access_modifier to SwiftSyntax (#4270)
* Migrate `no_extension_access_modifier` to SwiftSyntax

* PR feedback
2022-10-05 00:56:42 -04:00
Marcelo FabriandGitHub 1cbf3caae1 Migrate anonymous_argument_in_multiline_closure to SwiftSyntax (#4279) 2022-10-04 20:57:22 -07:00
Marcelo FabriandGitHub c70510c3ea Migrate strong_iboutlet to SwiftSyntax (#4277) 2022-10-04 10:03:33 -07:00
JP SimardandGitHub 6bfecb8fcc Rewrite nsobject_prefer_isequal with SwiftSyntax (#4283) 2022-10-04 16:34:24 +00:00
JP SimardandGitHub db20dbb4a3 Replace mutating for-in with reduce(into:) (#4282) 2022-10-04 11:47:27 -04:00
JP SimardandGitHub 46649c8662 Rewrite explicit_init with SwiftSyntax (#4223) 2022-10-04 11:20:00 -04:00
JP SimardandGitHub 1662a38922 Rewrite ibinspectable_in_extension with SwiftSyntax (#4227) 2022-10-04 09:28:46 -04:00
JP SimardandGitHub 18ab68859c Rewrite contains_over_filter_count with SwiftSyntax (#4226) 2022-10-04 09:14:27 -04:00
Danny MöschandGitHub ab3f070222 Introduce SeverityBasedRuleConfiguration to avoid custom makeViolations (#4274) 2022-10-04 07:39:07 +02:00
Marcelo FabriandGitHub e3f1b56129 Convert duplicate_enum_cases rule to SwiftSyntax (#4263) 2022-10-03 13:20:43 -07:00
Marcelo FabriandGitHub 26ca731cf0 Migrate deployment_target rule to SwiftSyntax (#4268) 2022-10-03 10:18:56 -07:00
Marcelo FabriandGitHub 8926596da0 Migrate closure_parameter_position to SwiftSyntax (#4264) 2022-10-03 10:18:43 -07:00
Marcelo FabriandGitHub 647819eedc Migrate switch_case_on_newline to SwiftSyntax (#4269) 2022-10-03 09:28:29 -07:00
Marcelo FabriandGitHub f37ea8acc4 Migrate no_fallthrough_only rule to SwiftSyntax (#4266) 2022-10-03 09:28:14 -07:00
Marcelo FabriandGitHub ac91f7bfa0 Migrate private_action rule to SwiftSyntax (#4267) 2022-10-03 09:27:29 -07:00
Marcelo FabriandGitHub 462f741065 Rewrite redundant_string_enum_value with SwiftSyntax (#4243) 2022-10-02 17:29:55 -07:00
Marcelo FabriandGitHub 268415893d Rewrite protocol_property_accessors_order with SwiftSyntax (#4237)
* Rewrite protocol_property_accessors_order with SwiftSyntax

* PR feedback
2022-10-02 17:29:04 -07:00
JP SimardandGitHub 2388e49190 Use SwiftSyntax's new SwiftParser (#4216) 2022-10-01 15:05:36 -04:00
JP SimardandGitHub b2caef7202 Generate Swift Syntax Dashboard in documentation (#4260)
This is a useful overview of where the migration effort stands and what
rules can be migrated next.
2022-10-01 11:29:10 -04:00
Benjamin KramerandGitHub 0fe3404494 Add configuration only_enforce_before_trivial_lines to vertical_whitespace_closing_braces rule (#3941)
Vertical whitespace may be important for readability when the line
with the closing brace is not a trivial one (e.g. `} else if ... {`).
The configuration allows not enforcing the rule in such cases.
2022-09-29 20:26:51 +02:00
Marcelo FabriandGitHub a40488feaf Rewrite inert_defer rule with SwiftSyntax (#4242) 2022-09-28 19:57:00 -07:00
Danny MöschandGitHub c6eec8072c Move method (#4238) 2022-09-25 12:31:24 -04:00
Marcelo FabriandGitHub a4c46f624d Rewrite no_space_in_method_call with SwiftSyntax (#4236) 2022-09-25 02:55:00 -07:00
Marcelo FabriandGitHub 734eceada0 Rewrite empty_parentheses_with_trailing_closure with SwiftSyntax (#4235) 2022-09-25 02:54:29 -07:00
Danny MöschandGitHub 7be6f866fe Add new if_let_shadowing rule (#4206) 2022-09-22 19:27:45 +02:00
Martin RedingtonandGitHub 0db26db975 Add test_parent_classes option to test_case_accessibility rule (#4214) 2022-09-21 18:29:32 +02:00
Marcelo FabriandGitHub f8a4276aba Rewrite generic_type_name rule with SwiftSyntax (#4229) 2022-09-21 08:29:52 -07:00
JP SimardandGitHub 7b1de2f9cd Rewrite dynamic_inline with SwiftSyntax (#4218) 2022-09-20 20:07:24 +00:00
JP SimardandGitHub 49665a9ec7 Rewrite fallthrough with SwiftSyntax (#4224) 2022-09-20 15:56:57 -04:00
Danny MöschandGitHub 0ea26edd4f Skip autocorrecting usage of NSIntersectionRect (#4213) 2022-09-20 07:09:05 +02:00
Danny MöschandGitHub 2efa085dd4 Make willMove a lifecycle method in type_contents_order rule (#4201) 2022-09-19 23:27:15 +02:00