12eb3fece7
Updating reason message
2016-01-14 20:47:17 -08:00
579872cd30
Handling multiline comments and correcting line count on violation reason
2016-01-14 20:26:20 -08:00
ea33640296
Caching
2016-01-14 20:25:51 -08:00
72f401497d
Refactoring
2016-01-14 20:25:51 -08:00
07c076689b
Address performance issues
2016-01-14 20:24:47 -08:00
04b2510926
FunctionBodyLengthRule should not count comment lines
2016-01-14 20:24:47 -08:00
39d59c662a
Changed MissingDocsRule to ConfigurableRule.
2016-01-14 08:52:47 -08:00
3a134b2338
Migrated FileLengthRule to ViolationLevelRule.
2016-01-13 19:45:27 -08:00
62a0d83f9b
Migrated FunctionBodyLengthRule to ViolationLevelRule.
2016-01-13 19:45:27 -08:00
9f7ea52f9f
Migrated LineLengthRule to ViolationLevelRule.
2016-01-13 19:45:27 -08:00
5c5335d504
Migrated TypeBodyLengthRule to ViolationLevelRule.
2016-01-13 19:45:27 -08:00
5f39bea9b2
Migrated VariableNameMaxLengthRule to ViolationLevelRule.
2016-01-13 19:45:27 -08:00
f56875bb87
fix spacing issues in LegacyConstructorRule
2016-01-13 17:56:53 -08:00
3fef742136
fix a few mistakes in legacy constructor corrections
2016-01-13 17:55:19 -08:00
f877bc2d25
Resolved issues based on feedback from @jpsim
2016-01-13 17:17:41 -08:00
20dbbe81b7
Implement LegacyConstantRule
...
From #319
CGGeometry: Prefer struct-scope constants CGRect.infinite, CGRect.null,
etc. over global constants CGRectInfinite, CGRectNull, etc.
2016-01-13 17:17:35 -08:00
77d2dd4e08
make MissingDocsRule parameterizable again
2016-01-13 16:41:09 -08:00
7f34efccbf
make missing_docs rule opt-in
2016-01-13 16:41:09 -08:00
6f73c7632e
[MissingDocsRule] skip overridden members when checking for missing docs
2016-01-13 16:41:09 -08:00
a5eb7c64fb
[MissingDocsRule] skip inherited members when checking for missing docs
2016-01-13 16:41:08 -08:00
4e461bc9ba
use shorter ACL strings when parameterizing MissingDocsRule
...
also fix the integration tests by using the configuration file
2016-01-13 16:41:02 -08:00
139329cd33
parameterized MissingDocsRule on AccessControlLevel
2016-01-13 15:59:49 -08:00
a2f06246d0
improve MissingDocsRule
...
by checking for documentation comment body rather than doc comment attribute
2016-01-13 15:59:37 -08:00
9eabd45ce5
add "Missing Docs" rule
2016-01-13 15:59:37 -08:00
4c52163a70
add rule to encourage checking isEmpty over comparing count to zero
2016-01-13 15:41:25 -08:00
e13907ead3
fix infinite regex search & 'where' false positive in ConditionalBindingCascadeRule
2016-01-12 18:35:31 -08:00
7268d373cc
minor tweaks from #314
2016-01-12 11:41:33 -08:00
647371517e
Extracted arrayOf to Array extension and used to simplify VariableNameMinLengthRule.init?(config:).
2016-01-11 13:10:17 -08:00
55fa348b6d
Made ParameterizedRule protocol inherit from ConfigurableRule with default implementation for conformance.
2016-01-11 11:21:49 -08:00
8d6f1ad1d7
Added [Int] support for VariableNameMinLengthRule configuration.
2016-01-11 11:21:49 -08:00
23265f0ff6
Changed VariableNameMinLengthRule.isEqualTo to use a guard.
2016-01-11 11:21:49 -08:00
30e7018532
Fixed typo in rule name and reattributed.
2016-01-11 11:21:49 -08:00
60583256fe
Replaced VariableNameMinLengthRule with new version using ConfigurableRule
2016-01-11 11:21:49 -08:00
7bb8316664
Removed new test rule from master list and made to pass tests.
2016-01-11 11:21:49 -08:00
acda12447b
Update VariableNameMinLengthNew.isEqualTo for bug in how SwiftXPC handles comparing two empty [String]'s
2016-01-11 11:21:49 -08:00
dd58175000
Added example VariableNameMinLengthNewRule using ConfigurableRule.
2016-01-11 11:21:49 -08:00
c2d40c1f94
Extracted all ParameterizedRule conformance to ConfigurableRule out to protocol extension.
2016-01-11 11:21:49 -08:00
3387c0d592
Extracted isEqualTo to protocol extension.
2016-01-11 11:21:49 -08:00
9b6f3070a3
Wrote ConfigurableRule, made ParameterizedRule's conform, moved configuration into rules themselves.
2016-01-11 11:21:49 -08:00
7b046465c8
Fixed two more edge cases for non-triggering examples
2016-01-11 07:41:56 -08:00
fb234901df
Fix initial newline
2016-01-11 07:40:41 -08:00
1b6dbabb40
Improve performance of ConditionalBindingCascadeRule
2016-01-11 07:40:33 -08:00
fe3136d8ff
Adding ConditionalBindingCascadeRule
2016-01-11 07:40:16 -08:00
7fa100a033
Reduce calls to String.characters.count in LineLengthRule.validateFile(_:)
...
By applying this, the duration of linting Carthage is reduced from:
```
swiftlint lint 20.07s user 1.10s system 84% cpu 25.023 total
```
to:
```
swiftlint lint 18.27s user 1.05s system 84% cpu 22.769 total
```
2016-01-10 20:44:36 +09:00
b33c5d870f
Update CommaRule.swift
...
Reword the description a bit, based on @jpsim's suggestion.
2016-01-09 01:42:47 -06:00
a7b65b2570
Fix typo in CommaRule.swift
...
The description implied the opposite of the rule.
2016-01-09 00:02:25 -06:00
d9a885e5b5
Add AutoCorrect for LegacyConstructorRule
2016-01-08 23:02:09 +01:00
e4f27dab63
Add autocorrect for CommaRule
2016-01-08 21:49:32 +01:00
ef4e3c9ddf
Merge pull request #325 from realm/nn-fix-324
...
Fix regex for ignoring closure parameter on detecting return value
2016-01-07 16:28:58 -08:00
8edc234e64
Fix regex for ignoring closure parameter on detecting return value
...
fix #324
2016-01-08 09:12:17 +09:00
Marcelo Fabri
Scott Hoyt
JP Simard
Aaron McTavish
Norio Nomura
Eric Bailey
Raphael Randschau