Commit Graph

351 Commits

Author SHA1 Message Date
Marcelo Fabri 12eb3fece7 Updating reason message 2016-01-14 20:47:17 -08:00
Marcelo Fabri 579872cd30 Handling multiline comments and correcting line count on violation reason 2016-01-14 20:26:20 -08:00
Marcelo Fabri 811cfd152e Clearing syntaxKindsByLinesCache 2016-01-14 20:25:51 -08:00
Marcelo Fabri ea33640296 Caching 2016-01-14 20:25:51 -08:00
Marcelo Fabri 72f401497d Refactoring 2016-01-14 20:25:51 -08:00
Marcelo Fabri 08ad3d333b Fix comparision when startLine or endLine is nil 2016-01-14 20:24:47 -08:00
Marcelo Fabri 07c076689b Address performance issues 2016-01-14 20:24:47 -08:00
Marcelo Fabri 57cf38a388 Fix identation 2016-01-14 20:24:47 -08:00
Marcelo Fabri 04b2510926 FunctionBodyLengthRule should not count comment lines 2016-01-14 20:24:47 -08:00
JP Simard d76a003bbc release 0.6.0 2016-01-14 16:00:41 -08:00
Scott Hoyt e389aafa0c Removed ruleParametersFromArray. 2016-01-14 08:53:18 -08:00
Scott Hoyt 39d59c662a Changed MissingDocsRule to ConfigurableRule. 2016-01-14 08:52:47 -08:00
Scott Hoyt e5cbd81002 Switched out count > 0 with !isEmpty. 2016-01-13 19:45:27 -08:00
Scott Hoyt f693279fb5 Removed ParameterizedRule. Deleted unnecessary tests. Switched tests to ViolationLevelRuleMock where needed. 2016-01-13 19:45:27 -08:00
Scott Hoyt 3a134b2338 Migrated FileLengthRule to ViolationLevelRule. 2016-01-13 19:45:27 -08:00
Scott Hoyt 62a0d83f9b Migrated FunctionBodyLengthRule to ViolationLevelRule. 2016-01-13 19:45:27 -08:00
Scott Hoyt 9f7ea52f9f Migrated LineLengthRule to ViolationLevelRule. 2016-01-13 19:45:27 -08:00
Scott Hoyt 5c5335d504 Migrated TypeBodyLengthRule to ViolationLevelRule. 2016-01-13 19:45:27 -08:00
Scott Hoyt 5f39bea9b2 Migrated VariableNameMaxLengthRule to ViolationLevelRule. 2016-01-13 19:45:27 -08:00
Scott Hoyt 7c6feec509 Added ViolationLevelRule and tests. 2016-01-13 19:45:27 -08:00
Scott Hoyt 592a358d8c Added deprecation warning for ParameterizedRule. 2016-01-13 19:45:27 -08:00
JP Simard e197ae6c7b update CHANGELOG after releasing 0.5.6 2016-01-13 18:41:10 -08:00
JP Simard b877ed158b Merge pull request #361 from realm/jp-revert-bad-csv-quote-escape
Revert "fix escaped double quote character"
2016-01-13 18:24:13 -08:00
JP Simard 5bf0f89835 Revert "fix escaped double quote character"
This reverts commit a0a76d898f.

Turns out that the previous version was correct.
See https://en.wikipedia.org/wiki/Comma-separated_values
2016-01-13 18:22:00 -08:00
JP Simard f56875bb87 fix spacing issues in LegacyConstructorRule 2016-01-13 17:56:53 -08:00
JP Simard 3fef742136 fix a few mistakes in legacy constructor corrections 2016-01-13 17:55:19 -08:00
Aaron McTavish f877bc2d25 Resolved issues based on feedback from @jpsim 2016-01-13 17:17:41 -08:00
Aaron McTavish 20dbbe81b7 Implement LegacyConstantRule
From #319

CGGeometry: Prefer struct-scope constants CGRect.infinite, CGRect.null,
etc. over global constants CGRectInfinite, CGRectNull, etc.
2016-01-13 17:17:35 -08:00
JP Simard 78ec5244f7 combine guards in rebuildAllDeclarationsByType 2016-01-13 16:54:30 -08:00
JP Simard 12c510c605 don't parse class declarations in rebuildAllDeclarationsByType
because this is only used in the missing docs rule which handles class
declarations by checking the "override" keyword
2016-01-13 16:44:14 -08:00
JP Simard 77d2dd4e08 make MissingDocsRule parameterizable again 2016-01-13 16:41:09 -08:00
JP Simard 7f34efccbf make missing_docs rule opt-in 2016-01-13 16:41:09 -08:00
JP Simard 6f73c7632e [MissingDocsRule] skip overridden members when checking for missing docs 2016-01-13 16:41:09 -08:00
JP Simard 270fa90f3a make File.allDeclarationsByType lazier 2016-01-13 16:41:09 -08:00
JP Simard a5eb7c64fb [MissingDocsRule] skip inherited members when checking for missing docs 2016-01-13 16:41:08 -08:00
JP Simard 4e461bc9ba use shorter ACL strings when parameterizing MissingDocsRule
also fix the integration tests by using the configuration file
2016-01-13 16:41:02 -08:00
JP Simard 139329cd33 parameterized MissingDocsRule on AccessControlLevel 2016-01-13 15:59:49 -08:00
JP Simard a2f06246d0 improve MissingDocsRule
by checking for documentation comment body rather than doc comment attribute
2016-01-13 15:59:37 -08:00
JP Simard 9eabd45ce5 add "Missing Docs" rule 2016-01-13 15:59:37 -08:00
JP Simard 4c52163a70 add rule to encourage checking isEmpty over comparing count to zero 2016-01-13 15:41:25 -08:00
JP Simard e13907ead3 fix infinite regex search & 'where' false positive in ConditionalBindingCascadeRule 2016-01-12 18:35:31 -08:00
JP Simard 2f3b2096e6 support opt-in rules 2016-01-12 12:11:09 -08:00
JP Simard 7268d373cc minor tweaks from #314 2016-01-12 11:41:33 -08:00
Scott Hoyt 47f4889cb2 Removed redundant self. 2016-01-11 13:55:36 -08:00
Scott Hoyt 647371517e Extracted arrayOf to Array extension and used to simplify VariableNameMinLengthRule.init?(config:). 2016-01-11 13:10:17 -08:00
Scott Hoyt 55fa348b6d Made ParameterizedRule protocol inherit from ConfigurableRule with default implementation for conformance. 2016-01-11 11:21:49 -08:00
Scott Hoyt 8d6f1ad1d7 Added [Int] support for VariableNameMinLengthRule configuration. 2016-01-11 11:21:49 -08:00
Scott Hoyt 46838b11f1 Fixed access level issues. 2016-01-11 11:21:49 -08:00
Scott Hoyt 23265f0ff6 Changed VariableNameMinLengthRule.isEqualTo to use a guard. 2016-01-11 11:21:49 -08:00
Scott Hoyt 53efa3f23b Removed spurious selfs 2016-01-11 11:21:49 -08:00