Commit Graph

1455 Commits

Author SHA1 Message Date
Marcelo Fabri 09c29b169d Fix false positive in syntactic_sugar rule when using nested types
Fixes #1508
2017-05-21 23:17:53 +02:00
JP Simard 3968b01bb6 update tests to reflect unicode fixes in SourceKitten 2017-05-19 14:10:24 -07:00
JP Simard 416384c4a5 Merge pull request #1526 from realm/jp-xcode-reporter-line-fallback
Fall back to line 1 when no line is provided & reporting with `xcode`
2017-05-18 15:42:50 -07:00
JP Simard 2704b3e1de report file_header violations on line 1 for all reporters 2017-05-18 15:11:50 -07:00
JP Simard 385d726e52 simplify Configuration.swift's usage of its default file manager 2017-05-18 13:04:09 -07:00
JP Simard 8c9cba0c0f fallback to line 1 when no line is provided & reporting with xcode
this is a generalization of the fix from #1521
2017-05-17 14:56:46 -07:00
Richard Hodge 32c58aaf5a Update file_header rule to trigger on line 1 for files that are missing a header. (#1521)
Fixes #1520
2017-05-17 16:19:31 +02:00
JP Simard 65f32a14dd refactor CustomRules.validate(file:) 2017-05-16 11:28:01 -07:00
JP Simard d8ca9cb1fb use default implementation of configurationDescription
for ConditionalReturnsOnNewlineRule
2017-05-16 11:26:22 -07:00
JP Simard 04824c9b51 move 'AccessControlLevel.swift' from 'Extensions' to 'Models' 2017-05-16 10:58:49 -07:00
JP Simard 92043af1c0 rename ConditionalReturnsOnNewline to ConditionalReturnsOnNewlineRule
to match conventions used for rules
2017-05-16 10:58:47 -07:00
JP Simard 61e9b39327 prefer contains over first(where:) != nil 2017-05-15 11:50:53 -07:00
JP Simard bb4c94be27 fold patternKind & pattern into flatMap block
since these are string literals, they'll only be included once in the binary
2017-05-15 11:17:06 -07:00
Marcelo Fabri 85bd94d33a Merge pull request #1510 from marcelofabri/ignoreOptionalTry-default-false
Change the default of ignoreOptionalTry to false in UnusedOptionalBindingRule
2017-05-15 00:38:19 +02:00
Marcelo Fabri eec8935091 Merge pull request #1444 from jaherhi/identifier_name_allow_non_alphanumeric_and_uppercase_characters
Add options to disable some checks for identifier_name rule
2017-05-15 00:31:39 +02:00
Marcelo Fabri 1e115be030 Change the default of ignoreOptionalTry to false in UnusedOptionalBindingRule
To avoid breaking changes.
2017-05-15 00:19:07 +02:00
Javier Hernández d652cfe4ab Add options to generic_type_name and type_name rules 2017-05-10 21:02:30 +01:00
Javier Hernández 9d31eaccda Rename option to validates_start_lowercase 2017-05-10 20:53:44 +01:00
Javier Hernández 3245fd83a9 Fix tests 2017-05-10 20:53:44 +01:00
Javier Hernández fe916c121f Add option to allow names to start with uppercase 2017-05-10 20:53:44 +01:00
Javier Hernández 93583f3153 Add option to exclude non alphanumeric characters 2017-05-10 20:53:42 +01:00
Marcelo Fabri 991d1fa65a Add empty_enum_arguments rule
Fixes #1425
2017-05-08 08:29:27 +02:00
Marcelo Fabri db66e74ccd Merge pull request #1499 from marcelofabri/complexityConfigTypo
Fix `ignores_case_statements` key in `cyclomatic_complexity` description
2017-05-07 17:11:50 +02:00
Jeffrey Blagdon 2e3130048f Fix ignores_case_statements key in cyclomatic_complexity description
Fixes #1434.
2017-05-07 17:10:21 +02:00
Marcelo Fabri 6805c4a1e0 Merge pull request #1480 from marcelofabri/unused_optional_binding_rule_ignore_option
Unused optional binding rule ignore option
2017-05-07 17:03:15 +02:00
Marcelo Fabri 2282362989 Remove extra parenthesis on file header rule description 2017-05-04 21:37:34 +02:00
Marcelo Fabri 9412861143 Prevent triggering redundant_optional_initialization rule on a lazy var
Fixes #1334
2017-05-02 00:15:44 +02:00
Marcelo Fabri 32d5266409 Small rule improvements 2017-05-01 16:11:12 +02:00
Сергей Галездинов 894416a1a1 filter optional try's from matches when ignore_optional_try is true 2017-05-01 14:59:00 +02:00
Сергей Галездинов 74e77e82bb Additional configuration for UnusedOptionalBindingRule 2017-05-01 14:59:00 +02:00
Marcelo Fabri d356522491 Add implicit_return rule
Fixes #1194
2017-05-01 00:58:58 +02:00
JP Simard a841508c0b Merge pull request #1476 from marcelofabri/top-acl
Add explicit_top_level_acl opt-in rule
2017-04-30 12:26:13 -07:00
Marcelo Fabri 4a9ba8248f Fix build with Swift 3.0.x 2017-04-30 20:42:09 +02:00
Marcelo Fabri 74b7744de6 Alternative implementation 2017-04-30 20:17:41 +02:00
Marcelo Fabri 42e6c8a06c Fix empty_parameters rule with Swift 3
Fixes #1460
2017-04-30 17:27:51 +02:00
J Cheyo Jimenez d608a632fd replace NSNumber with Int64 to fix Linux boxes 2017-04-29 21:36:56 -07:00
J Cheyo Jimenez 06b1446ae7 Fix violations starting at zero index 2017-04-29 19:21:49 -07:00
J Cheyo Jimenez 1ce589ee82 Added ExplicitInternalTopLevelRule 2017-04-29 18:51:45 -07:00
JP Simard 5673b3fb5e Merge pull request #1455 from marcelofabri/remove-swift-2-support
Remove Swift 2 support
2017-04-25 15:53:30 -07:00
Jeffrey 3812ef3612 change parameter.value to configuration.warning 2017-04-25 13:46:44 -07:00
Jeffrey a37445d068 Revert "We should be using parameter.value instead of configuration.warning in order to report accurate information about the violation."
This reverts commit c4006276a3.
2017-04-25 13:39:12 -07:00
Jeffrey c4006276a3 We should be using parameter.value instead of configuration.warning in order to report accurate information about the violation. 2017-04-24 18:28:40 -07:00
Spencer Kaiser acea43409f Fixing a minor typo 2017-04-24 15:41:11 -05:00
Marcelo Fabri d73ee8d3d9 Remove Swift 2 support
Also removes `missing_docs` and `valid_docs` rules.

Fixes #1453.
2017-04-23 13:43:41 +02:00
Marcelo Fabri 80b0c96dd7 Merge pull request #1438 from mobiledevstandards/1437_custom_excluded
Adds support for excluded in custom rules
2017-04-23 12:18:34 +02:00
Jay Moore ad621bcc12 add tests for missing colon, lowercase mark 2017-04-23 02:55:15 +02:00
Norio Nomura a3d6a4295d NSRegularExpression is added on Linux 2017-04-17 17:22:54 +09:00
Nigel Flack 6321e24877 Adds support for excluded in custom rules 2017-04-14 15:14:45 +01:00
Norio Nomura ccf85e87c3 Make emoji and checkstyle reporter to output report sorted by file name
Fixes #1429
2017-04-12 22:36:27 +09:00
Samuel Susla 32e7963b68 Merge branch 'master' of https://github.com/realm/SwiftLint into trailing-comma-autocorrect 2017-04-09 20:31:02 +02:00