GitHub/SwiftLint
1
0
Fork 0
mirror of https://github.com/realm/SwiftLint.git synced 2026-06-06 20:18:40 +00:00
Code Issues Packages Projects Releases Wiki Activity
735 Commits 134 Branches 150 Tags
0691b79a08b22038bdfd115b68471c7ef1eaace5
Commit Graph

138 Commits

Author SHA1 Message Date
Scott Hoyt 0691b79a08 Rename Rule Configurations. 2016-01-23 17:42:13 -08:00
Scott Hoyt ddcde17f04 Add min and max length checking responsibilities to VariableNameRule. 2016-01-23 17:42:13 -08:00
Scott Hoyt 05a65afc72 Removed ViolationLeveLRule in favor of ConfigurationProviderRule. 2016-01-23 17:42:13 -08:00
Scott Hoyt b92c24136c Fixed tests for throwing ConfigurableRule init. 2016-01-23 17:42:13 -08:00
Marcelo Fabri 0c630720b6 Refactoring testTypeBodyLengths to compile faster 2016-01-21 22:59:08 -08:00
Marcelo Fabri 3416217927 TypeBodyLengthRule should not count comment and whitespace lines 2016-01-21 22:29:38 -08:00
JP Simard c9246542ad fix infinite recursion when using nested config files. Fixes #368 2016-01-21 12:49:04 -08:00
JP Simard 04267a499e rewrite FunctionBodyLengthRuleTests to compile 500x faster 
before:
  10828.9ms @objc func testFunctionBodyLengthsWithComments()
  10250.3ms @objc func testFunctionBodyLengthsWithMultilineComments()
  1236.7ms  @objc func testFunctionBodyLengths()

after:
  18.5ms @objc func testFunctionBodyLengths()
  16.0ms private func funcWithBody(body: String) -> String
  6.5ms  @objc func testFunctionBodyLengthsWithMultilineComments()
  5.7ms  @objc func testFunctionBodyLengthsWithComments()
 2016-01-18 14:15:39 -08:00
Marcelo Fabri 75a4f2f2dc Changing reason message 2016-01-14 21:24:24 -08:00
Marcelo Fabri 12eb3fece7 Updating reason message 2016-01-14 20:47:17 -08:00
Marcelo Fabri 579872cd30 Handling multiline comments and correcting line count on violation reason 2016-01-14 20:26:20 -08:00
Marcelo Fabri 483fbc0a34 Fix identation 2016-01-14 20:24:47 -08:00
Marcelo Fabri 04b2510926 FunctionBodyLengthRule should not count comment lines 2016-01-14 20:24:47 -08:00
Scott Hoyt f693279fb5 Removed ParameterizedRule. Deleted unnecessary tests. Switched tests to ViolationLevelRuleMock where needed. 2016-01-13 19:45:27 -08:00
Scott Hoyt 7c6feec509 Added ViolationLevelRule and tests. 2016-01-13 19:45:27 -08:00
Aaron McTavish 20dbbe81b7 Implement LegacyConstantRule 
From #319

CGGeometry: Prefer struct-scope constants CGRect.infinite, CGRect.null,
etc. over global constants CGRectInfinite, CGRectNull, etc.
 2016-01-13 17:17:35 -08:00
JP Simard a5eb7c64fb [MissingDocsRule] skip inherited members when checking for missing docs 2016-01-13 16:41:08 -08:00
JP Simard 4e461bc9ba use shorter ACL strings when parameterizing MissingDocsRule 
also fix the integration tests by using the configuration file
 2016-01-13 16:41:02 -08:00
JP Simard a2f06246d0 improve MissingDocsRule 
by checking for documentation comment body rather than doc comment attribute
 2016-01-13 15:59:37 -08:00
JP Simard 9eabd45ce5 add "Missing Docs" rule 2016-01-13 15:59:37 -08:00
JP Simard 4c52163a70 add rule to encourage checking isEmpty over comparing count to zero 2016-01-13 15:41:25 -08:00
Scott Hoyt 55fa348b6d Made ParameterizedRule protocol inherit from ConfigurableRule with default implementation for conformance. 2016-01-11 11:21:49 -08:00
Scott Hoyt dd243edf53 Removed unnecessary setUp override. 2016-01-11 11:21:49 -08:00
Scott Hoyt 35c92ff8fe Fix style issues. 2016-01-11 11:21:49 -08:00
Scott Hoyt 943424dbb9 Fixed dictionary literal style. 2016-01-11 11:21:49 -08:00
Scott Hoyt db03299828 Remove redundant module reference. 2016-01-11 11:21:49 -08:00
Scott Hoyt 6bcc06256c Removed unnecessary inits. 2016-01-11 11:21:49 -08:00
Scott Hoyt 7efb020a4b Added tests for configuring rules from config dictionary. 2016-01-11 11:21:49 -08:00
Scott Hoyt fa7d4024e3 Switched Configurable rule to a failable initializer that takes AnyObject. 2016-01-11 11:21:49 -08:00
Scott Hoyt 1448576039 Added tests for configuring ParameterizedRules with config dictionaries. 2016-01-11 11:21:49 -08:00
Scott Hoyt 9b6f3070a3 Wrote ConfigurableRule, made ParameterizedRule's conform, moved configuration into rules themselves. 2016-01-11 11:21:49 -08:00
Scott Hoyt 2922ff14c4 Extracted Yaml parsing tests and rewrote Configuration tests to be Dictionary-based. 2016-01-11 11:18:54 -08:00
Scott Hoyt eab96555e5 Switch to non optional Configuration initialization from dictionary. 2016-01-11 11:18:54 -08:00
Scott Hoyt 6510960fa6 Began extracting Yaml dependency out of Configuration and into YamlParser 2016-01-11 11:18:54 -08:00
Scott Hoyt 31b9cc0149 Remove redundant YAML functions from Configuration. 2016-01-11 11:18:54 -08:00
Scott Hoyt ddcc67273b Added tests for new Yaml+SwiftLint extensions. 2016-01-11 11:14:54 -08:00
Aaron McTavish 752b18ade2 Remove unnecessary whitespace 2016-01-11 07:40:37 -08:00
Aaron McTavish fe3136d8ff Adding ConditionalBindingCascadeRule 2016-01-11 07:40:16 -08:00
Sebastian Grail 2d27db5e1f Fix typo in FunctionBodyLengthRule and TypeBodyLengthRule 2016-01-04 15:38:54 +11:00
JP Simard 1e553a54bb fix ConfigurationTests 
by moving String.stringByAppendingPathComponent to the test

also remove @testable annotation because it is unused
 2016-01-02 16:06:32 -08:00
Scott Hoyt 6c2adce0cf Cleaned up project mock *.yml's. 2016-01-02 15:41:53 -08:00
Scott Hoyt 246adf6353 No longer needed RuleMocks at global scope. 2016-01-02 15:41:53 -08:00
Scott Hoyt 39a0953f32 Replace manual config mocks with file-driven. 2016-01-02 15:41:53 -08:00
Scott Hoyt 314f72a7d7 Added Nested Configuration testing. 2016-01-02 15:41:53 -08:00
Scott Hoyt 5b023501c2 Tested merge. 2016-01-02 15:41:53 -08:00
Scott Hoyt 369ef23c1f Extracted Configuration mocks to test class constants. 2016-01-02 15:41:53 -08:00
Scott Hoyt 7b2f4bff43 Moved == implementation for [Rule] to more appropriate spot. Wrote missing test. 2016-01-02 15:41:53 -08:00
Scott Hoyt fcf9396a08 Added isEqual for Rule and ParameterizedRule. Made Configuration and RuleParameter conform to Equatable. Wrote tests to verify. All done in support of testing recursive configuration file search. 2016-01-02 15:41:53 -08:00
JP Simard c8fa4e08f2 only generate violations once for triggering examples in verifyRule() 2015-12-27 21:51:06 -05:00
JP Simard 85d8c68978 test violation locations 2015-12-27 13:33:42 -05:00