3377 Commits

Author SHA1 Message Date
JP Simard 04d1184904 Remove structure cache (#4541) 2022-11-10 14:53:16 -05:00
JP Simard 4bd7da32ea Reduce visibility of rules to be internal (#4533)
There's no reason to expose these publicly and this will make it nicer
to move to a new module outside of the core SwiftLint functionality.
2022-11-09 11:01:26 -05:00
Danny Mösch 3864ecc12f Fix indentation in error message (#4528) 2022-11-07 14:47:14 -05:00
Marcelo Fabri eaf7db1250 Rewrite object_literal rule with SwiftSyntax (#4525) 2022-11-06 20:42:00 -08:00
Marcelo Fabri 6c7e2107ae Rewrite nslocalizedstring_key with SwiftSyntax (#4523) 2022-11-06 19:12:53 -08:00
Danny Mösch 1edef5ebdc Trigger prefer_self_in_static_references rule on constructor calls (#4519) 2022-11-06 14:55:28 +01:00
Danny Mösch 7e8a3ae2ac Introduce onlyElement property on Collection (#4518) 2022-11-06 07:37:44 -05:00
Marcelo Fabri 45ac3dcdff Rewrite required_enum_case with SwiftSyntax (#4521) 2022-11-06 01:26:11 -08:00
Marcelo Fabri 1c675bc993 Rewrite balanced_xctest_lifecycle with SwiftSyntax (#4520) 2022-11-06 00:05:32 -07:00
Marcelo Fabri fc0c0c7f5b Rewrite pattern_matching_keywords with SwiftSyntax (#4490) 2022-11-05 23:16:59 -07:00
Marcelo Fabri 22522254df Validate shorthand option binding in self_binding rule (#4514)
* Validate shorthand option binding in `self_binding` rule

* Fix CHANGELOG
2022-11-05 21:32:09 -07:00
Danny Mösch 9a706ba371 Trigger prefer_self_in_static_references rule in computed property blocks (#4517) 2022-11-06 00:19:48 +01:00
Danny Mösch d4ea19e434 Trigger prefer_self_in_static_references rule on key paths (#4516) 2022-11-05 13:39:27 +01:00
Danny Mösch eb3d502ad7 Rephrase rule description letting it no longer refer to classes only (#4515) 2022-11-05 07:13:24 -04:00
Danny Mösch 65874dc40f Rewrite prefer_self_in_static_references with SwiftSyntax (#4504) 2022-11-05 11:46:33 +01:00
Craig Siemens ec5124d939 Rewrite multiline_arguments_brackets with SwiftSyntax (#4512)
Fix false-positives when a function call has a single line closure.
2022-11-03 21:57:27 -04:00
John Szumski 6fcdd8077f Adds NSError to the list of types in discouraged_direct_init. (#4508) 2022-11-03 13:52:30 -04:00
Danny Mösch 32152646f3 Use Self in constructor calls (#4505) 2022-11-02 22:50:22 +00:00
JP Simard e97119efec Migrate orphaned_doc_comment to use SwiftSyntax classifications (#4461) 2022-11-02 15:55:47 +00:00
JP Simard f1f6a3c4a0 Add ByteSourceRange.toSourceKittenByteRange() helper (#4500)
This will be useful for other rules too.
2022-11-01 14:13:29 -04:00
JP Simard 79e3c8bd4a Add special handling for https://github.com/apple/swift/issues/61817 (#4498) 2022-10-31 09:58:36 -04:00
Marcelo Fabri 20bfe264f5 Rewrite overridden_super_call and prohibited_super_call with SwiftSyntax (#4493)
* Rewrite `overridden_super_call` with SwiftSyntax

* Rewrite `prohibited_super_call` too
2022-10-30 20:28:25 -07:00
Marcelo Fabri 697eaa73dd Rewrite private_subject rule with SwiftSyntax (#4495) 2022-10-30 18:41:57 -07:00
Henry 63c043664d Add new no_magic_numbers rule (#4265) 2022-10-30 15:28:20 +01:00
JP Simard a18436d4d6 Rewrite optional_enum_case_matching with SwiftSyntax (#4488) 2022-10-28 19:30:33 +00:00
JP Simard d551cb8c16 Update SwiftSyntax (#4480)
Moves syntax classifications to a new IDEUtils module.
2022-10-28 09:23:06 -04:00
JP Simard 1b59a3f168 Cache location converters (#4481)
This is 2%-12% faster according to OSSCheck
2022-10-26 12:37:16 -04:00
Marcelo Fabri d37465ad37 Rewrite vertical_parameter_alignment with SwiftSyntax (#4466)
* Rewrite `vertical_parameter_alignment` rule with SwiftSyntax

* Validate inits
2022-10-24 12:56:48 -07:00
Marcelo Fabri 50c85ef5c1 Rewrite explicit_top_level_acl with SwiftSyntax (#4450) 2022-10-24 11:31:12 -07:00
Marcelo Fabri fa6db3cca7 Rewrite collection_alignment rule with SwiftSyntax (#4472) 2022-10-24 10:51:31 -07:00
Marcelo Fabri 31ea58381c Add example for #3558 (#4471)
Fixes #3558
2022-10-24 06:14:30 -04:00
Marcelo Fabri 95838aa230 Add example for #2008 (#4470)
Fixes #2008
2022-10-24 05:32:56 -04:00
Marcelo Fabri f8d505a225 Add example for #3945 (#4469)
Fixes #3945
2022-10-24 09:23:37 +00:00
Marcelo Fabri 7a8de1c966 Add example for #2782 (#4468)
Fixes #2782
2022-10-24 09:22:31 +00:00
Marcelo Fabri 7a3d0d55a0 Add example for #3022 (#4467)
Fixes #3022
2022-10-24 08:56:23 +00:00
Marcelo Fabri 1c6b6c67e0 Rewrite duplicated_key_in_dictionary_literal with SwiftSyntax (#4396) 2022-10-23 23:11:17 -07:00
Marcelo Fabri 87bebb6744 Rewrite test_case_accessibility with SwiftSyntax (#4446) 2022-10-23 17:39:45 -07:00
Marcelo Fabri 7f5b189c1f Rewrite override_in_extension with SwiftSyntax (#4463) 2022-10-23 17:38:40 -07:00
Marcelo Fabri c1f2b615e2 Rewrite redundant_optional_initialization with SwiftSyntax (#4409) 2022-10-23 20:30:29 -04:00
Marcelo Fabri 5d1906456b Rewrite xct_specific_matcher with SwiftSyntax (#4462) 2022-10-23 19:17:29 -04:00
Marcelo Fabri 53752f58ad Rewrite redundant_set_access_control with SwiftSyntax (#4395) 2022-10-23 15:30:01 -07:00
Marcelo Fabri c98ffcc940 Rewrite convenience_type rule with SwiftSyntax (#4452) 2022-10-23 15:28:55 -07:00
Marcelo Fabri 351c8be2e0 Rewrite return_arrow_whitespace with SwiftSyntax (#4413) 2022-10-23 15:06:14 -07:00
JP Simard cb79584c7d Migrate comment_spacing to use SwiftSyntax classifications (#4460) 2022-10-23 17:39:38 -04:00
JP Simard de7996f5c7 Rewrite discarded_notification_center_observer with SwiftSyntax (#4459) 2022-10-23 20:35:09 +00:00
JP Simard 1ee5154687 Update SwiftSyntax to fa7ff05 (#4455)
There's a new SwiftParserDiagnostics module and the rewriter visit
function signatures changed.
2022-10-23 11:56:22 -04:00
JP Simard 401d0f7929 Update SwiftSyntax to 60c7037 (#4454)
This has changes to how comments are associated to nodes.

See https://github.com/apple/swift-syntax/pull/985
2022-10-23 11:15:27 -04:00
Marcelo Fabri 25a04e8eeb Migrate inclusive_language rule to SwiftSyntax (#4390) 2022-10-23 14:00:40 +00:00
Marcelo Fabri 0bd9e4e65f Rewrite unused_optional_binding with SwiftSyntax (#4449) 2022-10-23 06:13:54 -07:00
Marcelo Fabri 60054da0f7 Rewrite prefer_self_type_over_type_of_self with SwiftSyntax (#4451) 2022-10-23 06:06:16 -07:00