In Xcode Cloud environment, SwiftLint’s cache cannot be written. When using the SwiftLintPlugin, there is no way to disable the cache. Previously, a solution was made for the SwiftLint CLI itself where it looks at a set of environment variables (#4485). This solution offers a cleaner approach where the plugin itself decides whether it needs to enable or disable the cache based on the `CI_XCODE_CLOUD` environment variable.
In the long run, SwiftLint should get rid of `isLikelyXcodeCloudEnvironment` entirely. The caller should always decide if caching is possible or not, while SwiftLint itself should be platform-agnostic.
We always pass all of the Swift source files in the target to the tool, so we need to ensure that any exclusion rules in the configuration are respected.
* Use a binary target for the build tool plugin
* Merge `push_version` and `release` make commands
Instead of running `make push_version "0.2.0: Tumble Dry"` and then
`make release`, now run `make release "0.2.0: Tumble Dry"`, which will
build the release artifacts and update/push the new version to GitHub.
This allows the artifacts to use the new version, update the artifact
bundle checksum in the package manifest, then tag the release.
The Releasing.md instructions were updated to reflect this new workflow.
* Add `SwiftLintSourcePlugin` source plugin for SwiftPM
* Add changelog entry
* Remove SwiftLintSourcePlugin for now
* Build from Source on Linux
* Use a lower-level method of checking if a file is accessible
This shouldn’t trigger sandbox violations, I hope…
* Prevent an infinite recursion of the filesystem root
* Remove unnecessary logging
* Quieten the output so that Xcode only prints violations
* Break up comment to avoid line length warning
* Fix capitalization of Glibc import
Co-authored-by: JP Simard <jp@jpsim.com>
* Only lint Swift source files within the provided target
* Restore plugin display name to “SwiftLint”
* Xcode targets don’t always conform to the SourceModuleTarget
Use a “baser” way to get at the Swift sources of the current target
* Use the cache path as the outputFiles
This prevents the warning we’re seeing in Xcode on every build, but shouldn’t interfere with the re-run logic
* Look for configuration files manually in the project directory and parents
* Check if the file is readable, not just that it exists
* Move the Path helper into a separate file
* Fix a wayward apostrophe
Signed-off-by: Tony Arnold <tony@thecocoabots.com>
* Add an entry to the CHANGELOG
Signed-off-by: Tony Arnold <tony@thecocoabots.com>
Signed-off-by: Tony Arnold <tony@thecocoabots.com>
* ✨ (spm) add build tool plugin definition for swiftlint
* 📝 (changelog) add changelog item for the plugin
* 🐛 (cache) define cache path explicitly to avoid issues during build without issues
* 🎨 minor code cleanup
* 📝 document usage with Xcode as well as Swift packages
Slava Karpenko
Tony Arnold
Roman Stetsenko
Danny Mösch
JP Simard
Johannes Ebeling