From ccdff37f1d32ba2f41fa1045048847f68a46a3c9 Mon Sep 17 00:00:00 2001 From: Marcelo Fabri Date: Wed, 4 Jan 2017 15:35:07 -0200 Subject: [PATCH] PR feedback --- CHANGELOG.md | 2 +- Source/SwiftLintFramework/Rules/CompilerProtocolInitRule.swift | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index c0d3c184b..a1099af54 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -74,7 +74,7 @@ [#1077](https://github.com/realm/SwiftLint/issues/1077) * Add `compiler_protocol_init` rule that flags usage of initializers - declared in protocols used by compiler such as `ExpressibleByArrayLiteral` + declared in protocols used by the compiler such as `ExpressibleByArrayLiteral` that shouldn't be called directly. Instead, you should use a literal anywhere a concrete type conforming to the protocol is expected by the context. [Marcelo Fabri](https://github.com/marcelofabri) diff --git a/Source/SwiftLintFramework/Rules/CompilerProtocolInitRule.swift b/Source/SwiftLintFramework/Rules/CompilerProtocolInitRule.swift index 086231f56..5506d3b16 100644 --- a/Source/SwiftLintFramework/Rules/CompilerProtocolInitRule.swift +++ b/Source/SwiftLintFramework/Rules/CompilerProtocolInitRule.swift @@ -64,7 +64,7 @@ public struct CompilerProtocolInitRule: ASTRule, ConfigurationProviderRule { } private struct ExpressibleByCompiler { - let protocolName: String + private let protocolName: String let initCallNames: Set private let arguments: [[String]]