From 59db28935665b3da1ea537cd57f8aad5d883e84f Mon Sep 17 00:00:00 2001
From: JP Simard <jp@jpsim.com>
Date: Mon, 18 Jan 2016 13:09:48 -0800
Subject: [PATCH] rewrite CheckstyleReporter.generateReport to compile 100x
 faster

before: 10s
after: 100ms
---
 .../Reporters/CheckstyleReporter.swift        | 22 +++++++++----------
 1 file changed, 10 insertions(+), 12 deletions(-)

diff --git a/Source/SwiftLintFramework/Reporters/CheckstyleReporter.swift b/Source/SwiftLintFramework/Reporters/CheckstyleReporter.swift
index ae68015a5..6258aad22 100644
--- a/Source/SwiftLintFramework/Reporters/CheckstyleReporter.swift
+++ b/Source/SwiftLintFramework/Reporters/CheckstyleReporter.swift
@@ -17,17 +17,15 @@ public struct CheckstyleReporter: Reporter {
     }
 
     public static func generateReport(violations: [StyleViolation]) -> String {
-        var report = "<?xml version=\"1.0\" encoding=\"utf-8\"?>\n<checkstyle version=\"4.3\">"
-        report += violations.map { violation in
-            let fileName = violation.location.file ?? "<nopath>"
-            return "\n\t<file name=\"\(fileName)\">\n" +
-                "\t\t<error line=\"\(violation.location.line ?? 0)\" " +
-                "column=\"\(violation.location.character ?? 0)\" " +
-                "severity=\"\(violation.severity.rawValue.lowercaseString)\" " +
-                "message=\"\(violation.reason)\"/>\n" +
-                "\t</file>"
-        }.joinWithSeparator("")
-        report += "\n</checkstyle>"
-        return report
+        return "<?xml version=\"1.0\" encoding=\"utf-8\"?>\n<checkstyle version=\"4.3\">" +
+            violations.map({ violation in
+                let fileName = violation.location.file ?? "<nopath>"
+                return ["\n\t<file name=\"\(fileName)\">\n",
+                    "\t\t<error line=\"\(violation.location.line ?? 0)\" ",
+                    "column=\"\(violation.location.character ?? 0)\" ",
+                    "severity=\"\(violation.severity.rawValue.lowercaseString)\" ",
+                    "message=\"\(violation.reason)\"/>\n",
+                    "\t</file>"].joinWithSeparator("")
+            }).joinWithSeparator("") + "\n</checkstyle>"
     }
 }