From d867a678990def755d757debb3ea28153de08354 Mon Sep 17 00:00:00 2001 From: jonkykong Date: Tue, 26 Sep 2017 23:42:32 -0700 Subject: [PATCH 1/2] Corrected logic for default menu width. --- Pod/Classes/SideMenuManager.swift | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Pod/Classes/SideMenuManager.swift b/Pod/Classes/SideMenuManager.swift index 305ac5b..5ecddd8 100644 --- a/Pod/Classes/SideMenuManager.swift +++ b/Pod/Classes/SideMenuManager.swift @@ -68,11 +68,11 @@ open class SideMenuManager : NSObject { open static var menuAllowPushOfSameClassTwice = true /** - Width of the menu when presented on screen, showing the existing view controller in the remaining space. Default is 75% of the screen width. + Width of the menu when presented on screen, showing the existing view controller in the remaining space. Default is 75% of the screen width or 240 points, whichever is smaller. Note that each menu's width can be overridden using the `menuWidth` property on any `UISideMenuNavigationController` instance. */ - open static var menuWidth: CGFloat = max(round(min((appScreenRect.width), (appScreenRect.height)) * 0.75), 240) + open static var menuWidth: CGFloat = min(round(min((appScreenRect.width), (appScreenRect.height)) * 0.75), 240) /// Duration of the animation when the menu is presented without gestures. Default is 0.35 seconds. open static var menuAnimationPresentDuration: Double = 0.35 From bf241ec55453fcb6ec000aeaba80a7909739a20c Mon Sep 17 00:00:00 2001 From: jonkykong Date: Tue, 26 Sep 2017 23:46:56 -0700 Subject: [PATCH 2/2] Updated podspec and README for cocoapods. --- README.md | 20 ++++++++++---------- SideMenu.podspec | 2 +- 2 files changed, 11 insertions(+), 11 deletions(-) diff --git a/README.md b/README.md index 4bbcffd..702161c 100644 --- a/README.md +++ b/README.md @@ -4,7 +4,7 @@ [![License](https://img.shields.io/cocoapods/l/SideMenu.svg?style=flat)](http://cocoapods.org/pods/SideMenu) [![Platform](https://img.shields.io/cocoapods/p/SideMenu.svg?style=flat)](http://cocoapods.org/pods/SideMenu) -### If you like SideMenu, give it a ★ at the top right of this page. +### If you like SideMenu, give it a ★ at the top right of its [GitHub](https://github.com/jonkykong/SideMenu) page. #### Using SideMenu in your app? [Send](mailto:yo@massappeal.co?subject=SideMenu%20in%20action!) me a link to your app in the app store! > Hi, I'm Jon Kent and I am an iOS designer, developer, and mobile strategist. I love coffee and play the drums. @@ -15,14 +15,14 @@ ## Overview SideMenu is a simple and versatile side menu control written in Swift. - * **It can be implemented in storyboard without a single line of [code](#code-less-storyboard-implementation).** - * Four standard animation styles to choose from (there's even a parallax effect if you want to get weird). - * Highly customizable without needing to write tons of custom code. - * Supports continuous swiping between side menus on boths sides in a single gesture. - * Global menu configuration. Set-up once and be done for all screens. - * Menus can be presented and dismissed the same as any other view controller since this control uses [custom transitions](https://developer.apple.com/library/content/featuredarticles/ViewControllerPGforiPhoneOS/CustomizingtheTransitionAnimations.html). - * Animations use your view controllers, not snapshots. - * Properly handles screen rotation and in-call status bar height changes. +- [x] **It can be implemented in storyboard without a single line of [code](#code-less-storyboard-implementation).** +- [x] Four standard animation styles to choose from (there's even a parallax effect if you want to get weird). +- [x] Highly customizable without needing to write tons of custom code. +- [x] Supports continuous swiping between side menus on boths sides in a single gesture. +- [x] Global menu configuration. Set-up once and be done for all screens. +- [x] Menus can be presented and dismissed the same as any other view controller since this control uses [custom transitions](https://developer.apple.com/library/content/featuredarticles/ViewControllerPGforiPhoneOS/CustomizingtheTransitionAnimations.html). +- [x] Animations use your view controllers, not snapshots. +- [x] Properly handles screen rotation and in-call status bar height changes. Check out the example project to see it in action! ### Preview Samples @@ -31,7 +31,7 @@ Check out the example project to see it in action! | ![](etc/SlideOut.gif) | ![](etc/SlideIn.gif) | ![](etc/Dissolve.gif) | ![](etc/InOut.gif) | ## Requirements - * iOS 8 or higher +- [x] iOS 8 or higher. ## Installation ### CocoaPods diff --git a/SideMenu.podspec b/SideMenu.podspec index 0a43bd0..1347f8a 100644 --- a/SideMenu.podspec +++ b/SideMenu.podspec @@ -8,7 +8,7 @@ Pod::Spec.new do |s| s.name = "SideMenu" - s.version = "3.0.1" + s.version = "3.0.2" s.summary = "Simple side menu control for iOS in Swift inspired by Facebook. Right and Left sides. No coding required." # This description is used to generate tags and improve search results.