12 Commits

Author SHA1 Message Date
Zhengxing Chen 01cc5e72f8 Fix documents
Summary: Follow the instructions in T66611582. Now the only remaining problem is that headers must include copyright.

Reviewed By: alexnikulkov

Differential Revision: D32583915

fbshipit-source-id: 13d390d756825c5e91e7801bf0dc4efec9b8b1f7
2021-11-23 23:45:00 -08:00
Zhengxing Chen ce3d74f7fc Update ReAgent docs (#577)
Summary:
Pull Request resolved: https://github.com/facebookresearch/ReAgent/pull/577

Update module lists following https://fb.quip.com/lEbxAN6UzLrS#UUGACAIIXSi

Reviewed By: alexnikulkov

Differential Revision: D32345725

fbshipit-source-id: fef624a759026ea7727159e22433129466bab399
2021-11-11 10:01:55 -08:00
Zhengxing Chen f08856a110 Back out recent refactor
Summary:
Need more tests before landing the refactor diffs: D22702504 (https://github.com/facebookresearch/ReAgent/commit/1b470c489d19c33beab88b8ea2e79843d4d31f28), D23123762 (https://github.com/facebookresearch/ReAgent/commit/76829287265bc39f879f3bc1d946a1374c5e1141), D23124179 (https://github.com/facebookresearch/ReAgent/commit/b28f84aa013be00194508f52498160592cb37e9d), D23219012 (https://github.com/facebookresearch/ReAgent/commit/e404c5772ea4118105c2eb136ca96ad5ca8e01db)

Back out to a version based on D23155753.

Check our team diff history: https://fburl.com/diffs/ppsgazgj

Reviewed By: kittipatv

Differential Revision: D23270626

fbshipit-source-id: 14653066bb3924a987a54650a51241895b321c8e
2020-08-21 15:58:02 -07:00
Jason Gauci 57a6da13f3 Refactor & Remove Page Handler (#299)
Summary:
Pull Request resolved: https://github.com/facebookresearch/ReAgent/pull/299

This diff accomplishes several items:
1. Remove PageHandler and consolidate all training functions into one function, using polymorphism to handle model-specific logic
2. Make BatchRunner the sole place where FB vs. OSS context is decided (by choosing FbBatchRunner or OssBatchRunner)
3. Transform ModelManager into a stateless provider.
4. With the exception of model manager, remove all duplicate classes by creating oss & internal versions and using polymorphism, or moving out of workflow/* entirely
5. Replace signals-and-slots API with interfaces
6. Create a DataFetcher class, unifying the APIs to query data on OSS and FB.

Reviewed By: kaiwenw

Differential Revision: D22702504

fbshipit-source-id: 3eb8e93144ca12ac650a4fafc875e29d8ade89e3
2020-08-17 15:13:03 -07:00
Kittipat Virochsiri bb88559350 Simplifying model API
Summary:
- Delete SingleQValue and AllActionQValues; returns tensor directly
- CategoricalDQN is now taking a ModelBase which returns 3-D tensor (batch_size, num_actions, num_atoms)
- FullyConnectedDQN's constructor has one more argument, num_atoms, which default to None. When it's not None, returns 3-D tensor like above
- DuelingQNetwork takes 3 sub networks: shared_network, value_network, advantage_network. The parametric version is split out to ParametricDuelingQNetwork for better readability.
- Introduces a subclass of Sequential conforming to ModelBase API. `input_prototype()` returns the value from the first module.

Reviewed By: czxttkl

Differential Revision: D21336534

fbshipit-source-id: 629c688b0de4754effb30cd61f4a6da3cca021ab
2020-05-07 15:09:36 -07:00
Kittipat Virochsiri 7ab6e59c17 Finally kill thrift config
Summary: We no longer use Thrift for configuration

Reviewed By: czxttkl

Differential Revision: D18242481

fbshipit-source-id: bfdfa1e7baa21be92bb51a7103d0f379dafee2b2
2019-10-31 12:28:11 -07:00
Zhengxing Chen 8ece668954 Update docs
Summary: Pull Request resolved: https://github.com/facebookresearch/ReAgent/pull/178

Reviewed By: kittipatv

Differential Revision: D18165626

Pulled By: czxttkl

fbshipit-source-id: 034ed0a37924df1113c5a1332a771bd4e0aeb5bb
2019-10-28 23:15:36 -07:00
Zhengxing Chen 338c374a35 Horizon -> ReAgent in subpages
Summary: Pull Request resolved: https://github.com/facebookresearch/ReAgent/pull/173

Reviewed By: kittipatv

Differential Revision: D17950105

Pulled By: czxttkl

fbshipit-source-id: 10005fd416697e926e231e7d13cd3db29d28c602
2019-10-16 01:01:05 -07:00
Zhengxing Chen 24961c1e5f update sphinx docs file (#163)
Summary:
Will update gh-pages branch in another diff.
Pull Request resolved: https://github.com/facebookresearch/ReAgent/pull/163

Reviewed By: MisterTea, kittipatv

Differential Revision: D17924969

Pulled By: czxttkl

fbshipit-source-id: b63dafa0b514b908ecb8ad605416ecbc90ef03b3
2019-10-14 23:23:09 -07:00
Zhengxing Chen 539d22cd83 update sphinx (#146)
Summary:
Update several things so that sphinx compiled successfully:
conf.py (add onnx in autodoc_mock_imports and add Horizon root to sys.path)
ml/rl/caffe_utils.py (update __getattr__ such that sphnix wouldn't throw exception)
ml/rl/tensorboardX.py (update __getattr__ such that sphnix wouldn't throw exception)
Pull Request resolved: https://github.com/facebookresearch/Horizon/pull/146

Test Plan: Wait for all integration tests and unit tests pass

Reviewed By: kittipatv

Differential Revision: D16243745

Pulled By: czxttkl

fbshipit-source-id: e3b8af37ec520bde44a4a59379341bceaa981070
2019-07-18 16:03:39 -07:00
Jason Gauci 2a548989f9 GymPredictor -> OnPolicyPredictor. Cleanup
Reviewed By: kittipatv

Differential Revision: D15895899

fbshipit-source-id: 8d4c84ce01b626af07b24f2a3d62f178cf393b83
2019-06-22 18:05:59 -07:00
Jason Gauci 9423705a6c Add sphinx documentation. Convert markdown files to rst.
Summary: Pull Request resolved: https://github.com/facebookresearch/Horizon/pull/119

Reviewed By: kittipatv

Differential Revision: D14992371

Pulled By: MisterTea

fbshipit-source-id: 9ebe007009be3a1e22556724254da710dd7a5d3e
2019-04-19 10:42:57 -07:00