Commit Graph
281 Commits
Author SHA1 Message Date
Fran Aguilera b312e65ead Update WorkerBinder.kt
Prototyping factory changes
2023-04-14 12:01:36 -07:00
Patrick Steiger a8677bb238 Fix source compatibility with RouterNavigatorEvents.getEvents (#549)
93dd6e8d changed `getEvents()` to `events` property. This is fine for Java consumers, as `events` getter resolves to `getEvents()` in JVM, but Kotlin consumers using `getEvents()` will fail compilation, as this method no longer exists.

This commit introduces a deprecated, JVM synthetic `getEvents` methods to keep Kotlin source compatibility.
2023-04-12 11:17:35 -07:00
tys 80189ef17f Fixing lastOrNull or interactor isActive 2023-03-28 17:33:49 -07:00
tys 6e857f6b61 Fixing spotless check 2023-03-27 15:21:47 -07:00
tys be9bd950ef Adding RibDispatcher usage 2023-03-27 13:36:23 -07:00
tys 56c9d29652 cleaning up leftover test 2023-03-27 11:40:38 -07:00
tys 93dd6e8d8b cleaning up some explicit signatures and fixing nullability lifecycle peeking 2023-03-27 11:06:30 -07:00
tys 73ae40ab32 Addressing Feedback to clean up allocations 2023-03-24 19:14:53 -07:00
tys 036fa95765 removing junk testing 2023-03-24 17:13:22 -07:00
tys f27391b39d Fix spotless checks 2023-03-24 17:06:13 -07:00
tys 1015f2f460 Moved all behavior relays and publish relays to Flow in non test code. Preserving all public APIs for now 2023-03-24 17:03:28 -07:00
tys ccf2409d91 Prepare next development version 2023-03-23 13:34:42 -07:00
tys dd2301b702 Prepare for release 0.13.3 2023-03-23 13:33:49 -07:00
Patrick Steiger a2a30f7164 Make all TestDispatchers in TestRibDispatchers use the same TestCoroutineScheduler.
This introduces consistent behavior when advancing the virtual time in a `runTest` block in a test class that uses `RibCoroutinesRule`: all dispatchers from `RibDispatchers` will advance in time, as opposed to the current implementation where only the main dispatcher will advance in time.

Fixes #540.
2023-03-07 23:00:07 -03:00
Patrick Steiger 2566892d66 Clear LazyCoroutineScope cache upon CoroutineScope Job completion.
The `CoroutineScope` instance will be cached only until it is completed.

This new behavior of clearing the cache upon completion effectively allows for re-launching coroutines on the attach callback when an attach-detach-attach cycle occurs on `ScopeProvider` components with a lifecycle.

Re-launching coroutines upon reattachment is not possible in current implementation (without this fix): a single `CoroutineScope` is cached for the whole life of the instance, and `ScopeProvider.coroutineScope` delivers a stale, cancelled instance  of `CoroutineScope` after reattaching the component (even though `ScopeProvider.requestScope()` delivers a new `Completable`.

To be clear, the correct reattachment behavior is already in place for Rx subscriptions that `autoDispose` by `ScopeProvider`: they are backed by the `Completable`, which work fine on attach-detach-reattach cycles. This commit makes coroutines behavior consistent with the currently established behavior in RIBs.

Fixes #535.
2023-01-18 11:02:34 -03:00
idanakav 4b2f334acb IntelliJ plugin v0.1.5 2022-12-27 19:41:24 -08:00
idanakav d137e810f0 Compile intellij plugin against 2022.2.4
IntelliJ 2022.2.4 is the latest one compiled with java 11, 22.3+ are compiled with java 17 and should be addressed in future commits.
2022-12-27 19:37:47 -08:00
idanakav bce5ee9125 Update IntelliJ since build property 213 2022-12-27 14:17:41 -08:00
idanakav a8d51603c9 Remove experimental label 2022-12-27 14:17:41 -08:00
idanakav 3cf9360475 Migrate rib project component to service
Migrate the component to a service along with adding a `AttachRibProjectServiceActivity` as a post startup activity.
2022-12-27 14:17:41 -08:00
idanakav cdc2b2ebb1 Migrate android device repo to light service
ProjectComponents are deprecated, migrating to services.
2022-12-27 14:17:41 -08:00
idanakav 28f17b97e3 Allow new RIB generation without tests
This action is intended for bootstrapping, having tests should not be a prerequisite
2022-12-27 14:17:36 -08:00
idanakav 7e70924463 IntelliJ plugin dependencies cleanup
The removed dependencies should not be bundled into the plugin to avoid duplicated classes, we also add a dependency on the android plugin itself.
2022-12-27 10:57:39 -08:00
idanakav c4c818c561 Compile IntelliJ plugin targeting jdk 11 2022-12-27 10:57:29 -08:00
tys 2ae19b5c13 Prepare next development version 2022-10-28 15:17:10 -07:00
tys c03347f24e Prepare for release 0.13.2 2022-10-28 15:10:53 -07:00
tys 4c895ddb7c Fix spotless 2022-10-28 14:55:24 -07:00
tys 8e878c6e6e Removing previous change to the presenter field in favor of making it a closed JvmField to maintain compatibility 2022-10-26 17:10:21 -07:00
tys 771dae85d4 Prepare next development version 2022-10-20 15:34:29 -07:00
tys 92c4db2f81 Prepare for release 0.13.1 2022-10-20 15:11:57 -07:00
tys 0f69c2fa75 Ripping out Rave 2022-10-19 18:01:21 -07:00
tys 6d51b99077 SPotless fixes 2022-10-19 16:14:55 -07:00
tys 1a05c562a9 Cleanup APIs to remove TestCoroutineDispatcher which was deprecated 2022-10-19 14:56:40 -07:00
tys a4269f75cf Merge branch 'main' of ssh://github.com/uber/RIBs into ty/kotlin-1.7-upgrade 2022-10-04 16:08:22 -07:00
Kiran Kumar b926b0ba9e Spotless check fix 2022-09-26 17:15:32 +05:30
Kiran Kumar e59184cad9 - Adding support for relaying window focus events from RibActivity (test included) 2022-09-26 16:50:43 +05:30
tys 6d3de3cfca Fixed all deps and package changes for compilation 2022-08-26 15:35:56 -07:00
tys 19a21b1573 WIP commit for dependecy upgrades to Kotlin 1.7 2022-08-26 11:44:47 -07:00
SergeySmykovskyi 1023a96b84 Migrate com.nhaarman.mockitokotlin2 to org.mockito.kotlin (#520)
* Migrate com.nhaarman.mockitokotlin2 to org.mockito.kotlin
2022-08-08 18:21:41 -07:00
Mathieu Brousse 7be85d071f Add "open" modifier to allow override in implementation 2022-07-19 14:45:17 +02:00
idanakav 0b0948a68f Update RIB IntelliJ plugin (#508)
* Update RIB hierarchy IntelliJ plugin

- Update IntelliJ gradle plugin to v1.5.3
- Fix compilation issues with IJ 2022
- Add missing modules to plugin.xml to make the plugin compatible with recent IJ versions

* IntelliJ RIB plugin version 0.1.4

- Cleanup plugin.xml
- Add description
- Remove "Plugin" from the name as suggested by the verifyPlugin task
2022-05-18 16:40:59 -07:00
Ty Smith ea969125fb Merge pull request #503 from uber/gradle-upgrade
Gradle 7.2 upgrade
2022-04-24 21:37:30 -07:00
tys ed0fa7315a Prepare next development version 2022-04-24 15:19:49 -07:00
tys 4220cbf013 Prepare for release 0.13.0 2022-04-24 15:19:38 -07:00
tys 5a8d44afe0 Gradle 7.2 upgrade 2022-04-24 13:20:50 -07:00
tys 7a7a668a28 Resetting versions to test release script with fixes 2022-04-24 12:16:58 -07:00
tys db2f5c64af Adding fix application level coroutine scope 2022-04-23 16:19:25 -07:00
tys e67967c06d Adjusting some deps to API to account for expected consumer usage 2022-04-22 22:31:15 -07:00
tys 3acb03d75a Adding more safety to SCope testing api and doing a bit of doc cleanup from feedback 2022-04-22 18:03:05 -07:00
tys 9078940c04 Addressing feedback on demo app 2022-04-22 15:10:09 -07:00