GitHub/RIBs
1
0
Fork 0
mirror of https://github.com/uber/RIBs.git synced 2026-06-16 12:54:31 +00:00
Code Issues Packages Projects Releases Wiki Activity
428 Commits 22 Branches 33 Tags
ty/fix-basic-interactor
Commit Graph
93 Commits
Author SHA1 Message Date
Ty Smith e1dcb22ddc Merge pull request #451 from DevYeom/devyeom/typos-in-workflow 
Rename a function in workflow
 2022-04-24 12:53:25 -07:00
Ty Smith 7a143cee9e Merge pull request #472 from tp/patch-1 
Fix typo in SimpleComponentizedBuilder error message
 2022-04-24 12:50:59 -07:00
Jaewook 9571f986b8 Fix typo in Interactor comments (callend -> called) (#492) 2022-01-23 17:08:37 +01:00
Timm Preetz 0d99c6227f Fix typo in SimpleComponentizedBuilder error message 2021-07-13 10:24:34 +02:00
DevYeom 0052cc6376 Rename a function in workflow 
- Fix typos (worflow -> workflow)
 2021-05-23 15:51:43 +09:00
Duc Nguyen ad47414f11 Fix typo on ComponentizedBuilder & MultiStageComponentizedBuilder (oevrriden->overridden) (#447) 2021-05-14 14:43:05 +02:00
ga eun 1592ebf5d7 Change all class-only protocol keywords to AnyObject (#442) 2021-05-14 14:36:09 +02:00
Jiwoo 6adb832c65 Replace deprecated type 'Variable' to 'BehaviorRelay' in iOS Tutorials (#379) 2021-03-25 17:13:46 +01:00
KYHyeon 6c9c04106a Renames tutorial comments spelling (#386) 
Modifying 'Diagnals' in tutorial comments to 'Diagonal'
 2021-03-25 17:13:32 +01:00
Pavlo Davydiuk 6d66dd1a7c Bump RxSwift and deployment target (#387) 2021-03-25 17:13:16 +01:00
Sungwoon Park ffc489f00d ⬆️ RxCocoa version up (#368) 2020-05-08 23:55:59 +02:00
Anton Pomozov bfa19bfad8 Add SPM support (#359) 
* Add SPM support

* Fix compilation errors

* Exclude non project files

Instead of modifying them.

* Use an appropriate version of Xcode

* Fix CI config

* Fix templates

* Restore excluded files

* Try to fix IOS_SDK with script

* Use values available on CI

* Restore templates

* Remove comment
 2020-05-04 11:49:59 +02:00
Daisuke Iwata aafdd2d773 Compatible RxSwift 5 (#322) 2019-10-04 15:27:11 +02:00
Yi Wang ee339b57ae Add new builder classes compatible with Needle (#327) 
Since Uber internally has fully migrated to [Needle](https://github.com/uber/needle/), these base builder classes were introduced to make RIBs more compatible.
 2019-05-21 10:52:57 -07:00
Justin Kaufman 0c093f52e9 Upgrade iOS RIBs Project to Swift 5 (#321) 
* Upgrade iOS project and related dependencies to Swift 5

* bump travis image to xcode10.2

* bump iphonesimulator to 12.2

* print out carthage version during test setup

* fix ios version in xcbuild test -destination

* Remove problematic Swift 5 branching logic in `Component`, fixes test
 2019-05-03 13:18:54 -07:00
Do Dinh Duc e7ad74a839 Compile with xcode 10.2 (#316) 
Add compatible with swift 4.2
 2019-04-23 15:19:17 +02:00
Ibrahim Koteish d5f6dbe95f Silent xcode swift 4.2 migration warning (#286) 2018-10-23 18:44:43 +02:00
Zmicier Zaleznicenka 28d23d21b4 Fix Xcode 10-specific regression in Component.shared (#274) (#275) 2018-09-14 14:25:38 +02:00
Alan Zhao d9ebbabc8a Remove duplicate annotations in tutorial4-completed (#255) 2018-05-12 11:27:22 +02:00
Eric Drew 68ffa9759a Update to Xcode 9.3 recommended settings (#231) 2018-04-25 07:50:49 -07:00
Eric Drew e124d6c089 Remove weak property keyword from protocols (#229) 2018-04-15 20:25:19 +02:00
Yi Wang de33e016c4 Fix forked Workflow invoking didComplete multiple times 
Because didComplete is added at the end of the Workflow Rx side-effect, if a Workflow is forked, multiple Rx chains with the side-effect are created and subscribed to. This means the didComplete is invoked duplicately.

Fixes #211
 2018-02-07 15:21:06 -08:00
Tuomas Artman 58fecc5982 Update README.md 2018-01-30 21:37:20 -08:00
Tuomas Artman 41d9bfa248 Update README.md 2018-01-30 21:36:15 -08:00
Serhii Butenko cde22404e6 Fix typo 2018-01-22 11:07:45 -08:00
Eric Drew 6becf1866e Remove uiviewController property from template (#200) 2018-01-09 13:18:30 +01:00
Eric Drew c612d42c5b Remove unused code in tutorial 4 (#199) 2018-01-09 13:18:16 +01:00
Yi Wang 3bdf5224b3 Fix viewless RIB template 
The `Router` initializer does not `override` a parent initializer;.

Fixes #192
 2017-12-26 10:28:28 -08:00
Yi Wang f50461a12a Merge pull request #180 from uber/tutorials-view_less_rib_inheritance-master 
Fix tutorials view-less RIB inheritance
 2017-12-05 13:27:46 -08:00
Yi Wang 601e12fa29 Fix tutorials view-less RIB inheritance 
View-less RIBs should not inherit from `ViewableRouter`. It'll cause false positive leak detection.
 2017-12-05 10:58:45 -08:00
Yi Wang 45c579f001 Fix view-less RIB template 
View-less RIBs should not inherit from `ViewableRouter` or `PresentableInteractor`.
 2017-12-05 10:46:30 -08:00
Naoki Ishikawa f4be7f53e8 added template’s option to add storyboard (#175) 2017-12-05 06:30:30 +01:00
Eric Drew dba0ee7a0a Fix xcode template installation script file copying (#178) 2017-12-04 12:18:53 -05:00
Dmitry Klimkin 275d584b95 Added RIB's template option to create a corresponding XIB file (#171) 2017-11-30 00:19:10 +01:00
Cameron Mc Gorian 7f1902ae2f Fix build for Tutorial 4 completed (#169) 2017-11-28 09:46:53 +01:00
Naoki Ishikawa 8466b8952f Fix Tutorial build (#168) 
* Update tutorials to use correct method name `launch(from: )`
 2017-11-28 08:01:56 +01:00
Cameron Mc Gorian 1abd1991af Test (#164) 
- Tests for `Foundation+Extensions` & `LaunchRouter`
- Cleanup Presenter & swiftify naming in `LaunchRouting`
 2017-11-27 20:17:03 +01:00
Cameron Mc Gorian 7ce500ab97 Fix Carthage usage (#138) 
* deintegrate pods
* Delete Podfile
* Add Cartfile
* Update gitignore & untrack files
* Update FRAMEWORK_SEARCH_PATH
* Update .travis.yml
* Link RxSwift
 2017-11-21 08:57:15 +01:00
Cameron Mc Gorian ff5d51b68b Fix Unit Test template (#153) 2017-11-17 16:10:22 +01:00
Pavel Mazurin 5a1fc0f587 Tutorial 4 completed code (#129) 2017-11-14 20:56:03 +01:00
Cameron Mc Gorian fd3ba11d84 Add tests (#135) 
* Add tests

- RouterTests
- ComponentTests
- WorkflowTests
- WorkerTests

* Fix format.
 2017-11-14 10:51:52 +01:00
Cameron Mc Gorian e33d87274f Add component extension template (#134) 2017-11-14 09:04:05 +01:00
Pavel Mazurin 54eb1bac64 Update tutorial4 starting code 2017-11-11 11:30:34 +01:00
Alex Perez b402bfc095 Add file header to iOS template files (#121) 2017-11-09 08:00:38 +01:00
Oron Ben Zvi e16b886bb6 Replace SampleInteractable with correct template on routers without views (#119) 2017-11-08 23:48:06 +01:00
Lucas Nelaupe e15a2695f7 Fix typo (#117) 2017-11-08 09:15:45 +01:00
Tuomas Artman 6b7f85ee82 Updates tutorial README's to include tooling installation (#114) 2017-11-07 14:09:13 +01:00
Gergely Orosz bd7bc3b865 Fixing merge conflict 2017-11-06 20:41:36 +01:00
Gergely Orosz 6255c0f568 Change the RIB generation template to generate a view by default 
This is because of two reasons:
1. Most RIBs that I have seen have views
2. To have the code generation defaults be inline with the Android
generator (and the main use case)
 2017-11-05 19:18:28 +01:00
Gergely Orosz b2814e3a3a Moving tooling documentation to the Wiki 
Following the approach with tutorials, moving the documentation over to
the Wiki as well. The wiki pages are already in place.

In this commit, also removing assets from the android folder.
 2017-11-05 19:05:49 +01:00