57 Commits

Author SHA1 Message Date
Patrick Steiger 27d8eba3fc Make use of convention plugins and version catalogs 2023-05-18 14:54:39 -03:00
Patrick Steiger 5b9b66e54d Make use of jvmToolchain for compiling the project.
This allows for a more repeatable, predictable build between different local configurations.
2023-05-16 18:01:40 -03:00
Patrick Steiger 2d77205544 Bump Kotlin, Gradle, and other dependencies versions.
Kotlin 1.7.10 -> 1.8.20
Gradle 7.3.3 -> 8.1.1
AndroidX Lifecycle ViewModel Compose 1.0.0-alpha05 -> 2.5.1
AndroidX Activity 1.3.0-alpha08 -> 1.7.0
AndroidX Activity KTX 1.3.0-beta02 -> 1.7.0
AndroidX Activity Compose 1.3.0-beta02 -> 1.7.0
Compose compiler 1.3.0 -> 1.4.6
Compose libraries 1.2.1 -> 1.4.0
Java version 1.8 -> 11
IntelliJ plugin 1.11.0 -> 1.13.1 (1.13.2 onwards fails test `ribGenerators_shouldGenerateClassesThatCompiler` for reasons beyond my understanding)
AGP 7.2.2 -> 7.4.2 (8.0 not supported in IJ 2023.1 bundled Android plugin)
gradle-maven-publish 0.18.0 -> 0.25.2

### Additional changes

- Move package string from manifests to `android.namespace` in Gradle build scripts.
- Remove `targetSdk` from Android libraries (only applications should provide it)
- Remove `buildToolsVersion`.
- `compileSdkVersion`, `minSdkVersion`, `targetSdkVersion` swapped to `compileSdk`, `minSdk`, `targetSdk`.
- Disablement of `buildConfig` is now done by `buildFeatures.buildConfig = false` instead of in the project `build.gradle`.
- Added `exported="true"` in demo Android projects activities.
- `-Xfriend-paths` `kotlinc` option seemingly only works now if we use `@file:Suppress("invisible_reference", "invisible_member")` in files that access internal components.
- `androidx.lifecycle.ViewTreeLifecycleOwner(View, LifecycleOwner)` has been replaced with `View.setViewTreeLifecycleOwner(LifecycleOwner)`.
- Removed unnecessary dependencies on Kotlin stdlib, as the Kotlin JVM plugin automatically adds it. For reasons beyond my understanding, removing it from `android/libraries/rib-test` fails gradle sync with the following error, so it's the only place it's still kept.
```
com.intellij.openapi.externalSystem.model.ExternalSystemException: Could not resolve all dependencies for configuration ':libraries:rib-coroutines:testCompileClasspath'.
Cannot change dependencies of dependency configuration ':libraries:rib-test:api' after it has been included in dependency resolution.
```
2023-04-28 20:32:40 -03:00
sergey.smykovskyi 9aaf225144 Renamed loggedIn package -> loggedin
Renamed `loggedOut` package -> `loggedout`
 Renamed `offGame` package -> `offgame`
 Renamed `ticTacToe` package -> `tictactoe`
2023-04-26 11:10:58 -07:00
sergey.smykovskyi e696898c9f Update formatters versions:
`gjf` 1.7 -> 1.16.0
`ktfmt` 0.23 -> 0.43
`ktlint` 0.41.0 -> 0.48.2
`spotless` 5.11.0 -> 6.18.0

Manual changes :
 Renamed `logged_in` package -> `loggedIn`
 Renamed `logged_out` package -> `loggedOut`
 Renamed `off_game` package -> `offGame`
 Renamed `tic_tac_toe` package -> `ticTacToe`
2023-04-26 11:10:08 -07:00
tys 0f69c2fa75 Ripping out Rave 2022-10-19 18:01:21 -07:00
SergeySmykovskyi 1023a96b84 Migrate com.nhaarman.mockitokotlin2 to org.mockito.kotlin (#520)
* Migrate com.nhaarman.mockitokotlin2 to org.mockito.kotlin
2022-08-08 18:21:41 -07:00
tys 5a8d44afe0 Gradle 7.2 upgrade 2022-04-24 13:20:50 -07:00
James Barr 71b9f1b7bd Swap tutorial3 and tutorial3-completed (#468) 2021-07-09 15:11:32 -07:00
James Barr cb51d73da2 Integrate Spotless into build (#415)
* Integrate Spotless in build

* Update CONTRIBUTING.md

* Move improperly placed copyright comments

* Update copyright indent

* Don't format test fixtures

* Run spotlessApply over the whole repo

* Remove checkstyle configs

* Run spotlessCheck on CI
2021-03-24 18:45:35 -07:00
James Barr b86d7ffee3 Align rib-android with internal version (#405)
* Bump buildTools and compileSdk to 30

* Remove component type parameter from ViewRouter

* Xray updates

* Add support for onUserLeaveHint, onTrimMemory, and onPIPModeChanged callbacks

* Update build tools for Travis CI
2021-02-27 10:01:12 -08:00
James Barr b290824844 Align rib-base with internal version (#402)
* Remove Component type parameter from Router

* Add RibEvents and related classes for tooling

* Minor differences to align with internal version of rib-base

* Extended WorkerBinder functionality to allow for binding a worker to a presenter's lifecycle

* Minor differences & new tests to align with internal version of rib-base
2021-02-23 12:47:26 -08:00
James Barr 0fa0b46839 Align rib-test with internal version (#400)
* Align rib-test with internal version

* Rename rib-test-utils to rib-test

* Bump Mockito version
2021-02-19 11:53:21 -08:00
James Barr 676f742436 Migrate from uava to guava (#393)
* Delete rib-uava
* Use Guava classes instead of Uava
* Add Guava dependencies and be explicit about Android or JRE
2021-02-12 13:46:29 -08:00
fegol b586fbf024 Migration to AndroidX #324 (#334)
* Migration to AndroidX #324

* Divided versions for androidx libraries and renamed dependencies #324

* Upgrade target sdk version for travis #324

* Migration to androidx part 2 #324

* Fixed spaces #324
2019-06-19 22:48:18 +02:00
Shaishav Gandhi 9ac24da401 Update AutoDispose to 1.3.0 (#333)
* Update AutoDispose

* Enable desugaring in tutorials

* Move to static imports
2019-06-12 13:28:12 -07:00
SeungHun Choe 94d8293316 Fix gradle sync and compilation error on Android Studio 3.4 2019-05-24 10:08:25 +09:00
Manu Sridharan 08d42cce56 no NullAway config for tests 2018-02-07 18:11:52 -08:00
Manu Sridharan b117ad32c2 turn off CheckReturnValue 2018-02-07 18:11:52 -08:00
Manu Sridharan 8e2ce27ecd wire up EP / NullAway for tutorial1 and tutorial2 2018-02-07 18:11:52 -08:00
Tuomas Artman 2059061ad9 Renames Android tutorial folders to "tutorial<x>" so that it matches wiki documentation (#109) 2017-11-07 10:12:49 +01:00
Brian Attwell 72213646c5 clean up 'Instantiable' warnings 2017-11-03 17:19:32 -07:00
Brian Attwell 12ebe9af1f suppress lint on tutorials. suppress checkstyle for now 2017-11-03 17:19:32 -07:00
Brian Attwell dbbfa3f5b9 Update android readmes to be more useful 2017-11-03 13:46:16 -07:00
Brian Attwell bcaf025974 Fix tutorial 2 compilation failure 2017-11-03 11:45:46 -07:00
Brian Attwell 383e4932c3 Fix tic tac toe logic for tutorial 2 starter code 2017-11-03 11:45:46 -07:00
Brian Attwell e079234cdf Fix tic tac toe logic for tutorial 3 starter code 2017-11-03 11:45:46 -07:00
Brian Attwell 7adcc7d396 Fixes to tutorial 3 starter code
* previously there was only one name field in logged out RIB
* previously the OffGameRIB only had one name field
2017-11-03 11:45:46 -07:00
Brian Attwell dc37b0f663 Include percent layout & missing layouts 2017-11-02 14:52:13 -07:00
Brian Attwell 0c9729c0e6 add tic tac toe 2017-11-02 14:36:26 -07:00
Brian Attwell 5c1e8f3c18 fix tutorial 2 starter code. was missing a few things 2017-11-02 14:26:46 -07:00
Brian Attwell c0733384e2 Fix some bugs in tutorial4 setup 2017-11-01 16:34:39 -07:00
Brian Attwell 22bbf1f83b Fix android master
* disable nullaway for the memory leak demo. it isn't needed for it
* remove some broken tests
2017-11-01 14:21:31 -07:00
Yuan Lu bbfa0f1787 Readme for Android tutorial 3 (#69) 2017-11-01 21:27:17 +01:00
Yuan Lu 29c9205de3 Readme for Android tutorial 2 (#67)
* Readme for Android tutorial 2

* Point to wiki page
2017-11-01 21:26:43 +01:00
Brian Attwell 2dbd1f2674 random winner no longer crashes 2017-11-01 13:24:17 -07:00
Brian Attwell 0ae0bee625 RandomWinner game for tutorial4 2017-11-01 13:24:17 -07:00
Brian Attwell 139abbda12 Create starter code based on tutorial3 code 2017-11-01 13:24:17 -07:00
Yuan Lu dad8dbc864 Merge pull request #66 from uber/yuanlu-fix
Fix tests for Android tutorial 3
2017-10-31 17:53:53 +01:00
Brian Attwell 684e3c7ccf Update readme with rib tree 2017-10-30 10:17:52 -07:00
Brian Attwell d648832944 Screenshot for tutorial 1 2017-10-30 10:11:37 -07:00
Yuan Lu a10fe0310f Fix tests for Android tutorial 3 2017-10-30 17:44:37 +01:00
Brian Attwell 694cc8fe5b Fix autodispose checker test
Also delete unused test files
2017-10-29 17:13:53 -07:00
Yuan Lu 5ac3443866 Android tutorial 3 finish code 2017-10-28 23:35:38 +02:00
Yuan Lu 53e0a7fc90 Base code for android tutorial 3 2017-10-27 18:03:00 +02:00
Yuan Lu 4e8bede14f Updaate readme for Android tutorial1 2017-10-26 20:17:28 +02:00
Gergely Orosz 89f2f4df9b Fixing compilation issue due to the RootView class not being public 2017-10-20 21:34:01 +02:00
Brian Attwell 9fe20aa0b5 Rename tutorial1 to tutorial1-create-a-rib 2017-10-19 13:03:17 -07:00
Brian Attwell db65c48c68 Starter code for tutorial2.
This is just completed tutorial 1.
2017-10-19 13:01:42 -07:00
Brian Attwell 0eba02df93 Readme update: reason for LoggedOutPresenter 2017-10-19 11:40:54 -07:00