GitHub/MessageKit
1
0
Fork 0
mirror of https://github.com/MessageKit/MessageKit.git synced 2026-02-06 19:03:19 +00:00
Code Issues Packages Projects Releases Wiki Activity
1,278 Commits 3 Branches 61 Tags
4e6250fcd233ae810371eea2d0a57e91d7e94de0
Commit Graph
1278 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Nathan Tannar d9f8856d63 Add back parseForAttachedImages 2018-08-01 12:24:52 -07:00
Nathan Tannar 51f1ff30cb Changelog edit 2018-08-01 11:58:25 -07:00
Nathan Tannar 34dcda013a Fix #569 and #789 2018-08-01 11:55:21 -07:00
Andrey Tarantsov 8f7c4077c0 Fix: make extraBottomInset work when set before showing 2018-08-01 13:27:41 +03:00
Andrey Tarantsov 8fb64d983b CHANGELOG for keyboard handling changes 2018-08-01 13:14:56 +03:00
Andrey Tarantsov a0b0749231 Introduce extraBottomInset property 2018-08-01 13:14:41 +03:00
Andrey Tarantsov 79b1ff02cd Rename computeXxx to requiredXxx 2018-08-01 13:14:21 +03:00
Andrey Tarantsov 2ca89ec9cd Better document the rationale behind keyboard code 2018-08-01 12:57:10 +03:00
Andrey Tarantsov b49a0e0827 A tiny optimisation in keyboard handling 2018-08-01 12:22:21 +03:00
Andrey Tarantsov 39d4b6c032 Add a link to WWDC video about keyboard insets 2018-08-01 10:55:18 +03:00
Andrey Tarantsov 9eed4d8182 Adjust contentInset for the keyboard frame properly 
This change provides better handling of keyboard frames. It copes with different values of UIViewController.edgesForExtendedLayout, UIScrollView.contentInsetAdjumentBehavior, view controller containment scenarios and undocked keyboards, and uses cleaner code.

Improvements and fixes in this change:

1. Translates keyboard frame from screen coordinates into view controller coordinates. They aren’t the same thing when containment is involved, or edgesForExtendedLayout does not include .top.

2. Avoids special casing any iPhone models and avoids dealing with safeAreaInsets manually. In iOS 11, UIScrollView may behave differently depending on contentInsetAdjumentBehavior, and the old code incorrectly assumed that the mode is .always (while it is in fact is .automatic) and that no extra safe area insets have been introduced at the bottom edge. Best part, we don’t have to deal with any of this at all, we can offload the logic to UIScrollView itself by looking at the difference between adjustedContentInset and contentInset.

3. Handles view controller containment and undocked keyboards by taking into account an intersection of the scroll view frame and the keyboard’s frame. I think Apple demoes this in one of the WWDC videos, but I couldn’t find which one (or if I’m misremembering). Regardless, this technique makes sure we compute and use a sensible number.

There’s also a couple of extra renames that make the intention of the modified code clearer.
 2018-07-30 16:47:28 +03:00
Steven DeutschandGitHub d58c6a8a89 Merge pull request #782 from ArchieR7/patch-1 
Update Code of Conduct link
 2018-07-25 03:44:35 -05:00
ArchieChangandGitHub ec9a048092 Update Code of Conduct link 2018-07-25 16:17:15 +08:00
Steven DeutschandGitHub 18a2e58ec1 Merge pull request #772 from brandon-haugen/add-avatar-positioning-to-faq 
Add a bit about positioning Avatars in FAQ
 2018-07-19 11:10:15 -05:00
Brandon Haugen cc8ebf8dc8 Add a bit about positioning Avatars in FAQ 2018-07-19 10:50:54 -05:00
Wu ZhongandGitHub 5a0ef33d8b Merge pull request #765 from zhongwuzw/make-CellSizeCalculator-init-open 
Make initializer of CellSizeCalculator open
 2018-07-16 11:27:12 +08:00
zhongwuzw ab59a6d67b Make initializer of CellSizeCalculator open 2018-07-16 11:13:03 +08:00
Steven Deutsch 57165b75d5 Merge branch 'development' of https://github.com/MessageKit/MessageKit into development 2018-07-03 10:56:08 -05:00
Steven DeutschandGitHub a3f07c6bd0 Merge pull request #745 from brandon-haugen/update-faq-for-removing-avatar 
Update faq for removing avatar
 2018-06-30 11:57:54 -05:00
Brandon Haugen c364b04778 Update method name for changing props on CellSizeCalculator 
This should be done in viewDidLoad, not
configureAvatarView
 2018-06-30 09:10:51 -05:00
Brandon Haugen 2fdde13915 Make explicit that avatar size is set in configureAvatarView 2018-06-29 16:01:35 -05:00
Brandon Haugen 103067222e Add convenience methods for avatar size to FAQ 2018-06-29 16:01:26 -05:00
Steven DeutschandGitHub fab22c543d Merge pull request #710 from hyouuu/development 
Add customizable accessoryView besides messageContainer
 2018-06-26 23:12:36 -05:00
Shawn Gong 957f5ff18e update changelog 2018-06-26 19:09:32 -07:00
hyouuuandGitHub ee08f3c88f Merge pull request #1 from MessageKit/development 
Merge from upstream
 2018-06-26 19:07:41 -07:00
Shawn Gong 7dd498ac5c revert changelog 2018-06-26 19:04:26 -07:00
Shawn Gong bd1c1b35af Added entry in changelog 2018-06-26 18:57:50 -07:00
Steven DeutschandGitHub 28ac5f5e41 Merge pull request #742 from MessageKit/development 
Release 1.0.0
1.0.0 		2018-06-26 20:20:54 -05:00
Steven Deutsch 427c0ae3e4 Release 1.0.0 2018-06-26 19:52:07 -05:00
Steven DeutschandGitHub d4fd57c6e0 Merge pull request #728 from MessageKit/development 
Release MessageKit 1.0.0-beta.2
1.0.0-beta.2 		2018-06-15 08:00:45 -05:00
Steven DeutschandGitHub 8aff9c21a8 Merge branch 'master' into development 2018-06-13 18:48:17 -05:00
Steven Deutsch ce7beaaa3d Merge branch 'development' of https://github.com/MessageKit/MessageKit into development 2018-06-13 18:45:59 -05:00
Steven Deutsch b0c9cf3bc0 Cut 1.0.0-beta.2 release 2018-06-13 18:44:19 -05:00
Steven DeutschandGitHub 90f3e36e84 Merge pull request #727 from MessageKit/relax/protocol-reqs 
Relax MediaItem and LocationItem protocol set requirement
 2018-06-13 18:24:58 -05:00
Steven Deutsch f78d71177d Add CHANGELOG entry 2018-06-13 18:11:38 -05:00
Steven DeutschandGitHub 10c98b04fe Merge pull request #726 from MessageKit/tooling/stale 
Setup stale to close issues
 2018-06-13 18:06:34 -05:00
Steven Deutsch ca117642b0 Relax protocol requirements for get/set 2018-06-13 18:06:25 -05:00
Steven Deutsch f237f4c5a1 Setup stale to close issues 2018-06-13 17:55:17 -05:00
hyouuuandGitHub 4086f3f199 Merge branch 'development' into development 2018-06-07 12:57:32 -07:00
Wu ZhongandGitHub 528ed1aae6 Fixed MessageContentCell's subviews frame when size equal to .zero (#716) 
* Fixed MessageContentCell's subviews frame when size equal to .zero

* Remove .zero check

* Fix test failure
 2018-06-07 11:45:32 +08:00
Shawn Gong 2aa83ee984 Revert "keyboard frame done more correctly" 
This reverts commit 081ca7ab1e.
 2018-06-05 13:23:51 -07:00
Shawn Gong 081ca7ab1e keyboard frame done more correctly 2018-06-04 23:26:07 -07:00
Shawn Gong 4dabb02d2e Fix broken test (not related to this PR), and formatting 2018-06-04 16:55:31 -07:00
Shawn Gong 9c3032d8f7 Don’t ignore size calculation on zero size, and consider accessoryView height 2018-06-02 22:15:19 -07:00
Shawn Gong 7fde2fdc26 mimic avatar 2018-06-02 19:11:19 -07:00
Shawn Gong 3554e3fd24 Fix configCell stub cell type 2018-06-02 14:27:51 -07:00
Shawn Gong b36924e3d2 consider accessoryViewPadding vertical attributes 2018-06-02 14:18:34 -07:00
Shawn Gong 9c23282d07 Add customizable accessoryView besides messageContainer 2018-06-02 02:10:51 -07:00
Steven DeutschandGitHub 46bebecb6e Merge pull request #707 from zhongwuzw/fix-bottom-inset 
Fixed MessagesCollectionView's bottom inset when hardware keyboard is…
 2018-06-01 15:00:42 -05:00
Steven DeutschandGitHub 95f3921986 Merge branch 'development' into fix-bottom-inset 2018-06-01 14:59:54 -05:00