From 07f7d52d3583d7d12113357f7fcf554933f8805b Mon Sep 17 00:00:00 2001 From: Bas Broek Date: Fri, 1 Jun 2018 17:47:52 +0200 Subject: [PATCH 1/6] Rewrite issue template to a HTML comment --- .github/issue_template.md | 37 ++++++++++++++++++++----------------- 1 file changed, 20 insertions(+), 17 deletions(-) diff --git a/.github/issue_template.md b/.github/issue_template.md index a2680d0e..ad226dfc 100644 --- a/.github/issue_template.md +++ b/.github/issue_template.md @@ -1,26 +1,29 @@ -## General Information + From f237f4c5a13c1e6c710da2541ceb27033d78df2d Mon Sep 17 00:00:00 2001 From: Steven Deutsch Date: Wed, 13 Jun 2018 17:55:17 -0500 Subject: [PATCH 2/6] Setup stale to close issues --- .github/stale.yml | 35 +++++++++++++++++++++++++++++++++++ 1 file changed, 35 insertions(+) create mode 100644 .github/stale.yml diff --git a/.github/stale.yml b/.github/stale.yml new file mode 100644 index 00000000..74cb8c43 --- /dev/null +++ b/.github/stale.yml @@ -0,0 +1,35 @@ +# Configuration for probot-stale - https://github.com/probot/stale + +# Number of days of inactivity before an Issue or Pull Request becomes stale +daysUntilStale: 14 + +# Number of days of inactivity before a stale Issue or Pull Request is closed +daysUntilClose: 7 + +# Issues or Pull Requests with these labels will never be considered stale +exemptLabels: + - "enhancement" + - "confirmed bug" + - "discussion" + - "feature request" + - "documentation" + +# Label to use when marking as stale +staleLabel: stale + +# Comment to post when marking as stale. Set to `false` to disable +markComment: > + This issue has been marked as stale because it has not had + recent activity. It will be closed if no further activity occurs. + +# Comment to post when removing the stale label. Set to `false` to disable +unmarkComment: false + +# Comment to post when closing a stale Issue or Pull Request. Set to `false` to disable +closeComment: > + This issue has been auto-closed because there hasn't been any activity for at least 21 days. + However, we really appreciate your contribution, so thank you for that! 🙏 + Also, feel free to [open a new issue](https://github.com/MessageKit/MessageKit/issues/new) if you still experience this problem 👍. + +# Limit to only `issues` +only: issues From ca117642b06dd0a8bb014d191f1c8520875906e8 Mon Sep 17 00:00:00 2001 From: Steven Deutsch Date: Wed, 13 Jun 2018 18:06:25 -0500 Subject: [PATCH 3/6] Relax protocol requirements for get/set --- Sources/Protocols/LocationItem.swift | 4 ++-- Sources/Protocols/MediaItem.swift | 8 ++++---- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/Sources/Protocols/LocationItem.swift b/Sources/Protocols/LocationItem.swift index 5cb12b5d..f08fccb3 100644 --- a/Sources/Protocols/LocationItem.swift +++ b/Sources/Protocols/LocationItem.swift @@ -28,9 +28,9 @@ import class CoreLocation.CLLocation public protocol LocationItem { /// The location. - var location: CLLocation { get set } + var location: CLLocation { get } /// The size of the location item. - var size: CGSize { get set } + var size: CGSize { get } } diff --git a/Sources/Protocols/MediaItem.swift b/Sources/Protocols/MediaItem.swift index 10acfe12..cddb94c7 100644 --- a/Sources/Protocols/MediaItem.swift +++ b/Sources/Protocols/MediaItem.swift @@ -28,15 +28,15 @@ import Foundation public protocol MediaItem { /// The url where the media is located. - var url: URL? { get set } + var url: URL? { get } /// The image. - var image: UIImage? { get set } + var image: UIImage? { get } /// A placeholder image for when the image is obtained asychronously. - var placeholderImage: UIImage { get set } + var placeholderImage: UIImage { get } /// The size of the media item. - var size: CGSize { get set } + var size: CGSize { get } } From f78d71177dab9275bb185e033b2721b3d9861a3e Mon Sep 17 00:00:00 2001 From: Steven Deutsch Date: Wed, 13 Jun 2018 18:11:38 -0500 Subject: [PATCH 4/6] Add CHANGELOG entry --- CHANGELOG.md | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 30eecdb9..03e56f45 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -6,6 +6,11 @@ The changelog for `MessageKit`. Also see the [releases](https://github.com/Messa ## Upcoming release +### Changed + +- Relaxed the settable requirement for the `LocationItem` and `MediaItem` protocols. +[#727](https://github.com/MessageKit/MessageKit/pull/716) by [@SD10](https://github.com/sd10). + ### Fixed - Fixed `MessageContentCell`'s subviews `frame` when size equal to `.zero`. From b0c9cf3bc0c8c0956e2deb35abf1e4fa18ef84f3 Mon Sep 17 00:00:00 2001 From: Steven Deutsch Date: Wed, 13 Jun 2018 18:44:19 -0500 Subject: [PATCH 5/6] Cut 1.0.0-beta.2 release --- CHANGELOG.md | 2 ++ MessageKit.podspec | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 30eecdb9..be4dfeb8 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -6,6 +6,8 @@ The changelog for `MessageKit`. Also see the [releases](https://github.com/Messa ## Upcoming release +## [[Prerelease] 1.0.0-beta.2](https://github.com/MessageKit/MessageKit/releases/tag/1.0.0-beta.2) + ### Fixed - Fixed `MessageContentCell`'s subviews `frame` when size equal to `.zero`. diff --git a/MessageKit.podspec b/MessageKit.podspec index 04643ad8..5f8791b2 100644 --- a/MessageKit.podspec +++ b/MessageKit.podspec @@ -1,6 +1,6 @@ Pod::Spec.new do |s| s.name = 'MessageKit' - s.version = '1.0.0-beta.1' + s.version = '1.0.0-beta.2' s.license = { :type => "MIT", :file => "LICENSE.md" } s.summary = 'An elegant messages UI library for iOS.' From 427c0ae3e4778afb562361872b4153a085ab7982 Mon Sep 17 00:00:00 2001 From: Steven Deutsch Date: Tue, 26 Jun 2018 19:52:07 -0500 Subject: [PATCH 6/6] Release 1.0.0 --- CHANGELOG.md | 4 ++++ MessageKit.podspec | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 1c814f67..fb68a287 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -6,6 +6,10 @@ The changelog for `MessageKit`. Also see the [releases](https://github.com/Messa ## Upcoming release +## [1.0.0](https://github.com/MessageKit/MessageKit/releases/tag/1.0.0) + +- First major release. + ## [[Prerelease] 1.0.0-beta.2](https://github.com/MessageKit/MessageKit/releases/tag/1.0.0-beta.2) ### Changed diff --git a/MessageKit.podspec b/MessageKit.podspec index 5f8791b2..f7c44868 100644 --- a/MessageKit.podspec +++ b/MessageKit.podspec @@ -1,6 +1,6 @@ Pod::Spec.new do |s| s.name = 'MessageKit' - s.version = '1.0.0-beta.2' + s.version = '1.0.0' s.license = { :type => "MIT", :file => "LICENSE.md" } s.summary = 'An elegant messages UI library for iOS.'