diff --git a/CHANGELOG.md b/CHANGELOG.md index de8c4447..401c583c 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -18,6 +18,10 @@ The changelog for `MessageKit`. Also see the [releases](https://github.com/Messa - Fixed `requiredInitialScrollViewBottomInset` when `inputAccessoryView` is `nil` [#1218](https://github.com/MessageKit/MessageKit/pull/1218) by [@aabosh](https://github.com/aabosh) + - Fixed `MessagesCollectionView.scrollToBottom(animated:)` method to properly handle calls made early in the view lifecycle. [#1110](https://github.com/MessageKit/MessageKit/pull/1110) by [@marcetcheverry](https://github.com/marcetcheverry) + + - Fixed `TypingIndicator` `dotColor` for light mode. [#1266](https://github.com/MessageKit/MessageKit/pull/1266) by [@lewis-smith](https://github.com/lewis-smith) + ### Added - Add missing textAlignment and textInsets assignments to layoutCellTopLabel method in MessageContentCell. [#1117](https://github.com/MessageKit/MessageKit/pull/1117) by [@mdescalzo](https://github.com/mdescalzo) @@ -26,24 +30,27 @@ The changelog for `MessageKit`. Also see the [releases](https://github.com/Messa - Add loading indicator to AudioMessageCell. [#1084](https://github.com/MessageKit/MessageKit/pull/1084) by [@marcetcheverry](https://github.com/marcetcheverry) -- Lazily initialize the MessageInputBar on MessagesViewController. [#1092](https://github.com/MessageKit/MessageKit/pull/1092) by [@marcetcheverry](https://github.com/marcetcheverry) - - Add support for Dark Mode [#1189](https://github.com/MessageKit/MessageKit/pull/1189) by [@Vlada31R](https://github.com/Vlada31R) -- Add support for `scrollToLastItem` and `scrollsToLastItemOnKeyboardBeginsEditing` [#1247](https://github.com/MessageKit/MessageKit/pull/1247) by [@youuu](https://github.com/youuu) +- Add support for `scrollToLastItem` and `scrollsToLastItemOnKeyboardBeginsEditing` [#1247](https://github.com/MessageKit/MessageKit/pull/1247) by [@hyouuu](https://github.com/hyouuu) + +- Added `MessageCellDelegate.didTapImage(in cell: MessageCollectionViewCell)` [#1166](https://github.com/MessageKit/MessageKit/pull/1166) by [@domeniconicoli](https://github.com/domeniconicoli), [#1278](https://github.com/MessageKit/MessageKit/pull/1278) by [@bguidolim](https://github.com/bguidolim), [1285](https://github.com/MessageKit/MessageKit/pull/1285) by [@austinwright](https://github.com/austinwright) + +- Added missing cellTopLabelAlignment to MessageSizeCalculator. [#1113](https://github.com/MessageKit/MessageKit/pull/1113) by [@marcetcheverry](https://github.com/marcetcheverry) ### Changed - **Breaking Change** Updated to Swift 5.0 [#1039](https://github.com/MessageKit/MessageKit/pull/1039) by [@nathantannar4](https://github.com/nathantannar4) -- Fixes scrollToBottom method to properly handle calls made early in the view lifecycle. [#1110](https://github.com/MessageKit/MessageKit/pull/1110) by [@marcetcheverry](https://github.com/marcetcheverry) +- Lazily initialize the MessageInputBar on MessagesViewController. [#1092](https://github.com/MessageKit/MessageKit/pull/1092) by [@marcetcheverry](https://github.com/marcetcheverry) -- Add missing cellTopLabelAlignment to MessageSizeCalculator. [#1113](https://github.com/MessageKit/MessageKit/pull/1113) by [@marcetcheverry](https://github.com/marcetcheverry) +### Deprecated -- **Breaking Change** `MessageInputBar`, and `MessageInputBarDelegate` have been obsoleted. Use`InputBarAccessoryView` and `InputBarAccessoryViewDelegate` respectively. This change was previously meant for 3.0.0 but was implemented erroneously. [#1201](https://github.com/MessageKit/MessageKit/pull/1201) by [@kinoroy](https://github.com/kinoroy) +- Deprecated `SenderType.id` in favour of `SenderType.senderId`. This change was previously meant for 3.0.0. [#1201](https://github.com/MessageKit/MessageKit/pull/1201) by [@kinoroy](https://github.com/kinoroy) -- Deprecated `SenderType.id` in favour of `SenderType.senderId`. This change was previously meant for 3.0.0 but - was implemented erroneously. [#1201](https://github.com/MessageKit/MessageKit/pull/1201) by [@kinoroy](https://github.com/kinoroy) +### Removed + +- **Breaking Change** `MessageInputBar`, and `MessageInputBarDelegate` have been obsoleted. Use `InputBarAccessoryView` and `InputBarAccessoryViewDelegate` respectively. This change was previously meant for 3.0.0. [#1201](https://github.com/MessageKit/MessageKit/pull/1201) by [@kinoroy](https://github.com/kinoroy) ## 3.0.0 diff --git a/CHANGELOG_GUIDELINES.md b/CHANGELOG_GUIDELINES.md index d644f1e1..8851728d 100644 --- a/CHANGELOG_GUIDELINES.md +++ b/CHANGELOG_GUIDELINES.md @@ -12,7 +12,6 @@ Here you can find the general guidelines for maintaining the Changelog (or addin - Mention whether you follow Semantic Versioning. ... with MessageKit-specific additions: -- Keep an unreleased section at the top. - Add PR number and a GitHub tag at the end of each entry. - Each breaking change entry should have **Breaking Change** label at the beginning of this entry. - **Breaking Change** entries should be placed at the top of the section it's in. diff --git a/Example/Podfile.lock b/Example/Podfile.lock index 90135709..7923213c 100644 --- a/Example/Podfile.lock +++ b/Example/Podfile.lock @@ -1,8 +1,8 @@ PODS: - - InputBarAccessoryView (4.3.1): - - InputBarAccessoryView/Core (= 4.3.1) - - InputBarAccessoryView/Core (4.3.1) - - MessageKit (3.1.0-beta.1): + - InputBarAccessoryView (4.3.2): + - InputBarAccessoryView/Core (= 4.3.2) + - InputBarAccessoryView/Core (4.3.2) + - MessageKit (3.1.0): - InputBarAccessoryView (~> 4.3.0) - SwiftLint (0.39.1) @@ -20,10 +20,10 @@ EXTERNAL SOURCES: :path: "../" SPEC CHECKSUMS: - InputBarAccessoryView: 58a348be7ea2736c7eec60e5c315511c2dbb39fd - MessageKit: 01a62c3f7de7b4055e44c28689f94d3df59005fb + InputBarAccessoryView: 7985d418040a05fe894bd4b8328dd43ab35517c3 + MessageKit: d0c1c91a9d575b8837749623b45bbc3dfccb1328 SwiftLint: 55e96a4a4d537d4a3156859fc1c54bd24851a046 PODFILE CHECKSUM: 71c5ec35ac2c10fb00dc79becd288bc472fdc6bf -COCOAPODS: 1.9.0 +COCOAPODS: 1.9.1 diff --git a/MessageKit.podspec b/MessageKit.podspec index cd49bca1..76998923 100644 --- a/MessageKit.podspec +++ b/MessageKit.podspec @@ -1,6 +1,6 @@ Pod::Spec.new do |s| s.name = 'MessageKit' - s.version = '3.1.0-beta.1' + s.version = '3.1.0' s.license = { :type => "MIT", :file => "LICENSE.md" } s.summary = 'An elegant messages UI library for iOS.' diff --git a/Sources/Views/Cells/MediaMessageCell.swift b/Sources/Views/Cells/MediaMessageCell.swift index 6363e989..b66d8f8a 100644 --- a/Sources/Views/Cells/MediaMessageCell.swift +++ b/Sources/Views/Cells/MediaMessageCell.swift @@ -84,14 +84,13 @@ open class MediaMessageCell: MessageContentCell { /// Handle tap gesture on contentView and its subviews. open override func handleTapGesture(_ gesture: UIGestureRecognizer) { - let touchLocation = gesture.location(in: self) - - switch true { - case imageView.frame.contains(touchLocation): - delegate?.didTapImage(in: self) - default: - break + let touchLocation = gesture.location(in: imageView) + + guard imageView.frame.contains(touchLocation) else { + super.handleTapGesture(gesture) + return } + delegate?.didTapImage(in: self) } }