From b0fa664ce1a0cfe2918f049ac09e163d4744e9fd Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jakub=20Ka=C5=A1par?= Date: Thu, 28 Apr 2022 11:23:22 +0200 Subject: [PATCH 1/9] Update README.md --- README.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/README.md b/README.md index ef300b99..932178f1 100644 --- a/README.md +++ b/README.md @@ -50,7 +50,7 @@ See [VISION.md](https://github.com/MessageKit/MessageKit/blob/master/VISION.md) ### [CocoaPods](https://cocoapods.org/) **Recommended** ```ruby -# Swift 5.3 +# Swift 5.5 pod 'MessageKit' ``` @@ -83,7 +83,7 @@ Older versions of Swift and Xcode don't support MessageKit via SPM. ## Requirements - **iOS 12** or later -- **Swift 5.3** or later +- **Swift 5.5** or later > For iOS 11 please use version 3.3.0 From 3b0ff01a0957a7f179c671fc5e691a5579aa8053 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Martin=20P=C3=BA=C4=8Dik?= Date: Sat, 30 Apr 2022 10:25:32 +0200 Subject: [PATCH 2/9] Delete NSConstraintLayoutSet.swift --- Sources/Models/NSConstraintLayoutSet.swift | 81 ---------------------- 1 file changed, 81 deletions(-) delete mode 100644 Sources/Models/NSConstraintLayoutSet.swift diff --git a/Sources/Models/NSConstraintLayoutSet.swift b/Sources/Models/NSConstraintLayoutSet.swift deleted file mode 100644 index 79140928..00000000 --- a/Sources/Models/NSConstraintLayoutSet.swift +++ /dev/null @@ -1,81 +0,0 @@ -/* - MIT License - - Copyright (c) 2017-2019 MessageKit - - Permission is hereby granted, free of charge, to any person obtaining a copy - of this software and associated documentation files (the "Software"), to deal - in the Software without restriction, including without limitation the rights - to use, copy, modify, merge, publish, distribute, sublicense, and/or sell - copies of the Software, and to permit persons to whom the Software is - furnished to do so, subject to the following conditions: - - The above copyright notice and this permission notice shall be included in all - copies or substantial portions of the Software. - - THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR - IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, - FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE - AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER - LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, - OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE - SOFTWARE. - */ - -import UIKit - -internal class NSLayoutConstraintSet { - - internal var top: NSLayoutConstraint? - internal var bottom: NSLayoutConstraint? - internal var left: NSLayoutConstraint? - internal var right: NSLayoutConstraint? - internal var centerX: NSLayoutConstraint? - internal var centerY: NSLayoutConstraint? - internal var width: NSLayoutConstraint? - internal var height: NSLayoutConstraint? - - internal init(top: NSLayoutConstraint? = nil, bottom: NSLayoutConstraint? = nil, - left: NSLayoutConstraint? = nil, right: NSLayoutConstraint? = nil, - centerX: NSLayoutConstraint? = nil, centerY: NSLayoutConstraint? = nil, - width: NSLayoutConstraint? = nil, height: NSLayoutConstraint? = nil) { - self.top = top - self.bottom = bottom - self.left = left - self.right = right - self.centerX = centerX - self.centerY = centerY - self.width = width - self.height = height - } - - /// All of the currently configured constraints - private var availableConstraints: [NSLayoutConstraint] { - let constraints = [top, bottom, left, right, centerX, centerY, width, height] - var available: [NSLayoutConstraint] = [] - for constraint in constraints { - if let value = constraint { - available.append(value) - } - } - return available - } - - /// Activates all of the non-nil constraints - /// - /// - Returns: Self - @discardableResult - internal func activate() -> Self { - NSLayoutConstraint.activate(availableConstraints) - return self - } - - /// Deactivates all of the non-nil constraints - /// - /// - Returns: Self - @discardableResult - internal func deactivate() -> Self { - NSLayoutConstraint.deactivate(availableConstraints) - return self - } -} From bb638b6094c8795ab0d73e4b3c1fdb35fe69b836 Mon Sep 17 00:00:00 2001 From: martinpucik Date: Sun, 1 May 2022 10:55:00 +0200 Subject: [PATCH 3/9] Delete NSConstraintLayoutSet.swift Changelog --- CHANGELOG.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 488142e7..e904df8f 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -12,6 +12,8 @@ The changelog for `MessageKit`. Also see the [releases](https://github.com/Messa ### Removed +- NSConstraintLayoutSet.swift [#1700](https://github.com/MessageKit/MessageKit/pull/1700) by [@martinpucik](https://github.com/martinpucik) + ## 3.8.0 ### Added From 24d3226e5b4192a294d4f1b14d886326fbb6a376 Mon Sep 17 00:00:00 2001 From: martinpucik Date: Sun, 1 May 2022 11:00:23 +0200 Subject: [PATCH 4/9] Delete NSConstraintLayoutSet.swift Disable broken workflow --- .github/workflows/danger.yml | 28 ++++++++++++++-------------- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/.github/workflows/danger.yml b/.github/workflows/danger.yml index 1d84a139..63236d8c 100644 --- a/.github/workflows/danger.yml +++ b/.github/workflows/danger.yml @@ -1,19 +1,19 @@ -name: Danger +# name: Danger -on: - pull_request: - branches: - - master +# on: +# pull_request: +# branches: +# - master -jobs: - danger: - name: Run Danger - runs-on: macOS-latest - steps: - - name: Checkout the Git repository - uses: actions/checkout@v2 - with: - fetch-depth: 0 +# jobs: +# danger: +# name: Run Danger +# runs-on: macOS-latest +# steps: +# - name: Checkout the Git repository +# uses: actions/checkout@v2 +# with: +# fetch-depth: 0 # - name: Cache Gems # uses: actions/cache@v1 # with: From f39a340cfc5eea4c5c74125e91067b6b1a2e6e38 Mon Sep 17 00:00:00 2001 From: martinpucik Date: Sun, 1 May 2022 11:16:03 +0200 Subject: [PATCH 5/9] Delete NSConstraintLayoutSet.swift Replace danger workflow --- .github/workflows/danger.yml | 29 ----------------------------- .github/workflows/labeler.yml | 15 +++++++++++++++ 2 files changed, 15 insertions(+), 29 deletions(-) delete mode 100644 .github/workflows/danger.yml create mode 100644 .github/workflows/labeler.yml diff --git a/.github/workflows/danger.yml b/.github/workflows/danger.yml deleted file mode 100644 index 63236d8c..00000000 --- a/.github/workflows/danger.yml +++ /dev/null @@ -1,29 +0,0 @@ -# name: Danger - -# on: -# pull_request: -# branches: -# - master - -# jobs: -# danger: -# name: Run Danger -# runs-on: macOS-latest -# steps: -# - name: Checkout the Git repository -# uses: actions/checkout@v2 -# with: -# fetch-depth: 0 -# - name: Cache Gems -# uses: actions/cache@v1 -# with: -# path: vendor/bundle -# key: ${{ runner.os }}-danger-${{ env.cache-name }}-gems-${{ hashFiles('**/Gemfile.lock') }} -# restore-keys: | -# ${{ runner.os }}-danger-${{ env.cache-name }}-gems- -# ${{ runner.os }}-danger-${{ env.cache-name }}- -# ${{ runner.os }}-danger- -# - name: Run build script -# run: gem install bundler && bundle install && bundle exec danger --fail-on-errors=true -# env: -# DANGER_GITHUB_API_TOKEN: ${{ secrets.GITHUB_TOKEN }} diff --git a/.github/workflows/labeler.yml b/.github/workflows/labeler.yml new file mode 100644 index 00000000..f49bb3ff --- /dev/null +++ b/.github/workflows/labeler.yml @@ -0,0 +1,15 @@ +name: Labeler +on: [pull_request] + +jobs: + label: + + runs-on: ubuntu-latest + permissions: + contents: read + pull-requests: write + + steps: + - uses: actions/labeler@v4 + with: + repo-token: "${{ secrets.GITHUB_TOKEN }}" \ No newline at end of file From df0ff476cb111d2fd43e9978e2d1b05befd3f68d Mon Sep 17 00:00:00 2001 From: martinpucik Date: Sun, 1 May 2022 11:17:58 +0200 Subject: [PATCH 6/9] Revert "Delete NSConstraintLayoutSet.swift" This reverts commit f39a340cfc5eea4c5c74125e91067b6b1a2e6e38. --- .github/workflows/danger.yml | 29 +++++++++++++++++++++++++++++ .github/workflows/labeler.yml | 15 --------------- 2 files changed, 29 insertions(+), 15 deletions(-) create mode 100644 .github/workflows/danger.yml delete mode 100644 .github/workflows/labeler.yml diff --git a/.github/workflows/danger.yml b/.github/workflows/danger.yml new file mode 100644 index 00000000..63236d8c --- /dev/null +++ b/.github/workflows/danger.yml @@ -0,0 +1,29 @@ +# name: Danger + +# on: +# pull_request: +# branches: +# - master + +# jobs: +# danger: +# name: Run Danger +# runs-on: macOS-latest +# steps: +# - name: Checkout the Git repository +# uses: actions/checkout@v2 +# with: +# fetch-depth: 0 +# - name: Cache Gems +# uses: actions/cache@v1 +# with: +# path: vendor/bundle +# key: ${{ runner.os }}-danger-${{ env.cache-name }}-gems-${{ hashFiles('**/Gemfile.lock') }} +# restore-keys: | +# ${{ runner.os }}-danger-${{ env.cache-name }}-gems- +# ${{ runner.os }}-danger-${{ env.cache-name }}- +# ${{ runner.os }}-danger- +# - name: Run build script +# run: gem install bundler && bundle install && bundle exec danger --fail-on-errors=true +# env: +# DANGER_GITHUB_API_TOKEN: ${{ secrets.GITHUB_TOKEN }} diff --git a/.github/workflows/labeler.yml b/.github/workflows/labeler.yml deleted file mode 100644 index f49bb3ff..00000000 --- a/.github/workflows/labeler.yml +++ /dev/null @@ -1,15 +0,0 @@ -name: Labeler -on: [pull_request] - -jobs: - label: - - runs-on: ubuntu-latest - permissions: - contents: read - pull-requests: write - - steps: - - uses: actions/labeler@v4 - with: - repo-token: "${{ secrets.GITHUB_TOKEN }}" \ No newline at end of file From 06948870c04def679a996d6672cc5fb0a5e94163 Mon Sep 17 00:00:00 2001 From: martinpucik Date: Sun, 1 May 2022 11:19:05 +0200 Subject: [PATCH 7/9] Delete NSConstraintLayoutSet.swift Update danger workflow --- .github/workflows/danger.yml | 28 ++++++++++++++-------------- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/.github/workflows/danger.yml b/.github/workflows/danger.yml index 63236d8c..a465165a 100644 --- a/.github/workflows/danger.yml +++ b/.github/workflows/danger.yml @@ -1,19 +1,19 @@ -# name: Danger +name: Danger -# on: -# pull_request: -# branches: -# - master +on: + pull_request: + branches: + - master -# jobs: -# danger: -# name: Run Danger -# runs-on: macOS-latest -# steps: -# - name: Checkout the Git repository -# uses: actions/checkout@v2 -# with: -# fetch-depth: 0 +jobs: + danger: + name: Run Danger + runs-on: ubuntu-latest + steps: + - name: Checkout the Git repository + uses: actions/checkout@v2 + with: + fetch-depth: 0 # - name: Cache Gems # uses: actions/cache@v1 # with: From c94e0ef5ff4e1cc0d096a4492014ef0cb4b641a2 Mon Sep 17 00:00:00 2001 From: martinpucik Date: Sun, 1 May 2022 11:26:26 +0200 Subject: [PATCH 8/9] Delete NSConstraintLayoutSet.swift Update danger workflow --- .github/workflows/danger.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/danger.yml b/.github/workflows/danger.yml index a465165a..6b0d2672 100644 --- a/.github/workflows/danger.yml +++ b/.github/workflows/danger.yml @@ -26,4 +26,4 @@ jobs: # - name: Run build script # run: gem install bundler && bundle install && bundle exec danger --fail-on-errors=true # env: -# DANGER_GITHUB_API_TOKEN: ${{ secrets.GITHUB_TOKEN }} +# DANGER_GITHUB_API_TOKEN: ${{ secrets.GITHUB_TOKEN }} \ No newline at end of file From 6dc0f1e0fb607a794c2e3037e45127b9d6792340 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jakub=20Ka=C5=A1par?= Date: Sun, 1 May 2022 22:28:47 +0200 Subject: [PATCH 9/9] Update danger.yml --- .github/workflows/danger.yml | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/.github/workflows/danger.yml b/.github/workflows/danger.yml index 6b0d2672..50e07064 100644 --- a/.github/workflows/danger.yml +++ b/.github/workflows/danger.yml @@ -1,9 +1,8 @@ name: Danger -on: +on: pull_request: - branches: - - master + types: [opened, reopened, synchronize, ready_for_review] jobs: danger: @@ -26,4 +25,4 @@ jobs: # - name: Run build script # run: gem install bundler && bundle install && bundle exec danger --fail-on-errors=true # env: -# DANGER_GITHUB_API_TOKEN: ${{ secrets.GITHUB_TOKEN }} \ No newline at end of file +# DANGER_GITHUB_API_TOKEN: ${{ secrets.GITHUB_TOKEN }}