From 9ae07a96018eaade3f39c593aed8d8ec262bdcca Mon Sep 17 00:00:00 2001 From: Felix Mau Date: Wed, 27 Apr 2022 18:57:29 +0200 Subject: [PATCH] =?UTF-8?q?=E2=99=BB=EF=B8=8F=20::=20Simplified=20tests?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- ...entActivityIndicatorViewModelTestCase.swift | 18 ++++++++---------- 1 file changed, 8 insertions(+), 10 deletions(-) diff --git a/Example/ExampleTests/ViewModel/GradientActivityIndicatorViewModelTestCase.swift b/Example/ExampleTests/ViewModel/GradientActivityIndicatorViewModelTestCase.swift index f8cab7f..ae2ab59 100644 --- a/Example/ExampleTests/ViewModel/GradientActivityIndicatorViewModelTestCase.swift +++ b/Example/ExampleTests/ViewModel/GradientActivityIndicatorViewModelTestCase.swift @@ -40,16 +40,15 @@ final class GradientActivityIndicatorViewModelTestCase: XCTestCase { receivedIsAnimating = isAnimating } - let isHidden = true - // When withExtendedLifetime(disposable) { - viewModel.isHidden = isHidden + viewModel.isHidden = true } // Then - let expectedIsAnimating = !isHidden - XCTAssertEqual(receivedIsAnimating, expectedIsAnimating) + XCTAssertFalse( + try XCTUnwrap(receivedIsAnimating, "Expected to have received a value from the subscription closure at this point.") + ) } func test_settingIsHidden_toFalse_shouldUpdateIsAnimatingSubject_withTrue() throws { @@ -59,16 +58,15 @@ final class GradientActivityIndicatorViewModelTestCase: XCTestCase { receivedIsAnimating = isAnimating } - let isHidden = false - // When withExtendedLifetime(disposable) { - viewModel.isHidden = isHidden + viewModel.isHidden = false } // Then - let expectedIsAnimating = !isHidden - XCTAssertEqual(receivedIsAnimating, expectedIsAnimating) + XCTAssertTrue( + try XCTUnwrap(receivedIsAnimating, "Expected to have received a value from the subscription closure at this point.") + ) } // MARK: - Test property `bounds`