GitHub/Conductor
1
0 Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
127 Commits 5 Branches 47 Tags
3769e706aff8009825faffc6e3ac3d354805a36d
Commit Graph
72 Commits
Author SHA1 Message Date
Eric Kuck 3769e706af Fixes #124 2016-10-03 14:05:03 -05:00
Eric Kuck 8a890644ee Fixes issues with ControllerChangeHandlers being reused when they should not be. 2016-09-30 18:07:47 -05:00
Eric Kuck b2ffa7f7f6 Fixes #127 2016-09-30 17:38:14 -05:00
Eric Kuck 960b931744 Added a view state getter, which is needed if view state must be obtained at the time of view creation (ex: for Google Maps) 2016-09-30 17:33:54 -05:00
Eric Kuck 47158da05e Fixes tests 2016-09-28 13:16:56 -05:00
Eric Kuck b9c22d267d Fixed issue with no view being attached if orientation changed at the exact same instant as a SimpleSwapChangeHandler being run 2016-09-28 12:34:11 -05:00
Eric Kuck 46e6fac6db Fixed issue with AnimatorChangeHandler crashing if onAnimationEnd is called after onAnimationCancel 2016-09-27 15:57:37 -05:00
Eric Kuck e4f7e9e175 Fixes memory leak in CircularRevealAnimatorChangeHandler (and any other AnimatorChangeHandler that kept a reference to its view) 2016-09-26 09:50:29 -05:00
Eric Kuck 4ab99b68da Fixes #123 2016-09-26 09:34:41 -05:00
Eric Kuck 812d1f8911 Fixes issue where controllers that are being animated out, but haven't yet been detached, at the time of an orientation change could be incorrectly attached to the new Activity. 2016-09-24 11:24:13 -05:00
Eric Kuck ac8288fece Fixed issue where views would not detach when rapidly setting the root controller 2016-09-24 00:29:36 -05:00
Eric Kuck d2dd786b72 Fixed issue where setting the root controller twice in a row will cause the first controller's view to remain attached 2016-09-23 17:42:57 -05:00
Eric Kuck 093238cc52 Should fix #106 (more testing needed) 2016-09-06 16:10:47 -05:00
Eric Kuck c153e29273 Fixes #107 2016-09-06 15:49:30 -05:00
Eric Kuck 2757c7a4b6 Fixes #108 2016-09-06 15:46:25 -05:00
Hannes Struß b0a5da2b82 Remove listeners after animator ends/is canceled (#104) 2016-09-05 10:43:22 -05:00
dimsuz 9f640380bf Document a return value of Router.handleBack() (#93) 2016-07-20 17:49:59 -05:00
Eric Kuck a3faaede61 Fixes #97 and cleans up some tests 2016-07-20 15:41:19 -05:00
Eric Kuck 94d8add220 Fixes #98 2016-07-20 14:56:12 -05:00
Eric Kuck ae27c5e453 Another test for #86 2016-07-11 16:30:31 -05:00
Eric Kuck e4d23a7c74 Added some tests around #86 2016-07-11 16:24:07 -05:00
Eric Kuck 778cdcfd58 Controllers now properly persist their retain view modes 2016-07-11 13:37:38 -05:00
Eric Kuck 5e730947aa Corrected logic for first fix on #86 2016-07-11 13:37:22 -05:00
Eric Kuck 8c323b9613 Fixes issue with demo app trying to reuse change handlers 2016-07-08 14:59:19 -05:00
Eric Kuck af45aae110 Fixes 2nd issue associated with #86 2016-07-08 13:33:47 -05:00
Eric Kuck dc4c3a9709 Fixes at least one cause of #86 2016-07-07 20:59:37 -05:00
Eric Kuck ef84fbd547 AnimatorChangeHandlers are now properly cancelable 2016-07-07 18:32:04 -05:00
Eric Kuck 431569763e First pass at a fix for #85 2016-07-07 17:43:26 -05:00
Eric Kuck 557e4c2122 V2 (#80) 
* Added test for adding and removing children

* [WIP] First pass at nested routers. Still needs a bunch of refactoring, testing, and documentation.

* Pulled save and restore calls out of the lifecycle, as Activity's callbacks make it impossible to fit into a nice little box (#48)

* [WIP] Removed old way of setting root controller in favor of reusing transactions

* [WIP] Added a bottom navigation demo for testing nested routers. Still have a bunch of issues with it.

* [WIP] Child routers now receive events properly (and don't crash most of the time!)

* Fixed a few leaks + handling of back presses in child routers

* Fixed tests

* Simplified making routers not handle back events

* Fixed onAttach callback for Android < 6

* Several child router bug fixes

* [WIP] Backstack getter and setter now exists (#64)

* Fixed some issues with viewpagers

* Added support for saving and restoring controllers in a pager adapter

* Fixed issue with re-attached child controllers prematurely destroying

* Better demo for multiple child routers + upgraded to butterknife 8

* Added basic master/detail flow demo

* Fixed issue where simultaneously pushing 2 controllers with animated transitions would cause the first controller's child routers to never re-load.

* Doc updates

* Removed ControllerTransaction base class, as everything is now added to routers.
Remove RouterTransaction.Builder and replaced it with a more fluent api

* Doc update

* Fixed tesets

* Doc update (had trouble with last version on maven central)

* Just some minor refactoring

* See ya, hungarian notation (#77)

* Should fix #75

* Adds public getters for RouterTransaction fields (#76)

* Doc updates

* Fixed #78 (deeply nested controllers not correctly restored)

* Fixes #79 (child routers no longer monitored after being restored)

* Final doc updates for v2
 2016-06-27 17:57:50 -05:00
Mykhailo Shchurov 30ef5a187b Added cause to the instantiation exception (#62) 2016-06-11 16:01:10 -05:00
Eric Kuck 7528437f65 HorizontalChangeHandler now correctly resets the X translation. 2016-05-24 14:45:33 -07:00
adi1133 e2e8260876 Add proguard rules (#51) 
* Add proguard rules

* Add default constructor to proguard rules
 2016-05-16 15:35:16 -05:00
Eric Kuck 6dfc5839cc Fixed maven central artifacts 2016-05-12 10:36:54 -05:00
Eric Kuck c7de32584b Fixed memory leak in view pager demo controller 2016-05-09 18:01:00 -05:00
Eric Kuck bfacab984b Added some tests for lifecycle call ordering 2016-04-27 15:45:59 -05:00
Eric Kuck f8a05731d9 Now removes the view's OnAttachStateListener before removing the reference 
Fixes ordering of external lifecycle callbacks
 2016-04-27 15:11:54 -05:00
Eric Kuck 116b5066c9 Fixed issue where view was not re-created if its old view was still attached. 2016-04-26 14:33:37 -05:00
Eric Kuck 011adca579 Fixed a typo 2016-04-25 13:33:36 -05:00
adi1133 95de69a006 Make getControllerWithInstanceId search recursively (#30) 
* Make getControllerWithInstanceId search recursively

* Deprecate getChildControllerWithInstanceId()

* Rename getControllerWithInstanceId to findController making it internal
 2016-04-25 13:11:12 -05:00
Eric Kuck 29d1fd1c7d Switched to sonatype for deployment + snapshots 2016-04-19 15:52:40 -05:00
Eric Kuck f6493507f4 Options menu now works for child controllers 
Added more tests
 2016-04-18 14:07:52 -05:00
Eric Kuck 43dc561ac2 Fixed up some save/restore view state stuff (incl. tests) 2016-04-16 13:51:37 -05:00
Eric Kuck 217b55090a Added test for backgrounding the host activity 2016-04-16 13:18:24 -05:00
Eric Kuck 5c8b78e41d Fixed orientation change test 2016-04-16 12:25:45 -05:00
Eric Kuck 899dd70d50 Merge pull request #25 from sockeqwe/viewStateListener 
added methods to lifecyclelistener for saving/restoring viewstate
 2016-04-16 12:04:51 -05:00
Eric Kuck d945571d31 Improved controller lifecycle test coverage (and clarity) 2016-04-16 12:04:20 -05:00
Hannes Dorfmann b7a4386d22 Renamed parameter of onRestoreViewState() to savedViewState 2016-04-16 14:01:41 +02:00
Hannes Dorfmann b117307340 added methods to lifecyclelistener for saving/restoring viewstate 2016-04-15 19:52:43 +02:00
Eric Kuck b8ccf3623f Fixed onRestoreState call ordering for controllers with parent/child relationships 2016-04-14 14:20:56 -05:00
Eric Kuck 495145b72b Router, Activity, target controller, etc is all now available in onRestoreInstanceState 2016-04-13 15:39:09 -05:00