mirror of
https://github.com/facebook/react.git
synced 2025-11-01 09:12:30 +00:00
036ae3c6e2
* Use native event dispatching instead of Simulate or SimulateNative In #12629 @gaearon suggested that it would be better to drop usage of `ReactTestUtils.Simulate` and `ReactTestUtils.SimulateNative`. In this PR I’m attempting at removing it from a lot of places with only a few leftovers. Those leftovers can be categorized into three groups: 1. Anything that tests that `SimulateNative` throws. This is a property that native event dispatching doesn’t have so I can’t convert that easily. Affected test suites: `EventPluginHub-test`, `ReactBrowserEventEmitter-test`. 2. Anything that tests `ReactTestUtils` directly. Affected test suites: `ReactBrowserEventEmitter-test` (this file has one test that reads "should have mouse enter simulated by test utils"), `ReactTestUtils-test`. 3. Anything that dispatches a `change` event. The reason here goes a bit deeper and is rooted in the way we shim onChange. Usually when using native event dispatching, you would set the node’s `.value` and then dispatch the event. However inside [`inputValueTracking.js`][] we install a setter on the node’s `.value` that will ignore the next `change` event (I found [this][near-perfect-oninput-shim] article from Sophie that explains that this is to avoid onChange when updating the value via JavaScript). All remaining usages of `Simulate` or `SimulateNative` can be avoided by mounting the containers inside the `document` and dispatching native events. Here some remarks: 1. I’m using `Element#click()` instead of `dispatchEvent`. In the jsdom changelog I read that `click()` now properly sets the correct values (you can also verify it does the same thing by looking at the [source][jsdom-source]). 2. I had to update jsdom in order to get `TouchEvent` constructors working (and while doing so also updated jest). There was one unexpected surprise: `ReactScheduler-test` was relying on not having `window.performance` available. I’ve recreated the previous environment by deleting this property from the global object. 3. I was a bit confused that `ReactTestUtils.renderIntoDocument()` does not render into the document 🤷 [`inputValueTracking.js`]: https://github.com/facebook/react/blob/392530104c00c25074ce38e1f7e1dd363018c7ce/packages/react-dom/src/client/inputValueTracking.js#L79 [near-perfect-oninput-shim]: https://sophiebits.com/2013/06/18/a-near-perfect-oninput-shim-for-ie-8-and-9.html [jsdom-source]: https://github.com/jsdom/jsdom/blob/45b77f5d21cef74cad278d089937d8462c29acce/lib/jsdom/living/nodes/HTMLElement-impl.js#L43-L76 * Make sure contains are unlinked from the document even if the test fails * Remove unnecessary findDOMNode calls
669 lines
19 KiB
JavaScript
669 lines
19 KiB
JavaScript
/**
|
|
* Copyright (c) 2013-present, Facebook, Inc.
|
|
*
|
|
* This source code is licensed under the MIT license found in the
|
|
* LICENSE file in the root directory of this source tree.
|
|
*
|
|
* @emails react-core
|
|
*/
|
|
|
|
'use strict';
|
|
|
|
let React;
|
|
let ReactDOM;
|
|
let ReactDOMServer;
|
|
let ReactTestUtils;
|
|
|
|
describe('ReactComponent', () => {
|
|
function normalizeCodeLocInfo(str) {
|
|
return str && str.replace(/\(at .+?:\d+\)/g, '(at **)');
|
|
}
|
|
|
|
beforeEach(() => {
|
|
React = require('react');
|
|
ReactDOM = require('react-dom');
|
|
ReactDOMServer = require('react-dom/server');
|
|
ReactTestUtils = require('react-dom/test-utils');
|
|
});
|
|
|
|
it('should throw on invalid render targets', () => {
|
|
const container = document.createElement('div');
|
|
// jQuery objects are basically arrays; people often pass them in by mistake
|
|
expect(function() {
|
|
ReactDOM.render(<div />, [container]);
|
|
}).toThrowError(/Target container is not a DOM element./);
|
|
|
|
expect(function() {
|
|
ReactDOM.render(<div />, null);
|
|
}).toThrowError(/Target container is not a DOM element./);
|
|
});
|
|
|
|
it('should throw when supplying a ref outside of render method', () => {
|
|
let instance = <div ref="badDiv" />;
|
|
expect(function() {
|
|
instance = ReactTestUtils.renderIntoDocument(instance);
|
|
}).toThrow();
|
|
});
|
|
|
|
it('should throw (in dev) when children are mutated during render', () => {
|
|
function Wrapper(props) {
|
|
props.children[1] = <p key={1} />; // Mutation is illegal
|
|
return <div>{props.children}</div>;
|
|
}
|
|
if (__DEV__) {
|
|
expect(() => {
|
|
ReactTestUtils.renderIntoDocument(
|
|
<Wrapper>
|
|
<span key={0} />
|
|
<span key={1} />
|
|
<span key={2} />
|
|
</Wrapper>,
|
|
);
|
|
}).toThrowError(/Cannot assign to read only property.*/);
|
|
} else {
|
|
ReactTestUtils.renderIntoDocument(
|
|
<Wrapper>
|
|
<span key={0} />
|
|
<span key={1} />
|
|
<span key={2} />
|
|
</Wrapper>,
|
|
);
|
|
}
|
|
});
|
|
|
|
it('should throw (in dev) when children are mutated during update', () => {
|
|
class Wrapper extends React.Component {
|
|
componentDidMount() {
|
|
this.props.children[1] = <p key={1} />; // Mutation is illegal
|
|
this.forceUpdate();
|
|
}
|
|
|
|
render() {
|
|
return <div>{this.props.children}</div>;
|
|
}
|
|
}
|
|
|
|
if (__DEV__) {
|
|
expect(() => {
|
|
ReactTestUtils.renderIntoDocument(
|
|
<Wrapper>
|
|
<span key={0} />
|
|
<span key={1} />
|
|
<span key={2} />
|
|
</Wrapper>,
|
|
);
|
|
}).toThrowError(/Cannot assign to read only property.*/);
|
|
} else {
|
|
ReactTestUtils.renderIntoDocument(
|
|
<Wrapper>
|
|
<span key={0} />
|
|
<span key={1} />
|
|
<span key={2} />
|
|
</Wrapper>,
|
|
);
|
|
}
|
|
});
|
|
|
|
it('should support refs on owned components', () => {
|
|
const innerObj = {};
|
|
const outerObj = {};
|
|
|
|
class Wrapper extends React.Component {
|
|
getObject = () => {
|
|
return this.props.object;
|
|
};
|
|
|
|
render() {
|
|
return <div>{this.props.children}</div>;
|
|
}
|
|
}
|
|
|
|
class Component extends React.Component {
|
|
render() {
|
|
const inner = <Wrapper object={innerObj} ref="inner" />;
|
|
const outer = (
|
|
<Wrapper object={outerObj} ref="outer">
|
|
{inner}
|
|
</Wrapper>
|
|
);
|
|
return outer;
|
|
}
|
|
|
|
componentDidMount() {
|
|
expect(this.refs.inner.getObject()).toEqual(innerObj);
|
|
expect(this.refs.outer.getObject()).toEqual(outerObj);
|
|
}
|
|
}
|
|
|
|
ReactTestUtils.renderIntoDocument(<Component />);
|
|
});
|
|
|
|
it('should not have refs on unmounted components', () => {
|
|
class Parent extends React.Component {
|
|
render() {
|
|
return (
|
|
<Child>
|
|
<div ref="test" />
|
|
</Child>
|
|
);
|
|
}
|
|
|
|
componentDidMount() {
|
|
expect(this.refs && this.refs.test).toEqual(undefined);
|
|
}
|
|
}
|
|
|
|
class Child extends React.Component {
|
|
render() {
|
|
return <div />;
|
|
}
|
|
}
|
|
|
|
ReactTestUtils.renderIntoDocument(<Parent child={<span />} />);
|
|
});
|
|
|
|
it('should support callback-style refs', () => {
|
|
const innerObj = {};
|
|
const outerObj = {};
|
|
|
|
class Wrapper extends React.Component {
|
|
getObject = () => {
|
|
return this.props.object;
|
|
};
|
|
|
|
render() {
|
|
return <div>{this.props.children}</div>;
|
|
}
|
|
}
|
|
|
|
let mounted = false;
|
|
|
|
class Component extends React.Component {
|
|
render() {
|
|
const inner = (
|
|
<Wrapper object={innerObj} ref={c => (this.innerRef = c)} />
|
|
);
|
|
const outer = (
|
|
<Wrapper object={outerObj} ref={c => (this.outerRef = c)}>
|
|
{inner}
|
|
</Wrapper>
|
|
);
|
|
return outer;
|
|
}
|
|
|
|
componentDidMount() {
|
|
expect(this.innerRef.getObject()).toEqual(innerObj);
|
|
expect(this.outerRef.getObject()).toEqual(outerObj);
|
|
mounted = true;
|
|
}
|
|
}
|
|
|
|
ReactTestUtils.renderIntoDocument(<Component />);
|
|
expect(mounted).toBe(true);
|
|
});
|
|
|
|
it('should support object-style refs', () => {
|
|
const innerObj = {};
|
|
const outerObj = {};
|
|
|
|
class Wrapper extends React.Component {
|
|
getObject = () => {
|
|
return this.props.object;
|
|
};
|
|
|
|
render() {
|
|
return <div>{this.props.children}</div>;
|
|
}
|
|
}
|
|
|
|
let mounted = false;
|
|
|
|
class Component extends React.Component {
|
|
constructor() {
|
|
super();
|
|
this.innerRef = React.createRef();
|
|
this.outerRef = React.createRef();
|
|
}
|
|
render() {
|
|
const inner = <Wrapper object={innerObj} ref={this.innerRef} />;
|
|
const outer = (
|
|
<Wrapper object={outerObj} ref={this.outerRef}>
|
|
{inner}
|
|
</Wrapper>
|
|
);
|
|
return outer;
|
|
}
|
|
|
|
componentDidMount() {
|
|
expect(this.innerRef.current.getObject()).toEqual(innerObj);
|
|
expect(this.outerRef.current.getObject()).toEqual(outerObj);
|
|
mounted = true;
|
|
}
|
|
}
|
|
|
|
ReactTestUtils.renderIntoDocument(<Component />);
|
|
expect(mounted).toBe(true);
|
|
});
|
|
|
|
it('should support new-style refs with mixed-up owners', () => {
|
|
class Wrapper extends React.Component {
|
|
getTitle = () => {
|
|
return this.props.title;
|
|
};
|
|
|
|
render() {
|
|
return this.props.getContent();
|
|
}
|
|
}
|
|
|
|
let mounted = false;
|
|
|
|
class Component extends React.Component {
|
|
getInner = () => {
|
|
// (With old-style refs, it's impossible to get a ref to this div
|
|
// because Wrapper is the current owner when this function is called.)
|
|
return <div className="inner" ref={c => (this.innerRef = c)} />;
|
|
};
|
|
|
|
render() {
|
|
return (
|
|
<Wrapper
|
|
title="wrapper"
|
|
ref={c => (this.wrapperRef = c)}
|
|
getContent={this.getInner}
|
|
/>
|
|
);
|
|
}
|
|
|
|
componentDidMount() {
|
|
// Check .props.title to make sure we got the right elements back
|
|
expect(this.wrapperRef.getTitle()).toBe('wrapper');
|
|
expect(this.innerRef.className).toBe('inner');
|
|
mounted = true;
|
|
}
|
|
}
|
|
|
|
ReactTestUtils.renderIntoDocument(<Component />);
|
|
expect(mounted).toBe(true);
|
|
});
|
|
|
|
it('should call refs at the correct time', () => {
|
|
const log = [];
|
|
|
|
class Inner extends React.Component {
|
|
render() {
|
|
log.push(`inner ${this.props.id} render`);
|
|
return <div />;
|
|
}
|
|
|
|
componentDidMount() {
|
|
log.push(`inner ${this.props.id} componentDidMount`);
|
|
}
|
|
|
|
componentDidUpdate() {
|
|
log.push(`inner ${this.props.id} componentDidUpdate`);
|
|
}
|
|
|
|
componentWillUnmount() {
|
|
log.push(`inner ${this.props.id} componentWillUnmount`);
|
|
}
|
|
}
|
|
|
|
class Outer extends React.Component {
|
|
render() {
|
|
return (
|
|
<div>
|
|
<Inner
|
|
id={1}
|
|
ref={c => {
|
|
log.push(`ref 1 got ${c ? `instance ${c.props.id}` : 'null'}`);
|
|
}}
|
|
/>
|
|
<Inner
|
|
id={2}
|
|
ref={c => {
|
|
log.push(`ref 2 got ${c ? `instance ${c.props.id}` : 'null'}`);
|
|
}}
|
|
/>
|
|
</div>
|
|
);
|
|
}
|
|
|
|
componentDidMount() {
|
|
log.push('outer componentDidMount');
|
|
}
|
|
|
|
componentDidUpdate() {
|
|
log.push('outer componentDidUpdate');
|
|
}
|
|
|
|
componentWillUnmount() {
|
|
log.push('outer componentWillUnmount');
|
|
}
|
|
}
|
|
|
|
// mount, update, unmount
|
|
const el = document.createElement('div');
|
|
log.push('start mount');
|
|
ReactDOM.render(<Outer />, el);
|
|
log.push('start update');
|
|
ReactDOM.render(<Outer />, el);
|
|
log.push('start unmount');
|
|
ReactDOM.unmountComponentAtNode(el);
|
|
|
|
/* eslint-disable indent */
|
|
expect(log).toEqual([
|
|
'start mount',
|
|
'inner 1 render',
|
|
'inner 2 render',
|
|
'inner 1 componentDidMount',
|
|
'ref 1 got instance 1',
|
|
'inner 2 componentDidMount',
|
|
'ref 2 got instance 2',
|
|
'outer componentDidMount',
|
|
'start update',
|
|
// Previous (equivalent) refs get cleared
|
|
// Fiber renders first, resets refs later
|
|
'inner 1 render',
|
|
'inner 2 render',
|
|
'ref 1 got null',
|
|
'ref 2 got null',
|
|
'inner 1 componentDidUpdate',
|
|
'ref 1 got instance 1',
|
|
'inner 2 componentDidUpdate',
|
|
'ref 2 got instance 2',
|
|
'outer componentDidUpdate',
|
|
'start unmount',
|
|
'outer componentWillUnmount',
|
|
'ref 1 got null',
|
|
'inner 1 componentWillUnmount',
|
|
'ref 2 got null',
|
|
'inner 2 componentWillUnmount',
|
|
]);
|
|
/* eslint-enable indent */
|
|
});
|
|
|
|
it('fires the callback after a component is rendered', () => {
|
|
const callback = jest.fn();
|
|
const container = document.createElement('div');
|
|
ReactDOM.render(<div />, container, callback);
|
|
expect(callback).toHaveBeenCalledTimes(1);
|
|
ReactDOM.render(<div className="foo" />, container, callback);
|
|
expect(callback).toHaveBeenCalledTimes(2);
|
|
ReactDOM.render(<span />, container, callback);
|
|
expect(callback).toHaveBeenCalledTimes(3);
|
|
});
|
|
|
|
it('throws usefully when rendering badly-typed elements', () => {
|
|
const X = undefined;
|
|
expect(() => {
|
|
expect(() => ReactTestUtils.renderIntoDocument(<X />)).toWarnDev(
|
|
'React.createElement: type is invalid -- expected a string (for built-in components) ' +
|
|
'or a class/function (for composite components) but got: undefined.',
|
|
);
|
|
}).toThrowError(
|
|
'Element type is invalid: expected a string (for built-in components) ' +
|
|
'or a class/function (for composite components) but got: undefined.' +
|
|
(__DEV__
|
|
? " You likely forgot to export your component from the file it's " +
|
|
'defined in, or you might have mixed up default and named imports.'
|
|
: ''),
|
|
);
|
|
|
|
const Y = null;
|
|
expect(() => {
|
|
expect(() => ReactTestUtils.renderIntoDocument(<Y />)).toWarnDev(
|
|
'React.createElement: type is invalid -- expected a string (for built-in components) ' +
|
|
'or a class/function (for composite components) but got: null.',
|
|
);
|
|
}).toThrowError(
|
|
'Element type is invalid: expected a string (for built-in components) ' +
|
|
'or a class/function (for composite components) but got: null.',
|
|
);
|
|
});
|
|
|
|
it('includes owner name in the error about badly-typed elements', () => {
|
|
const X = undefined;
|
|
|
|
function Indirection(props) {
|
|
return <div>{props.children}</div>;
|
|
}
|
|
|
|
function Bar() {
|
|
return (
|
|
<Indirection>
|
|
<X />
|
|
</Indirection>
|
|
);
|
|
}
|
|
|
|
function Foo() {
|
|
return <Bar />;
|
|
}
|
|
|
|
expect(() => {
|
|
expect(() => ReactTestUtils.renderIntoDocument(<Foo />)).toWarnDev(
|
|
'React.createElement: type is invalid -- expected a string (for built-in components) ' +
|
|
'or a class/function (for composite components) but got: undefined.',
|
|
);
|
|
}).toThrowError(
|
|
'Element type is invalid: expected a string (for built-in components) ' +
|
|
'or a class/function (for composite components) but got: undefined.' +
|
|
(__DEV__
|
|
? " You likely forgot to export your component from the file it's " +
|
|
'defined in, or you might have mixed up default and named imports.' +
|
|
'\n\nCheck the render method of `Bar`.'
|
|
: ''),
|
|
);
|
|
});
|
|
|
|
it('throws if a plain object is used as a child', () => {
|
|
const children = {
|
|
x: <span />,
|
|
y: <span />,
|
|
z: <span />,
|
|
};
|
|
const element = <div>{[children]}</div>;
|
|
const container = document.createElement('div');
|
|
let ex;
|
|
try {
|
|
ReactDOM.render(element, container);
|
|
} catch (e) {
|
|
ex = e;
|
|
}
|
|
expect(ex).toBeDefined();
|
|
expect(normalizeCodeLocInfo(ex.message)).toBe(
|
|
'Objects are not valid as a React child (found: object with keys {x, y, z}).' +
|
|
(__DEV__
|
|
? ' If you meant to render a collection of children, use ' +
|
|
'an array instead.' +
|
|
'\n in div (at **)'
|
|
: ''),
|
|
);
|
|
});
|
|
|
|
it('throws if a plain object even if it is in an owner', () => {
|
|
class Foo extends React.Component {
|
|
render() {
|
|
const children = {
|
|
a: <span />,
|
|
b: <span />,
|
|
c: <span />,
|
|
};
|
|
return <div>{[children]}</div>;
|
|
}
|
|
}
|
|
const container = document.createElement('div');
|
|
let ex;
|
|
try {
|
|
ReactDOM.render(<Foo />, container);
|
|
} catch (e) {
|
|
ex = e;
|
|
}
|
|
expect(ex).toBeDefined();
|
|
expect(normalizeCodeLocInfo(ex.message)).toBe(
|
|
'Objects are not valid as a React child (found: object with keys {a, b, c}).' +
|
|
(__DEV__
|
|
? ' If you meant to render a collection of children, use ' +
|
|
'an array instead.\n' +
|
|
' in div (at **)\n' +
|
|
' in Foo (at **)'
|
|
: ''),
|
|
);
|
|
});
|
|
|
|
it('throws if a plain object is used as a child when using SSR', async () => {
|
|
const children = {
|
|
x: <span />,
|
|
y: <span />,
|
|
z: <span />,
|
|
};
|
|
const element = <div>{[children]}</div>;
|
|
let ex;
|
|
try {
|
|
ReactDOMServer.renderToString(element);
|
|
} catch (e) {
|
|
ex = e;
|
|
}
|
|
expect(ex).toBeDefined();
|
|
expect(normalizeCodeLocInfo(ex.message)).toBe(
|
|
'Objects are not valid as a React child (found: object with keys {x, y, z}).' +
|
|
(__DEV__
|
|
? ' If you meant to render a collection of children, use ' +
|
|
'an array instead.' +
|
|
'\n in div (at **)'
|
|
: ''),
|
|
);
|
|
});
|
|
|
|
it('throws if a plain object even if it is in an owner when using SSR', async () => {
|
|
class Foo extends React.Component {
|
|
render() {
|
|
const children = {
|
|
a: <span />,
|
|
b: <span />,
|
|
c: <span />,
|
|
};
|
|
return <div>{[children]}</div>;
|
|
}
|
|
}
|
|
const container = document.createElement('div');
|
|
let ex;
|
|
try {
|
|
ReactDOMServer.renderToString(<Foo />, container);
|
|
} catch (e) {
|
|
ex = e;
|
|
}
|
|
expect(ex).toBeDefined();
|
|
expect(normalizeCodeLocInfo(ex.message)).toBe(
|
|
'Objects are not valid as a React child (found: object with keys {a, b, c}).' +
|
|
(__DEV__
|
|
? ' If you meant to render a collection of children, use ' +
|
|
'an array instead.\n' +
|
|
' in div (at **)\n' +
|
|
' in Foo (at **)'
|
|
: ''),
|
|
);
|
|
});
|
|
|
|
describe('with new features', () => {
|
|
it('warns on function as a return value from a function', () => {
|
|
function Foo() {
|
|
return Foo;
|
|
}
|
|
const container = document.createElement('div');
|
|
expect(() => ReactDOM.render(<Foo />, container)).toWarnDev(
|
|
'Warning: Functions are not valid as a React child. This may happen if ' +
|
|
'you return a Component instead of <Component /> from render. ' +
|
|
'Or maybe you meant to call this function rather than return it.\n' +
|
|
' in Foo (at **)',
|
|
);
|
|
});
|
|
|
|
it('warns on function as a return value from a class', () => {
|
|
class Foo extends React.Component {
|
|
render() {
|
|
return Foo;
|
|
}
|
|
}
|
|
const container = document.createElement('div');
|
|
expect(() => ReactDOM.render(<Foo />, container)).toWarnDev(
|
|
'Warning: Functions are not valid as a React child. This may happen if ' +
|
|
'you return a Component instead of <Component /> from render. ' +
|
|
'Or maybe you meant to call this function rather than return it.\n' +
|
|
' in Foo (at **)',
|
|
);
|
|
});
|
|
|
|
it('warns on function as a child to host component', () => {
|
|
function Foo() {
|
|
return (
|
|
<div>
|
|
<span>{Foo}</span>
|
|
</div>
|
|
);
|
|
}
|
|
const container = document.createElement('div');
|
|
expect(() => ReactDOM.render(<Foo />, container)).toWarnDev(
|
|
'Warning: Functions are not valid as a React child. This may happen if ' +
|
|
'you return a Component instead of <Component /> from render. ' +
|
|
'Or maybe you meant to call this function rather than return it.\n' +
|
|
' in span (at **)\n' +
|
|
' in div (at **)\n' +
|
|
' in Foo (at **)',
|
|
);
|
|
});
|
|
|
|
it('does not warn for function-as-a-child that gets resolved', () => {
|
|
function Bar(props) {
|
|
return props.children();
|
|
}
|
|
function Foo() {
|
|
return <Bar>{() => 'Hello'}</Bar>;
|
|
}
|
|
const container = document.createElement('div');
|
|
ReactDOM.render(<Foo />, container);
|
|
expect(container.innerHTML).toBe('Hello');
|
|
});
|
|
|
|
it('deduplicates function type warnings based on component type', () => {
|
|
class Foo extends React.PureComponent {
|
|
constructor() {
|
|
super();
|
|
this.state = {type: 'mushrooms'};
|
|
}
|
|
render() {
|
|
return (
|
|
<div>
|
|
{Foo}
|
|
{Foo}
|
|
<span>
|
|
{Foo}
|
|
{Foo}
|
|
</span>
|
|
</div>
|
|
);
|
|
}
|
|
}
|
|
const container = document.createElement('div');
|
|
let component;
|
|
expect(() => {
|
|
component = ReactDOM.render(<Foo />, container);
|
|
}).toWarnDev([
|
|
'Warning: Functions are not valid as a React child. This may happen if ' +
|
|
'you return a Component instead of <Component /> from render. ' +
|
|
'Or maybe you meant to call this function rather than return it.\n' +
|
|
' in div (at **)\n' +
|
|
' in Foo (at **)',
|
|
'Warning: Functions are not valid as a React child. This may happen if ' +
|
|
'you return a Component instead of <Component /> from render. ' +
|
|
'Or maybe you meant to call this function rather than return it.\n' +
|
|
' in span (at **)\n' +
|
|
' in div (at **)\n' +
|
|
' in Foo (at **)',
|
|
]);
|
|
component.setState({type: 'portobello mushrooms'});
|
|
});
|
|
});
|
|
});
|