mirror of
https://github.com/facebook/react.git
synced 2026-11-18 20:15:56 +00:00
This is a fix specifically for the `enableOptimizeFunctionExpression` feature (disabled by default). I tried running all of our fixtures with that flag on everywhere, and this was the only issue. It's actually extracted from another fixture which is more complicated, this is a distilled version. There were two bugs: * DCE was running after LeaveSSA when it needs to run before. Fixing the order means code inside the function expression stops getting removed. * In the feature flag, context variables share Identifier instances with the surrounding code, whereas they are distinct instances without the feature. This meant that mutable ranges from inside the function propagated outside the function, throwing off our inference. The fix was to reset the ranges of context variables after inferring the function expression's effects.
test262
@ 83a46bfe0e
React Forget
React Forget is an experimental Babel plugin to automatically memoize React Hooks and Components.
Development
# tsc --watch
$ yarn dev
# in another terminal window
$ yarn test --watch
Notes
An overview of the implementation can be found in the Architecture Overview.
This transform
- needs plugin-syntax-jsx as a dependency to inherit the syntax from.
- should be run before plugin-transform-react-jsx
- assume the enforcement of rules of hooks, i.e.
- only call hooks from React functions
- only call hooks at the top level
- https://www.npmjs.com/package/eslint-plugin-react-hooks
Scaffolding
- https://github.com/facebook/flow/tree/master/packages/babel-plugin-transform-flow-enums
- https://github.com/babel/babel/blob/main/packages/babel-plugin-transform-react-jsx/src/create-plugin.ts
Reference