mirror of
https://github.com/facebook/react.git
synced 2025-11-01 09:12:30 +00:00
Mofei Zhang
7e9f6ecfea
--- Copied from comments Older versions of babel have a validation bug fixed by - https://github.com/babel/babel/pull/10917 - (code pointer) https://github.com/babel/babel/commit/e7b80a2cb93cf28010207fc3cdd19b4568ca35b9#diff-19b555d2f3904c206af406540d9df200b1e16befedb83ff39ebfcbd876f7fa8aL52 Link to buggy older version (observe that elements must be PatternLikes here) https://github.com/babel/babel/blob/v7.7.4/packages/babel-types/src/definitions/es2015.js#L50-L53 Link to newer versions with correct validation (observe elements can be PatternLike | null) https://github.com/babel/babel/blob/v7.23.0/packages/babel-types/src/definitions/core.ts#L1306-L1311 Tested on 3000+ components in fb: P898166848 > Unexpected Errors > (count = 0) [patch] Make holey array handling compatible with older babel versions --- Copied from comments Older versions of babel have a validation bug fixed by - https://github.com/babel/babel/pull/10917 - (code pointer) https://github.com/babel/babel/commit/e7b80a2cb93cf28010207fc3cdd19b4568ca35b9#diff-19b555d2f3904c206af406540d9df200b1e16befedb83ff39ebfcbd876f7fa8aL52 Link to buggy older version (observe that elements must be PatternLikes here) https://github.com/babel/babel/blob/v7.7.4/packages/babel-types/src/definitions/es2015.js#L50-L53 Link to newer versions with correct validation (observe elements can be PatternLike | null) https://github.com/babel/babel/blob/v7.23.0/packages/babel-types/src/definitions/core.ts#L1306-L1311 Tested on 3000+ components in fb: P898166848 > Unexpected Errors > (count = 0)