mirror of
https://github.com/facebook/react.git
synced 2025-11-01 09:12:30 +00:00
The previous PR helped me realize we weren't handling Array#at correctly. If the receiver is a mutable value its effect should be Capture and the lvalue effect needs to be Store. This PR updates the definition for Array#at to make the receiver Capture, and then updates inference to automatically set the lvalue effect to Store if _any_ argument (or the receiver) was Capture.
1277 lines
44 KiB
TypeScript
1277 lines
44 KiB
TypeScript
/*
|
|
* Copyright (c) Meta Platforms, Inc. and affiliates.
|
|
*
|
|
* This source code is licensed under the MIT license found in the
|
|
* LICENSE file in the root directory of this source tree.
|
|
*/
|
|
|
|
import { CompilerError } from "../CompilerError";
|
|
import { Environment } from "../HIR";
|
|
import {
|
|
BasicBlock,
|
|
BlockId,
|
|
CallExpression,
|
|
Effect,
|
|
GeneratedSource,
|
|
HIRFunction,
|
|
IdentifierId,
|
|
InstructionKind,
|
|
InstructionValue,
|
|
isMutableEffect,
|
|
isObjectType,
|
|
MethodCall,
|
|
Phi,
|
|
Place,
|
|
Type,
|
|
ValueKind,
|
|
} from "../HIR/HIR";
|
|
import { FunctionSignature } from "../HIR/ObjectShape";
|
|
import {
|
|
printIdentifier,
|
|
printMixedHIR,
|
|
printPlace,
|
|
printSourceLocation,
|
|
} from "../HIR/PrintHIR";
|
|
import {
|
|
eachInstructionOperand,
|
|
eachInstructionValueOperand,
|
|
eachPatternOperand,
|
|
eachTerminalOperand,
|
|
eachTerminalSuccessor,
|
|
} from "../HIR/visitors";
|
|
import { assertExhaustive } from "../Utils/utils";
|
|
|
|
const UndefinedValue: InstructionValue = {
|
|
kind: "Primitive",
|
|
loc: GeneratedSource,
|
|
value: undefined,
|
|
};
|
|
|
|
/*
|
|
* For every usage of a value in the given function, infers the effect or action
|
|
* taken at that reference. Each reference is inferred as exactly one of:
|
|
* - freeze: this usage freezes the value, ie converts it to frozen. This is only inferred
|
|
* when the value *may* not already be frozen.
|
|
* - frozen: the value is known to already be "owned" by React and is therefore already
|
|
* frozen (permanently and transitively immutable).
|
|
* - immutable: the value is not owned by React, but is known to be an immutable value
|
|
* that therefore cannot ever change.
|
|
* - readonly: the value is not frozen or immutable, but this usage of the value does
|
|
* not modify it. the value may be mutated by a subsequent reference. Examples include
|
|
* referencing the operands of a binary expression, or referencing the items/properties
|
|
* of an array or object literal.
|
|
* - mutable: the value is not frozen or immutable, and this usage *may* modify it.
|
|
* Examples include passing a value to as a function argument or assigning into an object.
|
|
*
|
|
* Note that the inference follows variable assignment, so assigning a frozen value
|
|
* to a different value will infer usages of the other variable as frozen as well.
|
|
*
|
|
* The inference assumes that the code follows the rules of React:
|
|
* - React function arguments are frozen (component props, hook arguments).
|
|
* - Hook arguments are frozen at the point the hook is invoked.
|
|
* - React function return values are frozen at the point of being returned,
|
|
* thus the return value of a hook call is frozen.
|
|
* - JSX represents invocation of a React function (the component) and
|
|
* therefore all values passed to JSX become frozen at the point the JSX
|
|
* is created.
|
|
*
|
|
* Internally, the inference tracks the approximate type of value held by each variable,
|
|
* and iterates over the control flow graph. The inferred effect of reach reference is
|
|
* a combination of the operation performed (ie, assignment into an object mutably uses the
|
|
* object; an if condition reads the condition) and the type of the value. The types of values
|
|
* are:
|
|
* - frozen: can be any type so long as the value is known to be owned by React, permanently
|
|
* and transitively immutable
|
|
* - maybe-frozen: the value may or may not be frozen, conditionally depending on control flow.
|
|
* - immutable: a type with value semantics: primitives, records/tuples when standardized.
|
|
* - mutable: a type with reference semantics eg array, object, class instance, etc.
|
|
*
|
|
* When control flow paths converge the types of values are merged together, with the value
|
|
* types forming a lattice to ensure convergence.
|
|
*/
|
|
export default function inferReferenceEffects(
|
|
fn: HIRFunction,
|
|
options: { isFunctionExpression: boolean } = { isFunctionExpression: false }
|
|
): void {
|
|
/*
|
|
* Initial state contains function params
|
|
* TODO: include module declarations here as well
|
|
*/
|
|
const initialState = InferenceState.empty(fn.env);
|
|
const value: InstructionValue = {
|
|
kind: "Primitive",
|
|
loc: fn.loc,
|
|
value: undefined,
|
|
};
|
|
initialState.initialize(value, ValueKind.Frozen);
|
|
|
|
for (const ref of fn.context) {
|
|
// TODO(gsn): This is a hack.
|
|
const value: InstructionValue = {
|
|
kind: "ObjectExpression",
|
|
properties: [],
|
|
loc: ref.loc,
|
|
};
|
|
initialState.initialize(value, ValueKind.Context);
|
|
initialState.define(ref, value);
|
|
}
|
|
|
|
const paramKind = options.isFunctionExpression
|
|
? ValueKind.Mutable
|
|
: ValueKind.Frozen;
|
|
for (const param of fn.params) {
|
|
let value: InstructionValue;
|
|
let place: Place;
|
|
if (param.kind === "Identifier") {
|
|
place = param;
|
|
value = {
|
|
kind: "Primitive",
|
|
loc: param.loc,
|
|
value: undefined,
|
|
};
|
|
} else {
|
|
place = param.place;
|
|
value = {
|
|
kind: "Primitive",
|
|
loc: param.place.loc,
|
|
value: undefined,
|
|
};
|
|
}
|
|
initialState.initialize(value, paramKind);
|
|
initialState.define(place, value);
|
|
}
|
|
|
|
// Map of blocks to the last (merged) incoming state that was processed
|
|
const statesByBlock: Map<BlockId, InferenceState> = new Map();
|
|
|
|
/*
|
|
* Multiple predecessors may be visited prior to reaching a given successor,
|
|
* so track the list of incoming state for each successor block.
|
|
* These are merged when reaching that block again.
|
|
*/
|
|
const queuedStates: Map<BlockId, InferenceState> = new Map();
|
|
function queue(blockId: BlockId, state: InferenceState): void {
|
|
let queuedState = queuedStates.get(blockId);
|
|
if (queuedState != null) {
|
|
// merge the queued states for this block
|
|
state = queuedState.merge(state) ?? state;
|
|
queuedStates.set(blockId, state);
|
|
} else {
|
|
/*
|
|
* this is the first queued state for this block, see whether
|
|
* there are changed relative to the last time it was processed.
|
|
*/
|
|
const prevState = statesByBlock.get(blockId);
|
|
const nextState = prevState != null ? prevState.merge(state) : state;
|
|
if (nextState != null) {
|
|
queuedStates.set(blockId, nextState);
|
|
}
|
|
}
|
|
}
|
|
queue(fn.body.entry, initialState);
|
|
|
|
while (queuedStates.size !== 0) {
|
|
for (const [blockId, block] of fn.body.blocks) {
|
|
const incomingState = queuedStates.get(blockId);
|
|
queuedStates.delete(blockId);
|
|
if (incomingState == null) {
|
|
continue;
|
|
}
|
|
|
|
statesByBlock.set(blockId, incomingState);
|
|
const state = incomingState.clone();
|
|
inferBlock(fn.env, state, block);
|
|
|
|
for (const nextBlockId of eachTerminalSuccessor(block.terminal)) {
|
|
queue(nextBlockId, state);
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
// Maintains a mapping of top-level variables to the kind of value they hold
|
|
class InferenceState {
|
|
#env: Environment;
|
|
|
|
// The kind of reach value, based on its allocation site
|
|
#values: Map<InstructionValue, ValueKind>;
|
|
/*
|
|
* The set of values pointed to by each identifier. This is a set
|
|
* to accomodate phi points (where a variable may have different
|
|
* values from different control flow paths).
|
|
*/
|
|
#variables: Map<IdentifierId, Set<InstructionValue>>;
|
|
|
|
constructor(
|
|
env: Environment,
|
|
values: Map<InstructionValue, ValueKind>,
|
|
variables: Map<IdentifierId, Set<InstructionValue>>
|
|
) {
|
|
this.#env = env;
|
|
this.#values = values;
|
|
this.#variables = variables;
|
|
}
|
|
|
|
static empty(env: Environment): InferenceState {
|
|
return new InferenceState(env, new Map(), new Map());
|
|
}
|
|
|
|
// (Re)initializes a @param value with its default @param kind.
|
|
initialize(value: InstructionValue, kind: ValueKind): void {
|
|
CompilerError.invariant(value.kind !== "LoadLocal", {
|
|
reason:
|
|
"Expected all top-level identifiers to be defined as variables, not values",
|
|
description: null,
|
|
loc: value.loc,
|
|
suggestions: null,
|
|
});
|
|
this.#values.set(value, kind);
|
|
}
|
|
|
|
values(place: Place): Array<InstructionValue> {
|
|
const values = this.#variables.get(place.identifier.id);
|
|
CompilerError.invariant(values != null, {
|
|
reason: `[hoisting] Expected value kind to be initialized`,
|
|
description: `${printPlace(place)}`,
|
|
loc: place.loc,
|
|
suggestions: null,
|
|
});
|
|
return Array.from(values);
|
|
}
|
|
|
|
// Lookup the kind of the given @param value.
|
|
kind(place: Place): ValueKind {
|
|
const values = this.#variables.get(place.identifier.id);
|
|
CompilerError.invariant(values != null, {
|
|
reason: `[hoisting] Expected value kind to be initialized`,
|
|
description: `${printPlace(place)}`,
|
|
loc: place.loc,
|
|
suggestions: null,
|
|
});
|
|
let mergedKind: ValueKind | null = null;
|
|
for (const value of values) {
|
|
const kind = this.#values.get(value)!;
|
|
mergedKind = mergedKind !== null ? mergeValues(mergedKind, kind) : kind;
|
|
}
|
|
CompilerError.invariant(mergedKind !== null, {
|
|
reason: `InferReferenceEffects::kind: Expected at least one value`,
|
|
description: `No value found at '${printPlace(place)}'`,
|
|
loc: place.loc,
|
|
suggestions: null,
|
|
});
|
|
return mergedKind;
|
|
}
|
|
|
|
// Updates the value at @param place to point to the same value as @param value.
|
|
alias(place: Place, value: Place): void {
|
|
const values = this.#variables.get(value.identifier.id);
|
|
CompilerError.invariant(values != null, {
|
|
reason: `[hoisting] Expected value for identifier to be initialized`,
|
|
description: `${printIdentifier(value.identifier)}`,
|
|
loc: value.loc,
|
|
suggestions: null,
|
|
});
|
|
this.#variables.set(place.identifier.id, new Set(values));
|
|
}
|
|
|
|
// Defines (initializing or updating) a variable with a specific kind of value.
|
|
define(place: Place, value: InstructionValue): void {
|
|
CompilerError.invariant(this.#values.has(value), {
|
|
reason: `Expected value to be initialized at '${printSourceLocation(
|
|
value.loc
|
|
)}'`,
|
|
description: null,
|
|
loc: value.loc,
|
|
suggestions: null,
|
|
});
|
|
this.#variables.set(place.identifier.id, new Set([value]));
|
|
}
|
|
|
|
isDefined(place: Place): boolean {
|
|
return this.#variables.has(place.identifier.id);
|
|
}
|
|
|
|
/*
|
|
* Records that a given Place was accessed with the given kind and:
|
|
* - Updates the effect of @param place based on the kind of value
|
|
* and the kind of reference (@param effectKind).
|
|
* - Updates the value kind to reflect the effect of the reference.
|
|
*
|
|
* Notably, a mutable reference is downgraded to readonly if the
|
|
* value unless the value is known to be mutable.
|
|
*
|
|
* Similarly, a freeze reference is converted to readonly if the
|
|
* value is already frozen or is immutable.
|
|
*/
|
|
reference(place: Place, effectKind: Effect): void {
|
|
const values = this.#variables.get(place.identifier.id);
|
|
if (values === undefined) {
|
|
CompilerError.invariant(effectKind !== Effect.Store, {
|
|
reason: "[InferReferenceEffects] Unhandled store reference effect",
|
|
description: null,
|
|
loc: place.loc,
|
|
suggestions: null,
|
|
});
|
|
place.effect =
|
|
effectKind === Effect.ConditionallyMutate
|
|
? Effect.ConditionallyMutate
|
|
: Effect.Read;
|
|
return;
|
|
}
|
|
let valueKind: ValueKind | null = this.kind(place);
|
|
let effect: Effect | null = null;
|
|
switch (effectKind) {
|
|
case Effect.Freeze: {
|
|
if (
|
|
valueKind === ValueKind.Mutable ||
|
|
valueKind === ValueKind.Context ||
|
|
valueKind === ValueKind.MaybeFrozen
|
|
) {
|
|
effect = Effect.Freeze;
|
|
valueKind = ValueKind.Frozen;
|
|
values.forEach((value) => {
|
|
this.#values.set(value, ValueKind.Frozen);
|
|
|
|
if (this.#env.config.enableTransitivelyFreezeFunctionExpressions) {
|
|
if (value.kind === "FunctionExpression") {
|
|
for (const operand of eachInstructionValueOperand(value)) {
|
|
this.reference(operand, Effect.Freeze);
|
|
}
|
|
}
|
|
}
|
|
});
|
|
} else {
|
|
effect = Effect.Read;
|
|
}
|
|
break;
|
|
}
|
|
case Effect.ConditionallyMutate: {
|
|
if (
|
|
valueKind === ValueKind.Mutable ||
|
|
valueKind === ValueKind.Context
|
|
) {
|
|
effect = Effect.ConditionallyMutate;
|
|
} else {
|
|
effect = Effect.Read;
|
|
}
|
|
break;
|
|
}
|
|
case Effect.Mutate: {
|
|
if (
|
|
valueKind === ValueKind.Mutable ||
|
|
valueKind === ValueKind.Context
|
|
) {
|
|
effect = Effect.Mutate;
|
|
} else {
|
|
CompilerError.throwInvalidReact({
|
|
reason: `This mutates a global or a variable after it was passed to React, which means that React cannot observe changes to it`,
|
|
description:
|
|
place.identifier.name !== null
|
|
? `Found mutation of ${place.identifier.name}`
|
|
: null,
|
|
loc: place.loc,
|
|
suggestions: null,
|
|
});
|
|
}
|
|
break;
|
|
}
|
|
case Effect.Store: {
|
|
if (
|
|
valueKind !== ValueKind.Mutable &&
|
|
valueKind !== ValueKind.Context
|
|
) {
|
|
CompilerError.throwInvalidReact({
|
|
reason: `This mutates a global or a variable after it was passed to React, which means that React cannot observe changes to it`,
|
|
description:
|
|
place.identifier.name !== null
|
|
? `Found mutation of ${place.identifier.name}`
|
|
: null,
|
|
loc: place.loc,
|
|
suggestions: null,
|
|
});
|
|
}
|
|
|
|
/*
|
|
* TODO(gsn): This should be bailout once we add bailout infra.
|
|
*
|
|
* invariant(
|
|
* valueKind === ValueKind.Mutable,
|
|
* `expected valueKind to be 'Mutable' but found to be '${valueKind}'`
|
|
* );
|
|
*/
|
|
effect = isObjectType(place.identifier) ? Effect.Store : Effect.Mutate;
|
|
break;
|
|
}
|
|
case Effect.Capture: {
|
|
if (
|
|
valueKind === ValueKind.Immutable ||
|
|
valueKind === ValueKind.Frozen ||
|
|
valueKind === ValueKind.MaybeFrozen
|
|
) {
|
|
effect = Effect.Read;
|
|
} else {
|
|
effect = Effect.Capture;
|
|
}
|
|
break;
|
|
}
|
|
case Effect.Read: {
|
|
effect = Effect.Read;
|
|
break;
|
|
}
|
|
case Effect.Unknown: {
|
|
CompilerError.invariant(false, {
|
|
reason:
|
|
"Unexpected unknown effect, expected to infer a precise effect kind",
|
|
description: null,
|
|
loc: place.loc,
|
|
suggestions: null,
|
|
});
|
|
}
|
|
default: {
|
|
assertExhaustive(
|
|
effectKind,
|
|
`Unexpected reference kind '${effectKind as any as string}'`
|
|
);
|
|
}
|
|
}
|
|
CompilerError.invariant(effect !== null, {
|
|
reason: "Expected effect to be set",
|
|
description: null,
|
|
loc: place.loc,
|
|
suggestions: null,
|
|
});
|
|
place.effect = effect;
|
|
}
|
|
|
|
/*
|
|
* Combine the contents of @param this and @param other, returning a new
|
|
* instance with the combined changes _if_ there are any changes, or
|
|
* returning null if no changes would occur. Changes include:
|
|
* - new entries in @param other that did not exist in @param this
|
|
* - entries whose values differ in @param this and @param other,
|
|
* and where joining the values produces a different value than
|
|
* what was in @param this.
|
|
*
|
|
* Note that values are joined using a lattice operation to ensure
|
|
* termination.
|
|
*/
|
|
merge(other: InferenceState): InferenceState | null {
|
|
let nextValues: Map<InstructionValue, ValueKind> | null = null;
|
|
let nextVariables: Map<IdentifierId, Set<InstructionValue>> | null = null;
|
|
|
|
for (const [id, thisValue] of this.#values) {
|
|
const otherValue = other.#values.get(id);
|
|
if (otherValue !== undefined) {
|
|
const mergedValue = mergeValues(thisValue, otherValue);
|
|
if (mergedValue !== thisValue) {
|
|
nextValues = nextValues ?? new Map(this.#values);
|
|
nextValues.set(id, mergedValue);
|
|
}
|
|
}
|
|
}
|
|
for (const [id, otherValue] of other.#values) {
|
|
if (this.#values.has(id)) {
|
|
// merged above
|
|
continue;
|
|
}
|
|
nextValues = nextValues ?? new Map(this.#values);
|
|
nextValues.set(id, otherValue);
|
|
}
|
|
|
|
for (const [id, thisValues] of this.#variables) {
|
|
const otherValues = other.#variables.get(id);
|
|
if (otherValues !== undefined) {
|
|
let mergedValues: Set<InstructionValue> | null = null;
|
|
for (const otherValue of otherValues) {
|
|
if (!thisValues.has(otherValue)) {
|
|
mergedValues = mergedValues ?? new Set(thisValues);
|
|
mergedValues.add(otherValue);
|
|
}
|
|
}
|
|
if (mergedValues !== null) {
|
|
nextVariables = nextVariables ?? new Map(this.#variables);
|
|
nextVariables.set(id, mergedValues);
|
|
}
|
|
}
|
|
}
|
|
for (const [id, otherValues] of other.#variables) {
|
|
if (this.#variables.has(id)) {
|
|
continue;
|
|
}
|
|
nextVariables = nextVariables ?? new Map(this.#variables);
|
|
nextVariables.set(id, new Set(otherValues));
|
|
}
|
|
|
|
if (nextVariables === null && nextValues === null) {
|
|
return null;
|
|
} else {
|
|
return new InferenceState(
|
|
this.#env,
|
|
nextValues ?? new Map(this.#values),
|
|
nextVariables ?? new Map(this.#variables)
|
|
);
|
|
}
|
|
}
|
|
|
|
/*
|
|
* Returns a copy of this state.
|
|
* TODO: consider using persistent data structures to make
|
|
* clone cheaper.
|
|
*/
|
|
clone(): InferenceState {
|
|
return new InferenceState(
|
|
this.#env,
|
|
new Map(this.#values),
|
|
new Map(this.#variables)
|
|
);
|
|
}
|
|
|
|
/*
|
|
* For debugging purposes, dumps the state to a plain
|
|
* object so that it can printed as JSON.
|
|
*/
|
|
debug(): any {
|
|
const result: any = { values: {}, variables: {} };
|
|
const objects: Map<InstructionValue, number> = new Map();
|
|
function identify(value: InstructionValue): number {
|
|
let id = objects.get(value);
|
|
if (id == null) {
|
|
id = objects.size;
|
|
objects.set(value, id);
|
|
}
|
|
return id;
|
|
}
|
|
for (const [value, kind] of this.#values) {
|
|
const id = identify(value);
|
|
result.values[id] = { kind, value: printMixedHIR(value) };
|
|
}
|
|
for (const [variable, values] of this.#variables) {
|
|
result.variables[variable] = [...values].map(identify);
|
|
}
|
|
return result;
|
|
}
|
|
|
|
inferPhi(phi: Phi): void {
|
|
const values: Set<InstructionValue> = new Set();
|
|
for (const [_, operand] of phi.operands) {
|
|
const operandValues = this.#variables.get(operand.id);
|
|
// This is a backedge that will be handled later by State.merge
|
|
if (operandValues === undefined) continue;
|
|
for (const v of operandValues) {
|
|
values.add(v);
|
|
}
|
|
}
|
|
|
|
if (values.size > 0) {
|
|
this.#variables.set(phi.id.id, values);
|
|
}
|
|
}
|
|
}
|
|
|
|
/*
|
|
* Joins two values using the following rules:
|
|
* == Effect Transitions ==
|
|
*
|
|
* Freezing an immutable value has not effect:
|
|
* ┌───────────────┐
|
|
* │ │
|
|
* ▼ │ Freeze
|
|
* ┌──────────────────────────┐ │
|
|
* │ Immutable │──┘
|
|
* └──────────────────────────┘
|
|
*
|
|
* Freezing a mutable or maybe-frozen value makes it frozen. Freezing a frozen
|
|
* value has no effect:
|
|
* ┌───────────────┐
|
|
* ┌─────────────────────────┐ Freeze │ │
|
|
* │ MaybeFrozen │────┐ ▼ │ Freeze
|
|
* └─────────────────────────┘ │ ┌──────────────────────────┐ │
|
|
* ├────▶│ Frozen │──┘
|
|
* │ └──────────────────────────┘
|
|
* ┌─────────────────────────┐ │
|
|
* │ Mutable │────┘
|
|
* └─────────────────────────┘
|
|
*
|
|
* == Join Lattice ==
|
|
* - immutable | mutable => mutable
|
|
* The justification is that immutable and mutable values are different types,
|
|
* and functions can introspect them to tell the difference (if the argument
|
|
* is null return early, else if its an object mutate it).
|
|
* - frozen | mutable => maybe-frozen
|
|
* Frozen values are indistinguishable from mutable values at runtime, so callers
|
|
* cannot dynamically avoid mutation of "frozen" values. If a value could be
|
|
* frozen we have to distinguish it from a mutable value. But it also isn't known
|
|
* frozen yet, so we distinguish as maybe-frozen.
|
|
* - immutable | frozen => frozen
|
|
* This is subtle and falls out of the above rules. If a value could be any of
|
|
* immutable, mutable, or frozen, then at runtime it could either be a primitive
|
|
* or a reference type, and callers can't distinguish frozen or not for reference
|
|
* types. To ensure that any sequence of joins btw those three states yields the
|
|
* correct maybe-frozen, these two have to produce a frozen value.
|
|
* - <any> | maybe-frozen => maybe-frozen
|
|
* - immutable | context => context
|
|
* - mutable | context => context
|
|
* - frozen | context => maybe-frozen
|
|
*
|
|
* ┌──────────────────────────┐
|
|
* │ Immutable │───┐
|
|
* └──────────────────────────┘ │
|
|
* │ ┌─────────────────────────┐
|
|
* ├───▶│ Frozen │──┐
|
|
* ┌──────────────────────────┐ │ └─────────────────────────┘ │
|
|
* │ Frozen │───┤ │ ┌─────────────────────────┐
|
|
* └──────────────────────────┘ │ ├─▶│ MaybeFrozen │
|
|
* │ ┌─────────────────────────┐ │ └─────────────────────────┘
|
|
* ├───▶│ MaybeFrozen │──┘
|
|
* ┌──────────────────────────┐ │ └─────────────────────────┘
|
|
* │ Mutable │───┘
|
|
* └──────────────────────────┘
|
|
*/
|
|
function mergeValues(a: ValueKind, b: ValueKind): ValueKind {
|
|
if (a === b) {
|
|
return a;
|
|
} else if (a === ValueKind.MaybeFrozen || b === ValueKind.MaybeFrozen) {
|
|
return ValueKind.MaybeFrozen;
|
|
// after this a and b differ and neither are MaybeFrozen
|
|
} else if (a === ValueKind.Mutable || b === ValueKind.Mutable) {
|
|
if (a === ValueKind.Frozen || b === ValueKind.Frozen) {
|
|
// frozen | mutable
|
|
return ValueKind.MaybeFrozen;
|
|
} else if (a === ValueKind.Context || b === ValueKind.Context) {
|
|
// context | mutable
|
|
return ValueKind.Context;
|
|
} else {
|
|
// mutable | immutable
|
|
return ValueKind.Mutable;
|
|
}
|
|
} else if (a === ValueKind.Context || b === ValueKind.Context) {
|
|
if (a === ValueKind.Frozen || b === ValueKind.Frozen) {
|
|
// frozen | context
|
|
return ValueKind.MaybeFrozen;
|
|
} else {
|
|
// context | immutable
|
|
return ValueKind.Context;
|
|
}
|
|
} else {
|
|
// frozen | immutable
|
|
return ValueKind.Frozen;
|
|
}
|
|
}
|
|
|
|
/*
|
|
* Iterates over the given @param block, defining variables and
|
|
* recording references on the @param state according to JS semantics.
|
|
*/
|
|
function inferBlock(
|
|
env: Environment,
|
|
state: InferenceState,
|
|
block: BasicBlock
|
|
): void {
|
|
for (const phi of block.phis) {
|
|
state.inferPhi(phi);
|
|
}
|
|
|
|
for (const instr of block.instructions) {
|
|
const instrValue = instr.value;
|
|
let effectKind: Effect | null = null;
|
|
let lvalueEffect = Effect.ConditionallyMutate;
|
|
let valueKind: ValueKind;
|
|
switch (instrValue.kind) {
|
|
case "BinaryExpression": {
|
|
valueKind = ValueKind.Immutable;
|
|
effectKind = Effect.Read;
|
|
break;
|
|
}
|
|
case "ArrayExpression": {
|
|
valueKind = hasContextRefOperand(state, instrValue)
|
|
? ValueKind.Context
|
|
: ValueKind.Mutable;
|
|
effectKind = Effect.Capture;
|
|
lvalueEffect = Effect.Store;
|
|
break;
|
|
}
|
|
case "NewExpression": {
|
|
valueKind = ValueKind.Mutable;
|
|
effectKind = Effect.ConditionallyMutate;
|
|
break;
|
|
}
|
|
case "ObjectExpression": {
|
|
valueKind = hasContextRefOperand(state, instrValue)
|
|
? ValueKind.Context
|
|
: ValueKind.Mutable;
|
|
|
|
for (const property of instrValue.properties) {
|
|
switch (property.kind) {
|
|
case "ObjectProperty": {
|
|
if (property.key.kind === "computed") {
|
|
// Object keys must be primitives, so we know they're frozen at this point
|
|
state.reference(property.key.name, Effect.Freeze);
|
|
}
|
|
// Object construction captures but does not modify the key/property values
|
|
state.reference(property.place, Effect.Capture);
|
|
break;
|
|
}
|
|
case "Spread": {
|
|
// Object construction captures but does not modify the key/property values
|
|
state.reference(property.place, Effect.Capture);
|
|
break;
|
|
}
|
|
default: {
|
|
assertExhaustive(
|
|
property,
|
|
`Unexpected property kind '${(property as any).kind}'`
|
|
);
|
|
}
|
|
}
|
|
}
|
|
|
|
state.initialize(instrValue, valueKind);
|
|
state.define(instr.lvalue, instrValue);
|
|
instr.lvalue.effect = Effect.Store;
|
|
continue;
|
|
}
|
|
case "UnaryExpression": {
|
|
valueKind = ValueKind.Immutable;
|
|
effectKind = Effect.Read;
|
|
break;
|
|
}
|
|
case "UnsupportedNode": {
|
|
// TODO: handle other statement kinds
|
|
valueKind = ValueKind.Mutable;
|
|
break;
|
|
}
|
|
case "JsxExpression": {
|
|
valueKind = ValueKind.Frozen;
|
|
effectKind = Effect.Freeze;
|
|
break;
|
|
}
|
|
case "JsxFragment": {
|
|
valueKind = ValueKind.Frozen;
|
|
effectKind = Effect.Freeze;
|
|
break;
|
|
}
|
|
case "TaggedTemplateExpression": {
|
|
valueKind = ValueKind.Mutable;
|
|
effectKind = Effect.ConditionallyMutate;
|
|
break;
|
|
}
|
|
case "TemplateLiteral": {
|
|
/*
|
|
* template literal (with no tag function) always produces
|
|
* an immutable string
|
|
*/
|
|
valueKind = ValueKind.Immutable;
|
|
effectKind = Effect.Read;
|
|
break;
|
|
}
|
|
case "RegExpLiteral": {
|
|
// RegExp instances are mutable objects
|
|
valueKind = ValueKind.Mutable;
|
|
effectKind = Effect.ConditionallyMutate;
|
|
break;
|
|
}
|
|
case "Debugger":
|
|
case "LoadGlobal":
|
|
case "JSXText":
|
|
case "Primitive": {
|
|
valueKind = ValueKind.Immutable;
|
|
break;
|
|
}
|
|
case "ObjectMethod":
|
|
case "FunctionExpression": {
|
|
let hasMutableOperand = false;
|
|
for (const operand of eachInstructionOperand(instr)) {
|
|
state.reference(
|
|
operand,
|
|
operand.effect === Effect.Unknown ? Effect.Read : operand.effect
|
|
);
|
|
hasMutableOperand ||= isMutableEffect(operand.effect, operand.loc);
|
|
}
|
|
/*
|
|
* If a closure did not capture any mutable values, then we can consider it to be
|
|
* frozen, which allows it to be independently memoized.
|
|
*/
|
|
state.initialize(
|
|
instrValue,
|
|
hasMutableOperand ? ValueKind.Mutable : ValueKind.Frozen
|
|
);
|
|
state.define(instr.lvalue, instrValue);
|
|
instr.lvalue.effect = Effect.Store;
|
|
continue;
|
|
}
|
|
case "CallExpression": {
|
|
const signature = getFunctionCallSignature(
|
|
env,
|
|
instrValue.callee.identifier.type
|
|
);
|
|
|
|
const effects =
|
|
signature !== null ? getFunctionEffects(instrValue, signature) : null;
|
|
const returnValueKind =
|
|
signature !== null ? signature.returnValueKind : ValueKind.Mutable;
|
|
let hasCaptureArgument = false;
|
|
for (let i = 0; i < instrValue.args.length; i++) {
|
|
const arg = instrValue.args[i];
|
|
const place = arg.kind === "Identifier" ? arg : arg.place;
|
|
if (effects !== null) {
|
|
state.reference(place, effects[i]);
|
|
} else {
|
|
state.reference(place, Effect.ConditionallyMutate);
|
|
}
|
|
hasCaptureArgument ||= place.effect === Effect.Capture;
|
|
}
|
|
if (signature !== null) {
|
|
state.reference(instrValue.callee, signature.calleeEffect);
|
|
} else {
|
|
state.reference(instrValue.callee, Effect.ConditionallyMutate);
|
|
}
|
|
hasCaptureArgument ||= instrValue.callee.effect === Effect.Capture;
|
|
|
|
state.initialize(instrValue, returnValueKind);
|
|
state.define(instr.lvalue, instrValue);
|
|
instr.lvalue.effect = hasCaptureArgument
|
|
? Effect.Store
|
|
: Effect.ConditionallyMutate;
|
|
continue;
|
|
}
|
|
case "MethodCall": {
|
|
CompilerError.invariant(state.isDefined(instrValue.receiver), {
|
|
reason:
|
|
"[InferReferenceEffects] Internal error: receiver of PropertyCall should have been defined by corresponding PropertyLoad",
|
|
description: null,
|
|
loc: instrValue.loc,
|
|
suggestions: null,
|
|
});
|
|
state.reference(instrValue.property, Effect.Read);
|
|
|
|
const signature = getFunctionCallSignature(
|
|
env,
|
|
instrValue.property.identifier.type
|
|
);
|
|
|
|
if (
|
|
signature !== null &&
|
|
signature.mutableOnlyIfOperandsAreMutable &&
|
|
areArgumentsImmutableAndNonMutating(state, instrValue.args)
|
|
) {
|
|
/*
|
|
* None of the args are mutable or mutate their params, we can downgrade to
|
|
* treating as all reads (except that the receiver may be captured)
|
|
*/
|
|
for (const arg of instrValue.args) {
|
|
const place = arg.kind === "Identifier" ? arg : arg.place;
|
|
state.reference(place, Effect.Read);
|
|
}
|
|
state.reference(instrValue.receiver, Effect.Capture);
|
|
state.initialize(instrValue, signature.returnValueKind);
|
|
state.define(instr.lvalue, instrValue);
|
|
instr.lvalue.effect =
|
|
instrValue.receiver.effect === Effect.Capture
|
|
? Effect.Store
|
|
: Effect.ConditionallyMutate;
|
|
continue;
|
|
}
|
|
|
|
const effects =
|
|
signature !== null ? getFunctionEffects(instrValue, signature) : null;
|
|
const returnValueKind =
|
|
signature !== null ? signature.returnValueKind : ValueKind.Mutable;
|
|
let hasCaptureArgument = false;
|
|
for (let i = 0; i < instrValue.args.length; i++) {
|
|
const arg = instrValue.args[i];
|
|
const place = arg.kind === "Identifier" ? arg : arg.place;
|
|
if (effects !== null) {
|
|
/*
|
|
* If effects are inferred for an argument, we should fail invalid
|
|
* mutating effects
|
|
*/
|
|
state.reference(place, effects[i]);
|
|
} else {
|
|
state.reference(place, Effect.ConditionallyMutate);
|
|
}
|
|
hasCaptureArgument ||= place.effect === Effect.Capture;
|
|
}
|
|
if (signature !== null) {
|
|
state.reference(instrValue.receiver, signature.calleeEffect);
|
|
} else {
|
|
state.reference(instrValue.receiver, Effect.ConditionallyMutate);
|
|
}
|
|
hasCaptureArgument ||= instrValue.receiver.effect === Effect.Capture;
|
|
|
|
state.initialize(instrValue, returnValueKind);
|
|
state.define(instr.lvalue, instrValue);
|
|
instr.lvalue.effect = hasCaptureArgument
|
|
? Effect.Store
|
|
: Effect.ConditionallyMutate;
|
|
continue;
|
|
}
|
|
case "PropertyStore": {
|
|
const effect =
|
|
state.kind(instrValue.object) === ValueKind.Context
|
|
? Effect.ConditionallyMutate
|
|
: Effect.Capture;
|
|
state.reference(instrValue.value, effect);
|
|
state.reference(instrValue.object, Effect.Store);
|
|
|
|
const lvalue = instr.lvalue;
|
|
state.alias(lvalue, instrValue.value);
|
|
lvalue.effect = Effect.Store;
|
|
continue;
|
|
}
|
|
case "PropertyDelete": {
|
|
// `delete` returns a boolean (immutable) and modifies the object
|
|
valueKind = ValueKind.Immutable;
|
|
effectKind = Effect.Mutate;
|
|
break;
|
|
}
|
|
case "PropertyLoad": {
|
|
state.reference(instrValue.object, Effect.Read);
|
|
const lvalue = instr.lvalue;
|
|
lvalue.effect = Effect.ConditionallyMutate;
|
|
state.initialize(instrValue, state.kind(instrValue.object));
|
|
state.define(lvalue, instrValue);
|
|
continue;
|
|
}
|
|
case "ComputedStore": {
|
|
const effect =
|
|
state.kind(instrValue.object) === ValueKind.Context
|
|
? Effect.ConditionallyMutate
|
|
: Effect.Capture;
|
|
state.reference(instrValue.value, effect);
|
|
state.reference(instrValue.property, Effect.Capture);
|
|
state.reference(instrValue.object, Effect.Store);
|
|
|
|
const lvalue = instr.lvalue;
|
|
state.alias(lvalue, instrValue.value);
|
|
lvalue.effect = Effect.Store;
|
|
continue;
|
|
}
|
|
case "ComputedDelete": {
|
|
state.reference(instrValue.object, Effect.Mutate);
|
|
state.reference(instrValue.property, Effect.Read);
|
|
state.initialize(instrValue, ValueKind.Immutable);
|
|
state.define(instr.lvalue, instrValue);
|
|
instr.lvalue.effect = Effect.Mutate;
|
|
continue;
|
|
}
|
|
case "ComputedLoad": {
|
|
state.reference(instrValue.object, Effect.Read);
|
|
state.reference(instrValue.property, Effect.Read);
|
|
const lvalue = instr.lvalue;
|
|
lvalue.effect = Effect.ConditionallyMutate;
|
|
state.initialize(instrValue, state.kind(instrValue.object));
|
|
state.define(lvalue, instrValue);
|
|
continue;
|
|
}
|
|
case "Await": {
|
|
state.initialize(instrValue, state.kind(instrValue.value));
|
|
/*
|
|
* Awaiting a value causes it to change state (go from unresolved to resolved or error)
|
|
* It also means that any side-effects which would occur as part of the promise evaluation
|
|
* will occur.
|
|
*/
|
|
state.reference(instrValue.value, Effect.ConditionallyMutate);
|
|
const lvalue = instr.lvalue;
|
|
lvalue.effect = Effect.ConditionallyMutate;
|
|
state.alias(lvalue, instrValue.value);
|
|
continue;
|
|
}
|
|
case "TypeCastExpression": {
|
|
/*
|
|
* A type cast expression has no effect at runtime, so it's equivalent to a raw
|
|
* identifier:
|
|
* ```
|
|
* x = (y: type) // is equivalent to...
|
|
* x = y
|
|
* ```
|
|
*/
|
|
state.initialize(instrValue, state.kind(instrValue.value));
|
|
state.reference(instrValue.value, Effect.Read);
|
|
const lvalue = instr.lvalue;
|
|
lvalue.effect = Effect.ConditionallyMutate;
|
|
state.alias(lvalue, instrValue.value);
|
|
continue;
|
|
}
|
|
case "LoadLocal": {
|
|
const lvalue = instr.lvalue;
|
|
const effect =
|
|
state.isDefined(lvalue) && state.kind(lvalue) === ValueKind.Context
|
|
? Effect.ConditionallyMutate
|
|
: Effect.Capture;
|
|
state.reference(instrValue.place, effect);
|
|
lvalue.effect = Effect.ConditionallyMutate;
|
|
// direct aliasing: `a = b`;
|
|
state.alias(lvalue, instrValue.place);
|
|
continue;
|
|
}
|
|
case "LoadContext": {
|
|
state.reference(instrValue.place, Effect.Capture);
|
|
const lvalue = instr.lvalue;
|
|
lvalue.effect = Effect.ConditionallyMutate;
|
|
const valueKind = state.kind(instrValue.place);
|
|
CompilerError.invariant(
|
|
valueKind === ValueKind.Mutable || valueKind === ValueKind.Context,
|
|
{
|
|
reason:
|
|
"[InferReferenceEffects] Context variables are always mutable.",
|
|
description: null,
|
|
loc: instrValue.loc,
|
|
suggestions: null,
|
|
}
|
|
);
|
|
state.initialize(instrValue, valueKind);
|
|
state.define(lvalue, instrValue);
|
|
continue;
|
|
}
|
|
case "DeclareLocal": {
|
|
const value = UndefinedValue;
|
|
state.initialize(
|
|
value,
|
|
// Catch params may be aliased to mutable values
|
|
instrValue.lvalue.kind === InstructionKind.Catch
|
|
? ValueKind.Mutable
|
|
: ValueKind.Immutable
|
|
);
|
|
state.define(instrValue.lvalue.place, value);
|
|
continue;
|
|
}
|
|
case "DeclareContext": {
|
|
state.initialize(instrValue, ValueKind.Mutable);
|
|
state.define(instrValue.lvalue.place, instrValue);
|
|
continue;
|
|
}
|
|
case "PostfixUpdate":
|
|
case "PrefixUpdate": {
|
|
const effect =
|
|
state.isDefined(instrValue.lvalue) &&
|
|
state.kind(instrValue.lvalue) === ValueKind.Context
|
|
? Effect.ConditionallyMutate
|
|
: Effect.Capture;
|
|
state.reference(instrValue.value, effect);
|
|
|
|
const lvalue = instr.lvalue;
|
|
state.alias(lvalue, instrValue.value);
|
|
lvalue.effect = Effect.Store;
|
|
state.alias(instrValue.lvalue, instrValue.value);
|
|
/*
|
|
* NOTE: *not* using state.reference since this is an assignment.
|
|
* reference() checks if the effect is valid given the value kind,
|
|
* but here the previous value kind doesn't matter since we are
|
|
* replacing it
|
|
*/
|
|
instrValue.lvalue.effect = Effect.Store;
|
|
continue;
|
|
}
|
|
case "StoreLocal": {
|
|
const effect =
|
|
state.isDefined(instrValue.lvalue.place) &&
|
|
state.kind(instrValue.lvalue.place) === ValueKind.Context
|
|
? Effect.ConditionallyMutate
|
|
: Effect.Capture;
|
|
state.reference(instrValue.value, effect);
|
|
|
|
const lvalue = instr.lvalue;
|
|
state.alias(lvalue, instrValue.value);
|
|
lvalue.effect = Effect.Store;
|
|
state.alias(instrValue.lvalue.place, instrValue.value);
|
|
/*
|
|
* NOTE: *not* using state.reference since this is an assignment.
|
|
* reference() checks if the effect is valid given the value kind,
|
|
* but here the previous value kind doesn't matter since we are
|
|
* replacing it
|
|
*/
|
|
instrValue.lvalue.place.effect = Effect.Store;
|
|
continue;
|
|
}
|
|
case "StoreContext": {
|
|
state.reference(instrValue.value, Effect.ConditionallyMutate);
|
|
state.reference(instrValue.lvalue.place, Effect.Mutate);
|
|
|
|
const lvalue = instr.lvalue;
|
|
state.alias(lvalue, instrValue.value);
|
|
lvalue.effect = Effect.Store;
|
|
continue;
|
|
}
|
|
case "Destructure": {
|
|
let effect: Effect = Effect.Capture;
|
|
for (const place of eachPatternOperand(instrValue.lvalue.pattern)) {
|
|
if (
|
|
state.isDefined(place) &&
|
|
state.kind(place) === ValueKind.Context
|
|
) {
|
|
effect = Effect.ConditionallyMutate;
|
|
break;
|
|
}
|
|
}
|
|
state.reference(instrValue.value, effect);
|
|
|
|
const lvalue = instr.lvalue;
|
|
state.alias(lvalue, instrValue.value);
|
|
lvalue.effect = Effect.Store;
|
|
for (const place of eachPatternOperand(instrValue.lvalue.pattern)) {
|
|
state.alias(place, instrValue.value);
|
|
/*
|
|
* NOTE: *not* using state.reference since this is an assignment.
|
|
* reference() checks if the effect is valid given the value kind,
|
|
* but here the previous value kind doesn't matter since we are
|
|
* replacing it
|
|
*/
|
|
place.effect = Effect.Store;
|
|
}
|
|
continue;
|
|
}
|
|
case "NextIterableOf": {
|
|
effectKind = Effect.Capture;
|
|
lvalueEffect = Effect.Store;
|
|
valueKind = ValueKind.Mutable;
|
|
break;
|
|
}
|
|
case "NextPropertyOf": {
|
|
effectKind = Effect.Read;
|
|
lvalueEffect = Effect.Store;
|
|
valueKind = ValueKind.Immutable;
|
|
break;
|
|
}
|
|
default: {
|
|
assertExhaustive(instrValue, "Unexpected instruction kind");
|
|
}
|
|
}
|
|
|
|
for (const operand of eachInstructionOperand(instr)) {
|
|
CompilerError.invariant(effectKind != null, {
|
|
reason: `effectKind must be set for instruction value \`${instrValue.kind}\``,
|
|
description: null,
|
|
loc: instrValue.loc,
|
|
suggestions: null,
|
|
});
|
|
state.reference(operand, effectKind);
|
|
}
|
|
|
|
state.initialize(instrValue, valueKind);
|
|
state.define(instr.lvalue, instrValue);
|
|
instr.lvalue.effect = lvalueEffect;
|
|
}
|
|
|
|
for (const operand of eachTerminalOperand(block.terminal)) {
|
|
let effect;
|
|
if (block.terminal.kind === "return" || block.terminal.kind === "throw") {
|
|
if (
|
|
state.isDefined(operand) &&
|
|
state.kind(operand) === ValueKind.Context
|
|
) {
|
|
effect = Effect.ConditionallyMutate;
|
|
} else {
|
|
effect = Effect.Freeze;
|
|
}
|
|
} else {
|
|
effect = Effect.Read;
|
|
}
|
|
state.reference(operand, effect);
|
|
}
|
|
}
|
|
|
|
function hasContextRefOperand(
|
|
state: InferenceState,
|
|
instrValue: InstructionValue
|
|
): boolean {
|
|
for (const place of eachInstructionValueOperand(instrValue)) {
|
|
if (state.isDefined(place) && state.kind(place) === ValueKind.Context) {
|
|
return true;
|
|
}
|
|
}
|
|
return false;
|
|
}
|
|
|
|
export function getFunctionCallSignature(
|
|
env: Environment,
|
|
type: Type
|
|
): FunctionSignature | null {
|
|
if (type.kind !== "Function") {
|
|
return null;
|
|
}
|
|
return env.getFunctionSignature(type);
|
|
}
|
|
|
|
/*
|
|
* Make a best attempt at matching arguments of a {@link MethodCall} to parameter effects.
|
|
* defined in its {@link FunctionSignature}.
|
|
*
|
|
* @param fn
|
|
* @param sig
|
|
* @returns Inferred effects of function arguments, or null if inference fails.
|
|
*/
|
|
function getFunctionEffects(
|
|
fn: MethodCall | CallExpression,
|
|
sig: FunctionSignature
|
|
): Array<Effect> | null {
|
|
const results = [];
|
|
for (let i = 0; i < fn.args.length; i++) {
|
|
const arg = fn.args[i];
|
|
if (i < sig.positionalParams.length) {
|
|
/*
|
|
* Only infer effects when there is a direct mapping positional arg --> positional param
|
|
* Otherwise, return null to indicate inference failed
|
|
*/
|
|
if (arg.kind === "Identifier") {
|
|
results.push(sig.positionalParams[i]);
|
|
} else {
|
|
return null;
|
|
}
|
|
} else if (sig.restParam !== null) {
|
|
results.push(sig.restParam);
|
|
} else {
|
|
/*
|
|
* If there are more arguments than positional arguments and a rest parameter is not
|
|
* defined, we'll also assume that inference failed
|
|
*/
|
|
return null;
|
|
}
|
|
}
|
|
return results;
|
|
}
|
|
|
|
/**
|
|
* Returns true if all of the arguments are both non-mutable (immutable or frozen)
|
|
* _and_ are not functions which might mutate their arguments. Note that function
|
|
* expressions count as frozen so long as they do not mutate free variables: this
|
|
* function checks that such functions also don't mutate their inputs.
|
|
*/
|
|
function areArgumentsImmutableAndNonMutating(
|
|
state: InferenceState,
|
|
args: MethodCall["args"]
|
|
): boolean {
|
|
for (const arg of args) {
|
|
const place = arg.kind === "Identifier" ? arg : arg.place;
|
|
const kind = state.kind(place);
|
|
switch (kind) {
|
|
case ValueKind.Immutable:
|
|
case ValueKind.Frozen: {
|
|
/*
|
|
* Only immutable values, or frozen lambdas are allowed.
|
|
* A lambda may appear frozen even if it may mutate its inputs,
|
|
* so we have a second check even for frozen value types
|
|
*/
|
|
break;
|
|
}
|
|
default: {
|
|
return false;
|
|
}
|
|
}
|
|
const values = state.values(place);
|
|
for (const value of values) {
|
|
if (
|
|
value.kind === "FunctionExpression" &&
|
|
value.loweredFunc.func.params.some((param) => {
|
|
const place = param.kind === "Identifier" ? param : param.place;
|
|
const range = place.identifier.mutableRange;
|
|
return range.end > range.start + 1;
|
|
})
|
|
) {
|
|
// This is a function which may mutate its inputs
|
|
return false;
|
|
}
|
|
}
|
|
}
|
|
return true;
|
|
}
|