mirror of
https://github.com/facebook/react.git
synced 2025-11-01 09:12:30 +00:00
Stacked on top of #28498 for test fixes. ### Don't Rethrow When we started React it was 1:1 setState calls a series of renders and if they error, it errors where the setState was called. Simple. However, then batching came and the error actually got thrown somewhere else. With concurrent mode, it's not even possible to get setState itself to throw anymore. In fact, all APIs that can rethrow out of React are executed either at the root of the scheduler or inside a DOM event handler. If you throw inside a React.startTransition callback that's sync, then that will bubble out of the startTransition but if you throw inside an async callback or a useTransition we now need to handle it at the hook site. So in 19 we need to make all React.startTransition swallow the error (and report them to reportError). The only one remaining that can throw is flushSync but it doesn't really make sense for it to throw at the callsite neither because batching. Just because something rendered in this flush doesn't mean it was rendered due to what was just scheduled and doesn't mean that it should abort any of the remaining code afterwards. setState is fire and forget. It's send an instruction elsewhere, it's not part of the current imperative code. Error boundaries never rethrow. Since you should really always have error boundaries, most of the time, it wouldn't rethrow anyway. Rethrowing also actually currently drops errors on the floor since we can only rethrow the first error, so to avoid that we'd need to call reportError anyway. This happens in RN events. The other issue with rethrowing is that it logs an extra console.error. Since we're not sure that user code will actually log it anywhere we still log it too just like we do with errors inside error boundaries which leads all of these to log twice. The goal of this PR is to never rethrow out of React instead, errors outside of error boundaries get logged to reportError. Event system errors too. ### Breaking Changes The main thing this affects is testing where you want to inspect the errors thrown. To make it easier to port, if you're inside `act` we track the error into act in an aggregate error and then rethrow it at the root of `act`. Unlike before though, if you flush synchronously inside of act it'll still continue until the end of act before rethrowing. I expect most user code breakages would be to migrate from `flushSync` to `act` if you assert on throwing. However, in the React repo we also have `internalAct` and the `waitForThrow` helpers. Since these have to use public production implementations we track these using the global onerror or process uncaughtException. Unlike regular act, includes both event handler errors and onRecoverableError by default too. Not just render/commit errors. So I had to account for that in our tests. We restore logging an extra log for uncaught errors after the main log with the component stack in it. We use `console.warn`. This is not yet ignorable if you preventDefault to the main error event. To avoid confusion if you don't end up logging the error to console I just added `An error occurred`. ### Polyfill All browsers we support really supports `reportError` but not all test and server environments do, so I implemented a polyfill for browser and node in `shared/reportGlobalError`. I don't love that this is included in all builds and gets duplicated into isomorphic even though it's not actually needed in production. Maybe in the future we can require a polyfill for this. ### Follow Ups In a follow up, I'll make caught vs uncaught error handling be configurable too. --------- Co-authored-by: Ricky Hanlon <rickhanlonii@gmail.com>
177 lines
6.2 KiB
JavaScript
177 lines
6.2 KiB
JavaScript
/**
|
|
* Copyright (c) Meta Platforms, Inc. and affiliates.
|
|
*
|
|
* This source code is licensed under the MIT license found in the
|
|
* LICENSE file in the root directory of this source tree.
|
|
*
|
|
* @flow strict
|
|
*/
|
|
|
|
// This version of `act` is only used by our tests. Unlike the public version
|
|
// of `act`, it's designed to work identically in both production and
|
|
// development. It may have slightly different behavior from the public
|
|
// version, too, since our constraints in our test suite are not the same as
|
|
// those of developers using React — we're testing React itself, as opposed to
|
|
// building an app with React.
|
|
|
|
import type {Thenable} from 'shared/ReactTypes';
|
|
|
|
import * as Scheduler from 'scheduler/unstable_mock';
|
|
|
|
import enqueueTask from './enqueueTask';
|
|
|
|
export let actingUpdatesScopeDepth: number = 0;
|
|
|
|
export const thrownErrors: Array<mixed> = [];
|
|
|
|
async function waitForMicrotasks() {
|
|
return new Promise(resolve => {
|
|
enqueueTask(() => resolve());
|
|
});
|
|
}
|
|
|
|
function aggregateErrors(errors: Array<mixed>): mixed {
|
|
if (errors.length > 1 && typeof AggregateError === 'function') {
|
|
// eslint-disable-next-line no-undef
|
|
return new AggregateError(errors);
|
|
}
|
|
return errors[0];
|
|
}
|
|
|
|
export async function act<T>(scope: () => Thenable<T>): Thenable<T> {
|
|
if (Scheduler.unstable_flushUntilNextPaint === undefined) {
|
|
throw Error(
|
|
'This version of `act` requires a special mock build of Scheduler.',
|
|
);
|
|
}
|
|
|
|
// $FlowFixMe[cannot-resolve-name]: Flow doesn't know about global Jest object
|
|
if (!jest.isMockFunction(setTimeout)) {
|
|
throw Error(
|
|
"This version of `act` requires Jest's timer mocks " +
|
|
'(i.e. jest.useFakeTimers).',
|
|
);
|
|
}
|
|
|
|
const previousIsActEnvironment = global.IS_REACT_ACT_ENVIRONMENT;
|
|
const previousActingUpdatesScopeDepth = actingUpdatesScopeDepth;
|
|
actingUpdatesScopeDepth++;
|
|
if (actingUpdatesScopeDepth === 1) {
|
|
// Because this is not the "real" `act`, we set this to `false` so React
|
|
// knows not to fire `act` warnings.
|
|
global.IS_REACT_ACT_ENVIRONMENT = false;
|
|
}
|
|
|
|
// Create the error object before doing any async work, to get a better
|
|
// stack trace.
|
|
const error = new Error();
|
|
Error.captureStackTrace(error, act);
|
|
|
|
// Call the provided scope function after an async gap. This is an extra
|
|
// precaution to ensure that our tests do not accidentally rely on the act
|
|
// scope adding work to the queue synchronously. We don't do this in the
|
|
// public version of `act`, though we maybe should in the future.
|
|
await waitForMicrotasks();
|
|
|
|
const errorHandlerDOM = function (event: ErrorEvent) {
|
|
// Prevent logs from reprinting this error.
|
|
event.preventDefault();
|
|
thrownErrors.push(event.error);
|
|
};
|
|
const errorHandlerNode = function (err: mixed) {
|
|
thrownErrors.push(err);
|
|
};
|
|
// We track errors that were logged globally as if they occurred in this scope and then rethrow them.
|
|
if (actingUpdatesScopeDepth === 1) {
|
|
if (
|
|
typeof window === 'object' &&
|
|
typeof window.addEventListener === 'function'
|
|
) {
|
|
// We're in a JS DOM environment.
|
|
window.addEventListener('error', errorHandlerDOM);
|
|
} else if (typeof process === 'object') {
|
|
// Node environment
|
|
process.on('uncaughtException', errorHandlerNode);
|
|
}
|
|
}
|
|
|
|
try {
|
|
const result = await scope();
|
|
|
|
do {
|
|
// Wait until end of current task/microtask.
|
|
await waitForMicrotasks();
|
|
|
|
// $FlowFixMe[cannot-resolve-name]: Flow doesn't know about global Jest object
|
|
if (jest.isEnvironmentTornDown()) {
|
|
error.message =
|
|
'The Jest environment was torn down before `act` completed. This ' +
|
|
'probably means you forgot to `await` an `act` call.';
|
|
throw error;
|
|
}
|
|
|
|
if (!Scheduler.unstable_hasPendingWork()) {
|
|
// $FlowFixMe[cannot-resolve-name]: Flow doesn't know about global Jest object
|
|
const j = jest;
|
|
if (j.getTimerCount() > 0) {
|
|
// There's a pending timer. Flush it now. We only do this in order to
|
|
// force Suspense fallbacks to display; the fact that it's a timer
|
|
// is an implementation detail. If there are other timers scheduled,
|
|
// those will also fire now, too, which is not ideal. (The public
|
|
// version of `act` doesn't do this.) For this reason, we should try
|
|
// to avoid using timers in our internal tests.
|
|
j.runOnlyPendingTimers();
|
|
// If a committing a fallback triggers another update, it might not
|
|
// get scheduled until a microtask. So wait one more time.
|
|
await waitForMicrotasks();
|
|
}
|
|
if (Scheduler.unstable_hasPendingWork()) {
|
|
// Committing a fallback scheduled additional work. Continue flushing.
|
|
} else {
|
|
// There's no pending work, even after both the microtask queue
|
|
// and the timer queue are empty. Stop flushing.
|
|
break;
|
|
}
|
|
}
|
|
// flushUntilNextPaint stops when React yields execution. Allow microtasks
|
|
// queue to flush before continuing.
|
|
Scheduler.unstable_flushUntilNextPaint();
|
|
} while (true);
|
|
|
|
if (thrownErrors.length > 0) {
|
|
// Rethrow any errors logged by the global error handling.
|
|
const thrownError = aggregateErrors(thrownErrors);
|
|
thrownErrors.length = 0;
|
|
throw thrownError;
|
|
}
|
|
|
|
return result;
|
|
} finally {
|
|
const depth = actingUpdatesScopeDepth;
|
|
if (depth === 1) {
|
|
if (
|
|
typeof window === 'object' &&
|
|
typeof window.addEventListener === 'function'
|
|
) {
|
|
// We're in a JS DOM environment.
|
|
window.removeEventListener('error', errorHandlerDOM);
|
|
} else if (typeof process === 'object') {
|
|
// Node environment
|
|
process.off('uncaughtException', errorHandlerNode);
|
|
}
|
|
global.IS_REACT_ACT_ENVIRONMENT = previousIsActEnvironment;
|
|
}
|
|
actingUpdatesScopeDepth = depth - 1;
|
|
|
|
if (actingUpdatesScopeDepth !== previousActingUpdatesScopeDepth) {
|
|
// if it's _less than_ previousActingUpdatesScopeDepth, then we can
|
|
// assume the 'other' one has warned
|
|
Scheduler.unstable_clearLog();
|
|
error.message =
|
|
'You seem to have overlapping act() calls, this is not supported. ' +
|
|
'Be sure to await previous act() calls before making a new one. ';
|
|
throw error;
|
|
}
|
|
}
|
|
}
|