mirror of
https://github.com/facebook/react.git
synced 2025-11-01 09:12:30 +00:00
62cd5af08e
Prior to #26347, our internal `act` API (not the public API) behaved differently depending on whether the scope function returned a promise (i.e. was an async function), for historical reasons that no longer apply. Now that this is fixed, I've codemodded all async act scopes that don't contain an await to be sync. No pressing motivation other than it looks nicer and the codemod was easy. Might help avoid confusion for new contributors who see async act scopes with nothing async inside and infer it must be like that for a reason.
101 lines
2.4 KiB
JavaScript
101 lines
2.4 KiB
JavaScript
/**
|
|
* Copyright (c) Meta Platforms, Inc. and affiliates.
|
|
*
|
|
* This source code is licensed under the MIT license found in the
|
|
* LICENSE file in the root directory of this source tree.
|
|
*
|
|
* @emails react-core
|
|
*/
|
|
|
|
'use strict';
|
|
|
|
let React;
|
|
|
|
let ReactDOMClient;
|
|
let act;
|
|
|
|
describe('ReactDOMSafariMicrotaskBug-test', () => {
|
|
let container;
|
|
let flushMicrotasksPrematurely;
|
|
|
|
beforeEach(() => {
|
|
// In Safari, microtasks don't always run on clean stack.
|
|
// This setup crudely approximates it.
|
|
// In reality, the sync flush happens when an iframe is added to the page.
|
|
// https://github.com/facebook/react/issues/22459
|
|
let queue = [];
|
|
window.queueMicrotask = function (cb) {
|
|
queue.push(cb);
|
|
};
|
|
flushMicrotasksPrematurely = function () {
|
|
while (queue.length > 0) {
|
|
const prevQueue = queue;
|
|
queue = [];
|
|
prevQueue.forEach(cb => cb());
|
|
}
|
|
};
|
|
|
|
jest.resetModules();
|
|
container = document.createElement('div');
|
|
React = require('react');
|
|
ReactDOMClient = require('react-dom/client');
|
|
act = require('internal-test-utils').act;
|
|
|
|
document.body.appendChild(container);
|
|
});
|
|
|
|
afterEach(() => {
|
|
document.body.removeChild(container);
|
|
});
|
|
|
|
it('should deal with premature microtask in commit phase', async () => {
|
|
let ran = false;
|
|
function Foo() {
|
|
const [state, setState] = React.useState(0);
|
|
return (
|
|
<div
|
|
ref={() => {
|
|
if (!ran) {
|
|
ran = true;
|
|
setState(1);
|
|
flushMicrotasksPrematurely();
|
|
}
|
|
}}>
|
|
{state}
|
|
</div>
|
|
);
|
|
}
|
|
const root = ReactDOMClient.createRoot(container);
|
|
await act(() => {
|
|
root.render(<Foo />);
|
|
});
|
|
expect(container.textContent).toBe('1');
|
|
});
|
|
|
|
it('should deal with premature microtask in event handler', async () => {
|
|
function Foo() {
|
|
const [state, setState] = React.useState(0);
|
|
return (
|
|
<button
|
|
onClick={() => {
|
|
setState(1);
|
|
flushMicrotasksPrematurely();
|
|
}}>
|
|
{state}
|
|
</button>
|
|
);
|
|
}
|
|
const root = ReactDOMClient.createRoot(container);
|
|
await act(() => {
|
|
root.render(<Foo />);
|
|
});
|
|
expect(container.textContent).toBe('0');
|
|
await act(() => {
|
|
container.firstChild.dispatchEvent(
|
|
new MouseEvent('click', {bubbles: true}),
|
|
);
|
|
});
|
|
expect(container.textContent).toBe('1');
|
|
});
|
|
});
|