react

mirror of https://github.com/facebook/react.git synced 2025-11-01 09:12:30 +00:00

Files

T

Mofei Zhang 5d12e9e10b [compiler] repro for dep merging edge case (non-hir)

Found when writing #31037, summary copied from comments:

This is an extreme edge case and not code we'd expect any reasonable developer to write. In most cases e.g. `(a?.b != null ? a.b : DEFAULT)`, we do want to take a dependency on `a?.b`.

I found this trying to come up with edge cases that break the current dependency + CFG merging logic. I think it makes sense to error on the side of correctness. After all, we still take `a` as a dependency if users write `a != null ? a.b : DEFAULT`, and the same fix (understanding the `<hoistable> != null` test expression) works for both. Can be convinced otherwise though!

ghstack-source-id: cc06afda59
Pull Request resolved: https://github.com/facebook/react/pull/31035

2024-09-30 12:35:16 -04:00

__tests__

[compiler] repro for dep merging edge case (non-hir)

2024-09-30 12:35:16 -04:00

Babel

Compiler: unfork prettier config (#30205 )

2024-07-18 17:00:24 -04:00

Entrypoint

[compiler] Allow ReactElement symbol to be configured when inlining jsx (#30996 )

2024-09-19 10:34:24 -04:00

HIR

[compiler][hir-rewrite] Cleanup Identifier -> IdentifierId