mirror of https://github.com/facebook/react.git synced 2025-11-01 09:12:30 +00:00

Files

T

Sebastian Silbermann 86c8c8db79 test: Don't retry flushActWork if flushUntilNextPaint threw (#26121 )

## Summary

Fixes "ReferenceError: You are trying to access a property or method of
the Jest environment after it has been torn down." in
`ReactIncrementalErrorHandling-test.internal.js`

Alternatives:

1. Additional `await act(cb)` call where `cb` makes sure we can flush
until next paint without throwing
    ```js
    // Ensure test isn't exited with pending work
    await act(async () => {
      root.render(<App shouldThrow={false} />);
    });
    ```
1. Use `toFlushAndThrow`
    ```diff
    -    let error;
    -    try {
    -      await act(async () => {
    -        root.render(<App shouldThrow={true} />);
    -      });
    -    } catch (e) {
    -      error = e;
    -    }
    +    root.render(<App shouldThrow={true} />);
     
    -    expect(error.message).toBe('Oops!');
    +    expect(Scheduler).toFlushAndThrow('Oops!');
         expect(numberOfThrows < 100).toBe(true);
    ```

But then it still wouldn't make sense to pass `resolve` and `reject` to
the next `flushActWork`. Even if the next `flushActWork` would flush
until next paint without throwing, we couldn't resolve or reject because
we already did reject.
 

## How did you test this change?

- `yarn test --watch
packages/react-reconciler/src/__tests__/ReactIncrementalErrorHandling-test.internal.js`
produces no more errors after the test finishes.

2023-02-13 21:45:59 +01:00

npm

Jest + test renderer helpers for concurrent mode (#13751 )

2018-10-03 18:37:41 -06:00

src

test: Don't retry flushActWork if flushUntilNextPaint threw (#26121 )

2023-02-13 21:45:59 +01:00

index.js

[Codemod] Update copyright header to Meta (#25315 )

2022-10-18 11:19:24 -04:00

package.json

Update to Jest 29 (#26088 )