mirror of
https://github.com/facebook/react.git
synced 2025-11-01 09:12:30 +00:00
2b1fb91a55
Hermes parser is the preferred parser for Flow code going forward. We need to upgrade to this parser to support new Flow syntax like function `this` context type annotations or `ObjectType['prop']` syntax. Unfortunately, there's quite a few upgrades here to make it work somehow (dependencies between the changes) - ~Upgrade `eslint` to `8.*`~ reverted this as the React eslint plugin tests depend on the older version and there's a [yarn bug](https://github.com/yarnpkg/yarn/issues/6285) that prevents `devDependencies` and `peerDependencies` to different versions. - Remove `eslint-config-fbjs` preset dependency and inline the rules, imho this makes it a lot clearer what the rules are. - Remove the turned off `jsx-a11y/*` rules and it's dependency instead of inlining those from the `fbjs` config. - Update parser and dependency from `babel-eslint` to `hermes-eslint`. - `ft-flow/no-unused-expressions` rule replaces `no-unused-expressions` which now allows standalone type asserts, e.g. `(foo: number);` - Bunch of globals added to the eslint config - Disabled `no-redeclare`, seems like the eslint upgrade started making this more precise and warn against re-defined globals like `__EXPERIMENTAL__` (in rollup scripts) or `fetch` (when importing fetch from node-fetch). - Minor lint fixes like duplicate keys in objects.
153 lines
3.9 KiB
JavaScript
153 lines
3.9 KiB
JavaScript
/**
|
|
* Copyright (c) Meta Platforms, Inc. and affiliates.
|
|
*
|
|
* This source code is licensed under the MIT license found in the
|
|
* LICENSE file in the root directory of this source tree.
|
|
*
|
|
* @flow
|
|
*/
|
|
|
|
describe('Profiler change descriptions', () => {
|
|
let React;
|
|
let legacyRender;
|
|
let store;
|
|
let utils;
|
|
|
|
beforeEach(() => {
|
|
utils = require('./utils');
|
|
utils.beforeEachProfiling();
|
|
|
|
legacyRender = utils.legacyRender;
|
|
|
|
store = global.store;
|
|
store.collapseNodesByDefault = false;
|
|
store.recordChangeDescriptions = true;
|
|
|
|
React = require('react');
|
|
});
|
|
|
|
// @reactVersion >=18.0
|
|
it('should identify useContext as the cause for a re-render', () => {
|
|
const Context = React.createContext(0);
|
|
|
|
function Child() {
|
|
const context = React.useContext(Context);
|
|
return context;
|
|
}
|
|
|
|
function areEqual() {
|
|
return true;
|
|
}
|
|
|
|
const MemoizedChild = React.memo(Child, areEqual);
|
|
const ForwardRefChild = React.forwardRef(function RefForwardingComponent(
|
|
props,
|
|
ref,
|
|
) {
|
|
return <Child />;
|
|
});
|
|
|
|
let forceUpdate = null;
|
|
|
|
const App = function App() {
|
|
const [val, dispatch] = React.useReducer(x => x + 1, 0);
|
|
|
|
forceUpdate = dispatch;
|
|
|
|
return (
|
|
<Context.Provider value={val}>
|
|
<Child />
|
|
<MemoizedChild />
|
|
<ForwardRefChild />
|
|
</Context.Provider>
|
|
);
|
|
};
|
|
|
|
const container = document.createElement('div');
|
|
|
|
utils.act(() => store.profilerStore.startProfiling());
|
|
utils.act(() => legacyRender(<App />, container));
|
|
utils.act(() => forceUpdate());
|
|
utils.act(() => store.profilerStore.stopProfiling());
|
|
|
|
const rootID = store.roots[0];
|
|
const commitData = store.profilerStore.getCommitData(rootID, 1);
|
|
|
|
expect(store).toMatchInlineSnapshot(`
|
|
[root]
|
|
▾ <App>
|
|
▾ <Context.Provider>
|
|
<Child>
|
|
▾ <Child> [Memo]
|
|
<Child>
|
|
▾ <RefForwardingComponent> [ForwardRef]
|
|
<Child>
|
|
`);
|
|
|
|
let element = store.getElementAtIndex(2);
|
|
expect(element.displayName).toBe('Child');
|
|
expect(element.hocDisplayNames).toBeNull();
|
|
expect(commitData.changeDescriptions.get(element.id))
|
|
.toMatchInlineSnapshot(`
|
|
Object {
|
|
"context": true,
|
|
"didHooksChange": false,
|
|
"hooks": null,
|
|
"isFirstMount": false,
|
|
"props": Array [],
|
|
"state": null,
|
|
}
|
|
`);
|
|
|
|
element = store.getElementAtIndex(3);
|
|
expect(element.displayName).toBe('Child');
|
|
expect(element.hocDisplayNames).toEqual(['Memo']);
|
|
expect(commitData.changeDescriptions.get(element.id)).toBeUndefined();
|
|
|
|
element = store.getElementAtIndex(4);
|
|
expect(element.displayName).toBe('Child');
|
|
expect(element.hocDisplayNames).toBeNull();
|
|
expect(commitData.changeDescriptions.get(element.id))
|
|
.toMatchInlineSnapshot(`
|
|
Object {
|
|
"context": true,
|
|
"didHooksChange": false,
|
|
"hooks": null,
|
|
"isFirstMount": false,
|
|
"props": Array [],
|
|
"state": null,
|
|
}
|
|
`);
|
|
|
|
element = store.getElementAtIndex(5);
|
|
expect(element.displayName).toBe('RefForwardingComponent');
|
|
expect(element.hocDisplayNames).toEqual(['ForwardRef']);
|
|
expect(commitData.changeDescriptions.get(element.id))
|
|
.toMatchInlineSnapshot(`
|
|
Object {
|
|
"context": null,
|
|
"didHooksChange": false,
|
|
"hooks": null,
|
|
"isFirstMount": false,
|
|
"props": Array [],
|
|
"state": null,
|
|
}
|
|
`);
|
|
|
|
element = store.getElementAtIndex(6);
|
|
expect(element.displayName).toBe('Child');
|
|
expect(element.hocDisplayNames).toBeNull();
|
|
expect(commitData.changeDescriptions.get(element.id))
|
|
.toMatchInlineSnapshot(`
|
|
Object {
|
|
"context": true,
|
|
"didHooksChange": false,
|
|
"hooks": null,
|
|
"isFirstMount": false,
|
|
"props": Array [],
|
|
"state": null,
|
|
}
|
|
`);
|
|
});
|
|
});
|