mirror of
https://github.com/facebook/react.git
synced 2025-11-01 09:12:30 +00:00
Flarnie Marchan
207f3ef457
**what is the change?:** We ran the latest version of `addons/create-react-class/create-react-class.js` through https://jscompress.com/ **why make this change?:** The last corner case I'm thinking of is this: - The `createClass` deprecation warning never went out in 15.5, and is going out now for real in 15.6. - The `createClass` UMD build is broken for AMD/CommonJS, but we fixed it. But not for the minified version of the file. - If someone see the warning, and tries to use the UMD build, then it's going to be broken in some cases. - Since we're skipping mentioning the add-ons in the blog post, and this might be a new warning for them, this could be a nasty surprise for folks. We can do a quick 15.5.4 release of that package, we would at least fix that case. This diverges from what @gaearon is doing to fix the add-ons. I would probably try to use cherry-pick and interactive rebase to move this commit to right after https://github.com/facebook/react/commit/ce3ecfb1dfaacb311fb4b37eede56c2667014cfc and then do the patch release of `create-react-class` from that spot in history. Alternately I can merge this into the forked branch `15.6-before-addon-reconstruction` and then do the patch release from there. **test plan:** I didn't test this. Ideally minifying this file won't break anything, and it's high cost to test add-ons until we have some repeatable tests in place. **issue:** https://github.com/facebook/react/issues/9765
create-react-class
A drop-in replacement for React.createClass.
Refer to the React documentation for more information.