mirror of https://github.com/facebook/react.git synced 2025-11-01 09:12:30 +00:00

Files

T

Sebastian Markbåge f38c22b244 [Flight] Set Current Owner / Task When Calling console.error or invoking onError/onPostpone (#30206 )

Stacked on #30197.

This is similar to #30182 and #21610 in Fizz.

Track the current owner/stack/task on the task. This tracks it for
attribution when serializing child properties.

This lets us provide the right owner and createTask when we
console.error from inside Flight itself. This also affects the way we
print those logs on the client since we need the owner and stack. Now
console.errors that originate on the server gets the right stack on the
client:

Unfortunately, because we don't track the stack we never pop it so it'll
keep tracking for serializing sibling properties. We rely on "children"
typically being the last property in the common case anyway. However,
this can lead to wrong attribution in some cases where the invalid
property is a next property (without a wrapping element) and there's a
previous element that doesn't. E.g. `<ClientComponent title={<div />}
invalid={nonSerializable} />` would use the div as the attribution
instead of ClientComponent.

I also wrap all of our own console.error, onError and onPostpone in the
context of the parent component. It's annoying to have to remember to do
this though.

We could always wrap the whole rendering in such as context but it would
add more overhead since this rarely actually happens. It might make
sense to track the whole current task instead to lower the overhead.
That's what we do in Fizz. We'd still have to remember to restore the
debug task though. I realize now Fizz doesn't do that neither so the
debug task isn't wrapping the console.errors that Fizz itself logs.
There's something off about that Flight and Fizz implementations don't
perfectly align.

2024-07-04 12:31:23 -04:00

npm

Don't minify symbols in production builds (#28881 )

2024-04-20 11:23:46 -04:00

src

[Flight] Set Current Owner / Task When Calling console.error or invoking onError/onPostpone (#30206 )

2024-07-04 12:31:23 -04:00

flight.js

Remove Flight Relay DOM/Native (#26828 )

2023-05-17 20:33:25 -04:00

package.json

Remove loose-envify dep and browserify configs (#28480 )