mirror of
https://github.com/facebook/react.git
synced 2025-11-01 09:12:30 +00:00
e5287287aa
Stacked on https://github.com/facebook/react/pull/28351, please review only the last commit. Top-level description of the approach: 1. Once user selects an element from the tree, frontend asks backend to return the inspected element, this is where we simulate an error happening in `render` function of the component and then we parse the error stack. As an improvement, we should probably migrate from custom implementation of error stack parser to `error-stack-parser` from npm. 2. When frontend receives the inspected element and this object is being propagated, we create a Promise for symbolicated source, which is then passed down to all components, which are using `source`. 3. These components use `use` hook for this promise and are wrapped in Suspense. Caching: 1. For browser extension, we cache Promises based on requested resource + key + column, also added use of `chrome.devtools.inspectedWindow.getResource` API. 2. For standalone case (RN), we cache based on requested resource url, we cache the content of it.
133 lines
3.8 KiB
JavaScript
133 lines
3.8 KiB
JavaScript
/**
|
|
* Copyright (c) Meta Platforms, Inc. and affiliates.
|
|
*
|
|
* This source code is licensed under the MIT license found in the
|
|
* LICENSE file in the root directory of this source tree.
|
|
*
|
|
* @flow
|
|
*/
|
|
|
|
import * as React from 'react';
|
|
import {copy} from 'clipboard-js';
|
|
import {toNormalUrl} from 'jsc-safe-url';
|
|
|
|
import Button from '../Button';
|
|
import ButtonIcon from '../ButtonIcon';
|
|
import Skeleton from './Skeleton';
|
|
|
|
import type {Source as InspectedElementSource} from 'react-devtools-shared/src/shared/types';
|
|
import styles from './InspectedElementSourcePanel.css';
|
|
|
|
type Props = {
|
|
source: InspectedElementSource,
|
|
symbolicatedSourcePromise: Promise<InspectedElementSource | null>,
|
|
};
|
|
|
|
function InspectedElementSourcePanel({
|
|
source,
|
|
symbolicatedSourcePromise,
|
|
}: Props): React.Node {
|
|
return (
|
|
<div className={styles.Source} data-testname="InspectedElementView-Source">
|
|
<div className={styles.SourceHeaderRow}>
|
|
<div className={styles.SourceHeader}>source</div>
|
|
|
|
<React.Suspense fallback={<Skeleton height={16} width={16} />}>
|
|
<CopySourceButton
|
|
source={source}
|
|
symbolicatedSourcePromise={symbolicatedSourcePromise}
|
|
/>
|
|
</React.Suspense>
|
|
</div>
|
|
|
|
<React.Suspense
|
|
fallback={
|
|
<div className={styles.SourceOneLiner}>
|
|
<Skeleton height={16} width="40%" />
|
|
</div>
|
|
}>
|
|
<FormattedSourceString
|
|
source={source}
|
|
symbolicatedSourcePromise={symbolicatedSourcePromise}
|
|
/>
|
|
</React.Suspense>
|
|
</div>
|
|
);
|
|
}
|
|
|
|
function CopySourceButton({source, symbolicatedSourcePromise}: Props) {
|
|
const symbolicatedSource = React.use(symbolicatedSourcePromise);
|
|
if (symbolicatedSource == null) {
|
|
const {sourceURL, line, column} = source;
|
|
const handleCopy = () => copy(`${sourceURL}:${line}:${column}`);
|
|
|
|
return (
|
|
<Button onClick={handleCopy} title="Copy to clipboard">
|
|
<ButtonIcon type="copy" />
|
|
</Button>
|
|
);
|
|
}
|
|
|
|
const {sourceURL, line, column} = symbolicatedSource;
|
|
const handleCopy = () => copy(`${sourceURL}:${line}:${column}`);
|
|
|
|
return (
|
|
<Button onClick={handleCopy} title="Copy to clipboard">
|
|
<ButtonIcon type="copy" />
|
|
</Button>
|
|
);
|
|
}
|
|
|
|
function FormattedSourceString({source, symbolicatedSourcePromise}: Props) {
|
|
const symbolicatedSource = React.use(symbolicatedSourcePromise);
|
|
if (symbolicatedSource == null) {
|
|
const {sourceURL, line} = source;
|
|
|
|
return (
|
|
<div className={styles.SourceOneLiner}>
|
|
{formatSourceForDisplay(sourceURL, line)}
|
|
</div>
|
|
);
|
|
}
|
|
|
|
const {sourceURL, line} = symbolicatedSource;
|
|
|
|
return (
|
|
<div className={styles.SourceOneLiner}>
|
|
{formatSourceForDisplay(sourceURL, line)}
|
|
</div>
|
|
);
|
|
}
|
|
|
|
// This function is based on describeComponentFrame() in packages/shared/ReactComponentStackFrame
|
|
function formatSourceForDisplay(sourceURL: string, line: number) {
|
|
// Metro can return JSC-safe URLs, which have `//&` as a delimiter
|
|
// https://www.npmjs.com/package/jsc-safe-url
|
|
const sanitizedSourceURL = sourceURL.includes('//&')
|
|
? toNormalUrl(sourceURL)
|
|
: sourceURL;
|
|
|
|
// Note: this RegExp doesn't work well with URLs from Metro,
|
|
// which provides bundle URL with query parameters prefixed with /&
|
|
const BEFORE_SLASH_RE = /^(.*)[\\\/]/;
|
|
|
|
let nameOnly = sanitizedSourceURL.replace(BEFORE_SLASH_RE, '');
|
|
|
|
// In DEV, include code for a common special case:
|
|
// prefer "folder/index.js" instead of just "index.js".
|
|
if (/^index\./.test(nameOnly)) {
|
|
const match = sanitizedSourceURL.match(BEFORE_SLASH_RE);
|
|
if (match) {
|
|
const pathBeforeSlash = match[1];
|
|
if (pathBeforeSlash) {
|
|
const folderName = pathBeforeSlash.replace(BEFORE_SLASH_RE, '');
|
|
nameOnly = folderName + '/' + nameOnly;
|
|
}
|
|
}
|
|
}
|
|
|
|
return `${nameOnly}:${line}`;
|
|
}
|
|
|
|
export default InspectedElementSourcePanel;
|