Files
react/packages/react-devtools-shared/src/devtools/views/Components/SelectedTreeHighlight.js
T
Ruslan Lesiutin 77ec61885f fix[devtools/inspectElement]: dont pause initial inspectElement call when user switches tabs (#27488)
There are not so many changes, most of them are changing imports,
because I've moved types for UI in a single file.

In https://github.com/facebook/react/pull/27357 I've added support for
pausing polling events: when user inspects an element, we start polling
React DevTools backend for updates in props / state. If user switches
tabs, extension's service worker can be killed by browser and this
polling will start spamming errors.

What I've missed is that we also have a separate call for this API, but
which is executed only once when user selects an element. We don't
handle promise rejection here and this can lead to some errors when user
selects an element and switches tabs right after it.

The only change here is that this API now has
`shouldListenToPauseEvents` param, which is `true` for polling, so we
will pause polling once user switches tabs. It is `false` by default, so
we won't pause initial call by accident.


https://github.com/hoxyq/react/blob/af8beeebf63b5824497fcd0bb35b7c0ac8fe60a0/packages/react-devtools-shared/src/backendAPI.js#L96
2023-10-10 18:10:17 +01:00

111 lines
2.9 KiB
JavaScript

/**
* Copyright (c) Meta Platforms, Inc. and affiliates.
*
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*
* @flow
*/
import type {Element} from 'react-devtools-shared/src/frontend/types';
import * as React from 'react';
import {useContext, useMemo} from 'react';
import {TreeStateContext} from './TreeContext';
import {SettingsContext} from '../Settings/SettingsContext';
import TreeFocusedContext from './TreeFocusedContext';
import {StoreContext} from '../context';
import {useSubscription} from '../hooks';
import styles from './SelectedTreeHighlight.css';
type Data = {
startIndex: number,
stopIndex: number,
};
export default function SelectedTreeHighlight(_: {}): React.Node {
const {lineHeight} = useContext(SettingsContext);
const store = useContext(StoreContext);
const treeFocused = useContext(TreeFocusedContext);
const {ownerID, selectedElementID} = useContext(TreeStateContext);
const subscription = useMemo(
() => ({
getCurrentValue: () => {
if (
selectedElementID === null ||
store.isInsideCollapsedSubTree(selectedElementID)
) {
return null;
}
const element = store.getElementByID(selectedElementID);
if (
element === null ||
element.isCollapsed ||
element.children.length === 0
) {
return null;
}
const startIndex = store.getIndexOfElementID(element.children[0]);
if (startIndex === null) {
return null;
}
let stopIndex = null;
let current: null | Element = element;
while (current !== null) {
if (current.isCollapsed || current.children.length === 0) {
// We've found the last/deepest descendant.
stopIndex = store.getIndexOfElementID(current.id);
current = null;
} else {
const lastChildID = current.children[current.children.length - 1];
current = store.getElementByID(lastChildID);
}
}
if (stopIndex === null) {
return null;
}
return {
startIndex,
stopIndex,
};
},
subscribe: (callback: Function) => {
store.addListener('mutated', callback);
return () => {
store.removeListener('mutated', callback);
};
},
}),
[selectedElementID, store],
);
const data = useSubscription<Data | null>(subscription);
if (ownerID !== null) {
return null;
}
if (data === null) {
return null;
}
const {startIndex, stopIndex} = data;
return (
<div
className={treeFocused ? styles.Active : styles.Inactive}
style={{
position: 'absolute',
top: `${startIndex * lineHeight}px`,
height: `${(stopIndex + 1 - startIndex) * lineHeight}px`,
}}
/>
);
}