react

mirror of https://github.com/facebook/react.git synced 2025-11-01 09:12:30 +00:00

Files

T

History

Mofei Zhang 78856eff76 [compiler][bugfix] Avoid inserting duplicate context variable declarations

(note: also see alternative implementation in https://github.com/facebook/react/pull/32747)

`PruneHoistedContexts` currently strips hoisted declarations and rewrites the first `StoreContext` reassignment to a declaration. For example, in the following example, instruction 0 is removed while a synthetic `DeclareContext let` is inserted before instruction 1.

```js
// source
const cb = () => x; // reference that causes x to be hoisted

let x = 4;
x = 5;

// React Compiler IR
[0] DeclareContext HoistedLet 'x'
...
[1] StoreContext reassign 'x' = 4
[2] StoreContext reassign 'x' = 5
```

Currently, we don't account for `DeclareContext let`. As a result, we're rewriting to insert duplicate declarations.
For the below example, we should only remove instruction 0 (no need to insert a DeclareContext `let` since one is already present).
```js
// source
const cb = () => x; // reference that causes x to be hoisted

let x;
x = 5;

// React Compiler IR
[0] DeclareContext HoistedLet 'x'
...
[1] DeclareContext Let 'x'
[2] StoreContext reassign 'x' = 5
```

2025-03-25 14:34:09 -04:00

babel-plugin-react-compiler

[compiler][bugfix] Avoid inserting duplicate context variable declarations

2025-03-25 14:34:09 -04:00

eslint-plugin-react-compiler

[eslint-plugin-react-compiler] Fix type error with recommended config (#32666 )

2025-03-19 14:58:08 -04:00

make-read-only-util

[compiler] Migrate compiler packages to tsup (#32550 )

2025-03-07 16:41:55 -05:00

react-compiler-healthcheck

fix: clarify which mobx libs are not compatible with compiler (#32570 )