mirror of
https://github.com/facebook/react.git
synced 2025-11-01 09:12:30 +00:00
laurenandGitHub
eda36a1c75
Randomly noticed this when I looked at a recent [DevTools regression test run](https://github.com/facebook/react/actions/runs/13578385011). I don't recall why we added `continue-on-error` previously, but I believe it was to keep all jobs in the matrix running even if one were to fail, in order to fully identify any failures from code changes like build or test failures. There is now a `fail-fast` option which does this. [`continue-on-error`](https://docs.github.com/en/actions/writing-workflows/workflow-syntax-for-github-actions#jobsjob_idcontinue-on-error) now means: > Prevents a workflow run from failing when a job fails. Set to true to allow a workflow run to pass when this job fails. so it's not correct to use it.
57 lines
1.6 KiB
YAML
57 lines
1.6 KiB
YAML
name: (Runtime) ESLint Plugin E2E
|
|
|
|
on:
|
|
push:
|
|
branches: [main]
|
|
pull_request:
|
|
paths-ignore:
|
|
- compiler/**
|
|
|
|
concurrency:
|
|
group: ${{ github.workflow }}-${{ github.ref_name }}-${{ github.event.pull_request.number || github.run_id }}
|
|
cancel-in-progress: true
|
|
|
|
env:
|
|
TZ: /usr/share/zoneinfo/America/Los_Angeles
|
|
|
|
jobs:
|
|
# ----- TESTS -----
|
|
test:
|
|
name: ESLint v${{ matrix.eslint_major }}
|
|
runs-on: ubuntu-latest
|
|
strategy:
|
|
fail-fast: false
|
|
matrix:
|
|
eslint_major:
|
|
- "6"
|
|
- "7"
|
|
- "8"
|
|
- "9"
|
|
steps:
|
|
- uses: actions/checkout@v4
|
|
with:
|
|
ref: ${{ github.event.pull_request.head.sha || github.sha }}
|
|
- uses: actions/setup-node@v4
|
|
with:
|
|
node-version-file: '.nvmrc'
|
|
cache: yarn
|
|
cache-dependency-path: yarn.lock
|
|
- name: Restore cached node_modules
|
|
uses: actions/cache@v4
|
|
id: node_modules
|
|
with:
|
|
path: "node_modules"
|
|
key: runtime-eslint_e2e-node_modules-${{ runner.arch }}-${{ runner.os }}-${{ hashFiles('yarn.lock') }}
|
|
- name: Ensure clean build directory
|
|
run: rm -rf build
|
|
- run: yarn install --frozen-lockfile
|
|
- name: Build plugin
|
|
working-directory: fixtures/eslint-v${{ matrix.eslint_major }}
|
|
run: node build.mjs
|
|
- name: Install fixture dependencies
|
|
working-directory: ./fixtures/eslint-v${{ matrix.eslint_major }}
|
|
run: yarn --frozen-lockfile
|
|
- name: Run lint test
|
|
working-directory: ./fixtures/eslint-v${{ matrix.eslint_major }}
|
|
run: yarn lint
|