mirror of https://github.com/facebook/react.git synced 2025-11-01 09:12:30 +00:00

Files

T

History

Dustin Masters c35a1e7483 Fix crash during server render in react 16.4.1. (#13088 )

* Fix crash during server render.

setTimeout and clearTimeout may not be available in some server-render environments (such as ChakraCore in React.NET), and loading ReactScheduler.js will cause a crash unless the existence of the variables are checked via a typeof comparison.

https://github.com/reactjs/React.NET/issues/555

The crash did not occur in 16.4.0, and the change appears to have been introduced here: https://github.com/facebook/react/pull/12931/files#diff-bbebc3357e1fb99ab13ad796e04b69a6L47

I tested this by using yarn link and running it with a local copy of React.NET. I am unsure the best way to unit test this change, since assigning null to `setTimeout` causes an immediate crash within the Node REPL.

* Fix flow errors and log warning if setTimeout / clearTimeout are
not defined / not a function.

* Use invariant to assert setTimeout / clearTimeout are functions

* Remove use of invariant

* Explain

2018-06-22 20:07:54 +01:00

npm

Initial commit (#12624 )

2018-04-19 09:29:08 -07:00

src

Fix crash during server render in react 16.4.1. (#13088 )

2018-06-22 20:07:54 +01:00

index.js

Initial commit (#12624 )

2018-04-19 09:29:08 -07:00

package.json

Remove fbjs dependency (#13069 )