Facebook/react
1
0 Fork 0
mirror of https://github.com/facebook/react.git synced 2025-11-01 09:12:30 +00:00
Code Issues Packages Projects Releases Wiki Activity
523 Commits 681 Branches 148 Tags
fb8ad3486e70aa96d3e183db90b79bd915f474a5
Commit Graph
421 Commits
Author SHA1 Message Date
Dan fb8ad3486e Don't reorder a single child 2019-04-19 13:19:58 +01:00
Dan efb5855c8c Nits 2019-04-19 13:17:17 +01:00
Dan 3e657a6031 Prettier 2019-04-19 13:09:25 +01:00
Dan Abramov 37dd1ec8f8 Merge branch 'master' into more-suspensey-stuff 2019-04-19 13:09:01 +01:00
Brian Vaughn f286c0d901 Increased contrast for selected+inactive background color 2019-04-18 18:19:10 -07:00
Brian Vaughn 131e2e52db Merge pull request #188 from gaearon/humble-search 
Don't select search result unless user does something
 2019-04-18 18:04:28 -07:00
Brian Vaughn 60b614f527 Renamed TREE_OPERATION_RESET_CHILDREN -> TREE_OPERATION_REORDER_CHILDREN 2019-04-18 17:59:53 -07:00
Brian Vaughn 24736e4ff5 Hardened reorder child invariants 2019-04-18 17:58:48 -07:00
Dan Abramov 3d09b4aaa5 Don't select search result unless user does something 2019-04-19 01:54:39 +01:00
Dan Abramov b0c0a11f1b Revert accidental change 2019-04-19 01:41:00 +01:00
Dan Abramov 72e67b343f Add Concurrent Mode test 2019-04-19 01:18:25 +01:00
Dan Abramov 534dfb0ca2 Optimize: don't recreate ID arrays all the time 2019-04-19 01:13:25 +01:00
Dan Abramov 8830ba890c Fix more Suspense traversal bugs 2019-04-19 01:09:57 +01:00
Dan Abramov 346b628b43 Add failing tests for Suspense with same type 2019-04-19 00:36:55 +01:00
Dan Abramov d44bf272ad Refactor: materialize typed array in one place 2019-04-19 00:32:29 +01:00
Dan Abramov ccecde76d1 Harden assertions 2019-04-19 00:29:49 +01:00
Brian Vaughn 3dfbf8ad6b Added a new invariant to the store (bridge operations handler) 2019-04-18 15:40:50 -07:00
Brian Vaughn e2aedb2ea7 Merge pull request #181 from gaearon/consoleerror 
Fail tests on errors in renderer
 2019-04-18 10:08:44 -07:00
Dan Abramov d0b5e3a7cb Update setupTests.js 2019-04-18 18:06:34 +01:00
Brian Vaughn d6e829d7a5 Fixed bug in reset-children to properly calculate new root weight 2019-04-18 09:54:26 -07:00
Brian Vaughn 358e63ac3d Fixed a Suspense toggling bug that incorrectly impacted tree weight 2019-04-18 09:38:41 -07:00
Dan Abramov 8c5794eab3 Fail tests on errors in renderer 2019-04-18 17:03:04 +01:00
Dan Abramov 6a13ffd231 Traverse the previous current tree when switching from primary to fallback 2019-04-18 16:22:50 +01:00
Dan Abramov 24309fde06 Add failing Concurrent Mode stress tests 2019-04-18 16:22:50 +01:00
Dan Abramov 0f44e9fb98 Move sync stress tests in their own file 2019-04-18 16:22:50 +01:00
Brian Vaughn 456e937b83 Merge pull request #178 from gaearon/removal-integrity 
Assert removal happens in the right order
 2019-04-18 08:16:22 -07:00
Dan Abramov d02d93712e Assert removal happens in the right order 2019-04-18 16:02:08 +01:00
Brian Vaughn 08279fb342 Merge pull request #174 from robertknight/mousedown-tab-select 
Select tab when the mouse is pressed
 2019-04-18 08:00:01 -07:00
Lucas Cordeiro 6df050e726 Assign timeoutID to avoid multiple requests 2019-04-18 06:46:06 -03:00
Robert Knight c2865dbab9 Select tab when the mouse is pressed 
Selecting the tab when the mouse is pressed rather than only when it is
released makes tab switching feel faster and also matches how the Chrome dev
tools behave.

The previous tab selection handler which listens for the radio button's
selection has been kept for the benefit of interaction methods which
don't trigger the mousedown handler.
 2019-04-18 08:16:52 +01:00
Brian Vaughn 0d932d770b Merge pull request #168 from bvaughn/collapse-nodes-by-default 
Configurable tree default collapsed/expanded behavior
 2019-04-17 13:29:25 -07:00
Brian Vaughn 75e1e1431b Expanded the reorder tests slightly 2019-04-17 13:11:18 -07:00
Brian Vaughn 634d4fece2 Added more inline comments 2019-04-17 13:03:18 -07:00
Brian Vaughn 3fb9f6cdaa Improve contrast for light mode 2019-04-17 11:40:55 -07:00
Brian Vaughn c107e03132 Flow fix 2019-04-17 09:45:03 -07:00
Brian Vaughn 74be389124 Fixed a bug with re-ordering of children within a collapsed node 2019-04-17 09:39:54 -07:00
Brian Vaughn 178e89927a Fixed some edge cases with collapsed by default. Still some bugs existing. 2019-04-17 07:45:33 -07:00
Brian Vaughn 037bb0034c Throw if root node is collapsed 2019-04-16 14:10:06 -07:00
Brian Vaughn 4b64d7c017 Support configurable node/tree collapsed by default behavior 2019-04-16 13:59:36 -07:00
Dan Abramov 3a6d656090 Remove unnecessary condition 2019-04-16 19:10:39 +01:00
Dan Abramov 58bb7cea41 Remove unused lines 2019-04-16 18:21:40 +01:00
Dan Abramov 8576c85b0d Move stress tests to their own file 2019-04-16 18:10:15 +01:00
Dan Abramov 3cf67ab859 Harden the tests and fix Flow 2019-04-16 17:02:42 +01:00
Dan Abramov b1dea26251 Fix the remaining issue when primary child is null 
This lets us unlock the rest of the Suspense test.
 2019-04-16 16:57:10 +01:00
Dan Abramov fe21ee7ca0 Enable part of Suspense test that was failing before 
This PR fixes it.
 2019-04-16 16:47:26 +01:00
Dan Abramov f4e223bceb When resetting Suspense children, use the fallback child set if needed 
This fixes the bug I introduced in the previous refactor which Suspense test caught.
 2019-04-16 16:45:56 +01:00
Dan Abramov dd935ea178 Propagate the need to reset children to closest visible Fiber 
This fixes the bug.
 2019-04-16 16:34:08 +01:00
Dan Abramov 57e8513a30 Refactor: remove early returns from updateFiberRecursively 
This doesn't change any logic, just the shape of the control flow.
I want to unify some branches at the end, so it's easier if there are no early returns.
 2019-04-16 16:34:08 +01:00
Dan Abramov f4c3008cf5 Refactor: split recordUpdate() into profiling and reorder 
This doesn't change the actual algorithm but splits unrelated parts.
 2019-04-16 16:34:08 +01:00
Dan Abramov b081ffc518 Add stress test for reordering 2019-04-16 16:34:08 +01:00