Commit Graph
1676 Commits
Author SHA1 Message Date
Paul O’Shannessy a34cf222ba Merge pull request #3604 from Charca/firefox-tests-fixes
Fixes for several failing tests in Firefox and Safari
2015-04-08 10:34:57 -07:00
Baraa Hamodi d9d77bc9a5 Update ReactDOMIframe-test.js 2015-04-08 13:06:37 -04:00
Baraa Hamodi c9e3a32bc5 Update ReactCompositeComponentNestedState-test.js 2015-04-08 13:02:43 -04:00
Ben Alpert 057f41ec0f Merge pull request #3595 from spicyj/select-ssr
Fix server-side rendering of <select>
2015-04-07 16:49:10 -07:00
Ben Alpert ea089fdfe6 Fix server-side rendering of <select>
Fixes #1398.
2015-04-07 16:48:58 -07:00
Jan Kassens eda9ec53b5 Fix for style not always reset when set to null
When the style property existed, but was set to null, `this._previousStyleCopy`
was not set back to `null` causing an old value to persist. This broke setting
the style to `null` the next time.

Fixes #3606.
2015-04-07 12:17:06 -07:00
Maxi Ferreira 49745e7bff Fixes for several failing tests in Firefox and Safari 2015-04-07 01:37:27 -03:00
Cheng Lou f3e6436bee Remove last call to getDOMNode in tests 2015-04-02 17:26:19 -04:00
Ben Alpert dea7efbe16 Merge pull request #3555 from spicyj/native-overrides
Import ResponderEventPlugin from react-native
2015-04-02 14:13:35 -07:00
Ben Alpert 5a01f5f6a9 Fix ResponderEventPlugin to work in core React again
Test Plan: jest, grunt fasttest
2015-04-02 13:33:47 -07:00
Murad 6963ea4bfc Update shallowEqual.js 2015-04-03 03:44:37 +08:00
Murad d912329c97 Update shallowEqual.js
optimize for lint rules
2015-04-03 00:12:07 +08:00
Murad d2bb4728f0 Increase speed of shallowEqual
All testes successfully completed.

- for-in in browsers is slow, i replaced him by Object.keys + for(array)
- simple check of lengths let us not iterate if not same
- now we dont need to test for B's keys missing from A, because if length's is same and prev check success - objB hasn't more keys
- micro optimize: calling objB.hasOwnProperty
- micro optimize: replaced !objA || !obj for more speedy check === null

#inspiredby https://github.com/jurassix/react-immutable-render-mixin/pull/4
2015-04-02 23:43:29 +08:00
Jim 3fad007bdb Merge pull request #3560 from mariodu/mariodu
fix render order error in safari.  Fixes #3560.
2015-04-01 17:40:09 -07:00
Ben Alpert 08e4420019 Use setState transaction for TransitionGroup instead of extra property 2015-04-01 14:34:01 -07:00
Ben Alpert 205273d2ee Merge pull request #2549 from ashtuchkin/fix-transitiongroup-multiremove
Fix ReactTransitionGroup behavior when removing several children at once
2015-04-01 14:33:42 -07:00
Jeff Chan af7e43269f Fix immutability helper to check hasOwnProperty safely
This makes `update({}, {'hasOwnProperty': {$set: 'yolo'}})` work.
2015-04-01 12:25:12 -07:00
凌恒 6094ebbc39 update comment 2015-04-01 23:59:43 +08:00
凌恒 54a74d95bb deal IE8 out of size error 2015-04-01 23:56:05 +08:00
凌恒 d4adaee4eb use ie8 feature detect instead of try catch 2015-04-01 21:46:40 +08:00
凌恒 e1a8d69840 fix render order error in safari 2015-04-01 18:13:03 +08:00
Ben Alpert 036d342189 Fix unused variable lint from #3552 2015-03-31 17:06:42 -07:00
Ben Alpert 6ec3b65169 Import ResponderEventPlugin from react-native
This is a direct import of the files from react-native, with the license headers updated.
2015-03-31 15:21:47 -07:00
Paul O’Shannessy 94a3b0f8a3 Merge pull request #3552 from James-Dunn/fix-for-loops
Remove caching from for loops
2015-03-31 10:30:44 -07:00
James 90dcc1ffb7 Remove caching from for loops
Removed caching from for loops as it does not seem to increase
performance and makes the code harder to read.
2015-03-31 10:22:52 +04:00
Paul O’Shannessy 18d608820e Merge pull request #3519 from jonchester/patch-1
Add IE-specific 'unselectable' attribute
2015-03-30 15:27:13 -07:00
jonchester a0265fe8b7 Add IE-specific 'unselectable' attribute
I ended up needing to add this attribute to work around a common IE bug, that clicking on a scrollbar gives focus to the scroll container. I needed to set it as MUST_USE_ATTRIBUTE or the attribute would not be passed through by React successfully.

remove trailing spaces
2015-03-30 07:44:08 -07:00
Jim b3c75d82b2 Merge pull request #3521 from grant/master
Display error when trying to create an element of type `boolean`. Fixes #3478
2015-03-26 14:39:32 -07:00
Mert Kahyaoğlu 6248406d6a remove unrelated doc line 2015-03-26 21:08:32 +02:00
Grant Timmerman 59a914aac0 Disable numeric element types 2015-03-26 10:07:56 -07:00
Grant Timmerman 3c9ea72795 Display error when trying to create an element of type boolean. Fixes #3478 2015-03-26 01:21:54 -07:00
Ben Alpert b32fbef7c5 Add missing semicolon 2015-03-25 18:10:49 -07:00
Ben Alpert 7c6694987d Tweak validation message, add html support
The old message made no sense if you had a > div > a or similar. I'm clearly feeling sloppy today.
2015-03-25 17:24:13 -07:00
Ben Alpert 07b7e8424d Remove stray console.log comment 2015-03-25 17:06:42 -07:00
Ben Alpert 76bb96ef21 Validate only against problematic tag nesting
Turns out lots of people write invalid HTML all the time and no one, including your browser or React, cares. Most invalid HTML combinations don't cause magic reparented nodes; only some do. The HTML5 parsing spec (https://html.spec.whatwg.org/multipage/syntax.html) specifies which tag combinations cause strange parsing behavior. I did my best to encode the logic here. It's more lenient than before in some cases, but more strict in others (before we didn't look at the whole stack of tags; now we warn with deeply nested `p` or `form` or `a` tags).
2015-03-25 16:43:41 -07:00
Paul O’Shannessy 27a191e704 Merge pull request #3513 from agelter/master
Added support for the 'low', 'high', and 'optimum' attributes that are missing from the <meter> tag.
2015-03-25 12:17:07 -07:00
Paul O’Shannessy 56b180b464 Fix failing test
PR #3494 was based on master before we shifted to using console.error. This
just fixes the new test case.
2015-03-25 12:15:41 -07:00
Jim 13dbda3644 Merge pull request #3494 from letiemble/B_Context_Rerender
Fix the context handling when updating a rendered component.
2015-03-25 11:55:35 -07:00
Aaron Gelter c9e82ce0f6 Added support for the 'low', 'high', and 'optimum' attributes that the <meter> tag requires. 2015-03-25 11:33:02 -06:00
Damien Pellier 3d45c0ad9d add scoped property to the list of DOM standard properties 2015-03-25 09:41:05 +01:00
Paul O’Shannessy 09ecf8bca9 Merge pull request #3499 from sverrejoh/patch-1
Don't add 'px' to strokeDashoffset CSS Properties
2015-03-24 13:57:02 -07:00
Sverre Johansen 77abea5ddc Reordered properties to maintain ABC order 2015-03-24 20:43:55 +00:00
Ben Alpert 6ad4afd404 Merge pull request #3502 from spicyj/tests
Fix tests after merge of #3440
2015-03-24 13:41:34 -07:00
Paul O’Shannessy 2795fb162a Merge pull request #3490 from chenglou/remove-class-addon
Remove classSet/cx
2015-03-24 13:39:47 -07:00
Ben Alpert 4dde417214 Fix tests after merge
Test Plan: jest
2015-03-24 13:37:39 -07:00
Ben Alpert 9260b540ad Merge pull request #3467 from spicyj/valid-3
Validate node nesting, take 3
2015-03-24 13:30:16 -07:00
Ben Alpert 1aa4e3c234 Merge pull request #3440 from spicyj/console-error
Use console.error to show stack trace in console
2015-03-24 13:30:01 -07:00
Sverre Johansen c28059e39b Don't add 'px' to strokeDashoffset CSS Properties
This is a SVG CSS Property. The standard expects values or percentages, and adding "px" to the value will break it.

http://www.w3.org/TR/SVG/painting.html#StrokeDashoffsetProperty
2015-03-24 17:52:02 +00:00
Laurent Etiemble 357345a56d Fix the context handling when updating a rendered component. 2015-03-24 08:29:09 +01:00
Cheng Lou 18ab88aa78 Remove classSet/cx 2015-03-23 17:59:27 -04:00