Facebook/react
1
0 Fork 0
mirror of https://github.com/facebook/react.git synced 2025-11-01 09:12:30 +00:00
Code Issues Packages Projects Releases Wiki Activity
5,557 Commits 681 Branches 148 Tags
ed7ab7b94acd6fcda8d8d4ab3d44c3f601d28ff7
Commit Graph
2216 Commits
Author SHA1 Message Date
Paul O’Shannessy 0dc6596dc2 Fix indentation issues 2015-10-15 09:29:28 -07:00
Jim b735dd4ab4 Merge pull request #5048 from antoaravinth/PR-5013 
Issue: 5013 Added necessary code for firing warning if value is null
 2015-10-14 23:06:54 -07:00
Ants b42c1dafcc Issue: 5013 Added necessary code for firing warning if value is null 
Fixed the lint issues

Added logic for handling the warning only once and added the test cases for the same. Also moved the warning part to only DEV mode

Changed few lines related to the formatting issues

Removing the empty whitespace
 2015-10-15 10:13:35 +05:30
Ben Alpert 8168c8eac6 Merge pull request #5175 from spicyj/text-no-frag 
Don't test frag cases in ReactMultiChildText-test
 2015-10-14 16:07:11 -07:00
Paul O’Shannessy 8e9682c542 Merge pull request #5174 from zpao/dom-attributes-track 
Add srcLang and kind to better support track elements
 2015-10-14 14:35:03 -07:00
Ben Alpert 5f8fe7d614 Don't test frag cases in ReactMultiChildText-test 
These are now just testing the same as the array cases directly above. This should make this test a bunch faster because it (intentionally) has n^2 runtime.
 2015-10-14 14:31:45 -07:00
Ben Alpert 8e67b7f624 Merge pull request #4988 from spicyj/fdn 
Walk down internal tree to find DOM node
 2015-10-14 14:31:28 -07:00
Ben Alpert 5c5d2ec182 Walk down internal tree to find DOM node 
This reduces our reliance on hierarchical IDs.
 2015-10-14 14:22:53 -07:00
Paul O’Shannessy 659172df50 Add srcLang and kind to better support track elements 2015-10-14 12:05:56 -07:00
Jim 555fd46c7e Merge pull request #5140 from pluma/patch-1 
Fix #1357. Don't append "px" suffix to CSS string values.
 2015-10-14 11:18:53 -07:00
Alan Plum a299a366ce Fix #1357. Warn when appending "px" to strings. 2015-10-14 18:36:24 +02:00
Sebastian Markbåge da1135618e Merge pull request #5166 from spicyj/gh-5157 
Add feature test for document.createEvent
 2015-10-14 00:08:56 -07:00
Ben Alpert 1206d8d2eb Add feature test for document.createEvent 
See #5157.
 2015-10-13 16:34:05 -07:00
Ben Alpert e89e675508 Be more lenient with invalid nodes in the cache 
This matches our old behavior. I was a little too aggressive in turning on this
error and it's still possible to trigger it (using the test added here).
 2015-10-13 16:07:06 -07:00
Paul O’Shannessy af99b2c2a3 Merge pull request #5164 from zpao/fix-csstransitiongroup-proptype 
Correctly handle 0 in CSSTransitionGroup timeout props
 2015-10-13 14:54:21 -07:00
Paul O’Shannessy dc21b95244 Correctly handle 0 in CSSTransitionGroup timeout props 2015-10-13 14:39:55 -07:00
Ben Alpert dddbca472a Merge pull request #5160 from spicyj/gh-5151 
Fetch node to unmount separately from unmounting
 2015-10-13 12:19:24 -07:00
Ben Alpert 622db4ee4f Fetch node to unmount separately from unmounting 
My last strategy of getting each node recursively while unmounting was a pain to make work properly with ReactMount's confusing cache. Now, we get the node before unmounting anything in the subtree (and we don't try to find the nodes of descendants).

This is a temporary solution and can go away when we get rid of the giant ReactMount node hash map.

Fixes #5151.
 2015-10-13 12:07:57 -07:00
Ben Alpert 6488a4c187 Use 'document.createEvent' not 'new Event' 
Fixes #5153.

This seems to work in all browsers I tested, including old Android and all IE > 8 which didn't work before.
 2015-10-13 11:14:23 -07:00
Jim c1c9b383a0 Merge pull request #5137 from vipulnsward/2576-add-comparison-tests 
Added tests to compare testing of components using different types of element creation
 2015-10-12 14:08:08 -07:00
Vipul A M b4a6bc89c2 - Added tests to compare testing of components using different types of element creation 
Fixes [#2576]

- Fixed Lint warnings and errors
 2015-10-12 16:44:00 -04:00
Ben Alpert db989bf686 Don't execute <script> tags w/ createElement mode 
Each script will execute at most once so we could also set `.textContent` to something like `;`, then add it to the document, then change the `.textContent`, but this seems like the simplest approach. See http://dev.w3.org/html5/spec-preview/the-script-element.html for details.
 2015-10-12 13:43:40 -07:00
Ben Alpert b03b195759 Merge pull request #5130 from matiassingers/jasmine-spy-call-args-consistency 
Jasmine spies call args property consistency
 2015-10-12 10:24:56 -07:00
Alan Plum 0e451162bc Removed eslint warning. 2015-10-12 17:42:38 +02:00
Matias Singers f8f2be05ce Consistently use calls[n].args[n] instead of argsForCall[n][n] for Jasmine spies 2015-10-12 22:39:19 +08:00
Matias Singers dd0b1a643b Consistently use calls.length instead of callCount for Jasmine spies, take II 
See #3105 for take I
 2015-10-11 15:42:24 +08:00
Ben Alpert 8210299437 Add SVG/MathML support for createElement mode 2015-10-09 14:56:57 -07:00
Ben Alpert 1dca72ebfa Thread native-parent pointers through everything 
Now we don't repurpose context for our own secret needs (hi Dan). In this diff I avoid storing the native parent on native (DOM) components and store it only on composites, but we'll probably want to store it on native components too soon for event bubbling.
 2015-10-09 14:56:08 -07:00
Ben Alpert a907da9430 Make Danger-test simpler and more robust 2015-10-09 14:54:42 -07:00
Jim 15c731edca Merge pull request #5109 from Josh-a-e/undefined_this_on_controlled_components 
add test to show `this` is indeed undefined - closes #3613
 2015-10-09 11:44:19 -07:00
Ben Alpert d95381387e Merge pull request #5111 from spicyj/vdn-current 
validateDOMNesting: parentTag -> current
 2015-10-09 11:43:31 -07:00
Ben Alpert 9c836b09f2 validateDOMNesting: parentTag -> current 2015-10-09 11:40:55 -07:00
Joshua Evans 8f4c2997a0 add test to show this is indeed undefined - closes #3613 2015-10-09 19:37:58 +01:00
Kevin Cheng ff17bc25d1 Fixed punctuation 2015-10-08 19:36:05 -07:00
Ben Alpert d4420eca8a Remove duplication in ReactServerRendering 2015-10-08 15:06:09 -07:00
Ben Alpert 3f5747009d Merge pull request #5083 from spicyj/warn-min 
Warn when using a minified copy of dev React
 2015-10-08 14:08:50 -07:00
Ben Alpert f3a506bc0c Warn when using a minified copy of dev React 
Fixes #4842.
 2015-10-08 11:44:56 -07:00
Ben Alpert 2253405dcc Merge pull request #5085 from spicyj/cdp 
Extract defineProperty feature testing to one file
 2015-10-08 11:33:07 -07:00
Ben Alpert 4fb39ce984 Merge pull request #5081 from spicyj/svg-tu 
Don't break on SVG tags in scryRenderedDOMComponentsWithClass
 2015-10-08 08:38:32 -07:00
Ben Alpert 4bb83d237e Don't break on SVG tags in scryRenderedDOMComponentsWithClass 
Fixes #5076.
 2015-10-08 08:29:53 -07:00
Ben Alpert e9796cc447 Merge pull request #5084 from spicyj/rearrange-utils 
Move escapeTextContentForBrowser and quoteAttributeValueForBrowser to DOM directory
 2015-10-08 08:28:40 -07:00
Ben Alpert 3fb2d3f5d4 Extract defineProperty feature testing to one file 
This makes it slightly more bearable to debug in IE8 with an exception breakpoint. Also the old way was just silly and could mask other bugs.
 2015-10-07 18:33:13 -07:00
Ben Alpert 2637a8eaf4 Move escapeTextContentForBrowser and quoteAttributeValueForBrowser to DOM directory 
Only DOM files use these.
 2015-10-07 18:11:15 -07:00
Ben Alpert a7189c57fc Merge pull request #5057 from camsong/patch-1 
Text fix in ReactClass.js
 2015-10-07 17:19:19 -07:00
Cam Song 9af15d3ecd Text fix in ReactClass.js 
Rename 'component class' to 'function' as it should be.
 2015-10-08 08:13:27 +08:00
Jim d0970ee8b8 Merge pull request #5063 from facebook/revert-5062-revert-4959-no-shams 
Remove dependence on ES5 shams per #4189
 2015-10-07 14:23:35 -07:00
Jim f97d759db1 Merge pull request #5032 from jimfb/remove-react-link 
Added warning for use of ReactLink.
 2015-10-07 14:23:11 -07:00
Ben Alpert f31a46cb18 Merge pull request #4983 from spicyj/id-swap 
Refactor how composite type changes work, fix memory leak in ReactMount caching
 2015-10-07 13:02:58 -07:00
Ben Alpert 34d84a36d6 Merge pull request #5066 from camsong/patch-2 
Always use ANONYMOUS const in  ReactPropTypes.js
 2015-10-07 12:57:59 -07:00
Ben Alpert 8ce7b7120c ReactMount now never expects invalid nodes in its cache 
It never really made sense for us to have "invalid" nodes in the cache -- when we unmount things, we should always remove them from the cache properly. Now that swapping composite types doesn't repopulate the cache, we should be okay to now assume that everything in the cache is good.
 2015-10-07 12:57:34 -07:00