Facebook/react
1
0
Fork 0
mirror of https://github.com/facebook/react.git synced 2025-11-01 09:12:30 +00:00
Code Issues Packages Projects Releases Wiki Activity
784 Commits 681 Branches 148 Tags
de9e94de5f807f1ce1c03f3b67618452b3a6287a
Commit Graph
23 Commits
Author SHA1 Message Date
Ben Alpert 0a45325621 Actually make exec work 
The spec for eval (http://es5.github.io/x15.1.html#x15.1.2.1) says "If Type(x) is not String, return x." and that's exactly what's happening here -- it gets {code: ...} and does nothing.
 2013-09-30 18:51:39 -07:00
Jeff Morrison b5a11a431e Merge pull request #336 from spicyj/jsx-spacing 
JSX: Respect original spacing and newlines better
 2013-09-20 10:59:21 -07:00
SanderSpies cd79ed32cb - removed creation of the id within the tooling integration doc (expect this to be done by @zpao's pull request) 
- removed the if statement and now always provide a warning message (as proposed by @spicyj)
- improved the warning message
 2013-09-19 06:48:38 +02:00
SanderSpies d2bf50c63d Give the user a warning when using unoptimized JSX code and send the user to the correct location in the documentation to optimize. 2013-09-19 00:55:10 +02:00
Ben Newman adda400602 Make constant propagation smarter about pruning if statements. 2013-09-18 13:33:45 -04:00
Ben Alpert f69112cb3f JSX: Respect original spacing and newlines better 
Fixes #335.

Now this JSX:

```
/** @jsx React.DOM */
var HelloMessage = React.createClass({
  render: function() {
    return <div>
      Look!
      <a href=
        "http://www.facebook.com/">Facebook
      </a>
    </div>;
  }
});
```

produces

```
/** @jsx React.DOM */
var HelloMessage = React.createClass({displayName: 'HelloMessage',
  render: function() {
    return React.DOM.div(null,
      " Look! ",
      React.DOM.a( {href:
        "http://www.facebook.com/"}, "Facebook "
      )
    );
  }
});
```

rather than the less-desirable

```
/** @jsx React.DOM */
var HelloMessage = React.createClass({displayName: 'HelloMessage',
  render: function() {
    return React.DOM.div(null,
" Look! ",      React.DOM.a( {href:"http://www.facebook.com/"}, "Facebook "      ),
    );
  }
});
```
 2013-09-10 17:14:36 -07:00
Paul O’Shannessy d83fe785c5 Stop transforming class -> className 
Update the broken examples too (`git grep class=`)
 2013-09-09 15:37:43 -07:00
JeffMo 2d048f1f34 Move to using jstransform and esprima-fb npm modules 2013-08-22 15:28:41 -07:00
Jakub Malinowski 795a84d60f Do not export load in JSXTransformer unless in a browser environment 2013-07-23 23:01:38 +02:00
Jakub Malinowski 2b9dd04f4d Allow to execute JSXTransformer outside of browser environment 2013-07-20 15:10:36 +02:00
Paul O’Shannessy 91562ba934 Sync JSX tags from upstream 
This is the other part of fc5f7e0e85. This
file isn't part of our sync process so needs to be done separately.
 2013-07-08 12:51:11 -07:00
JeffMo 9c35189ad1 Add support for empty XJS expressions 2013-06-28 13:10:20 -07:00
petehunt 7053f59ad1 Remove second argument to invariant() 2013-06-23 21:58:59 -07:00
Ben Newman 000928f9dc Use recast.parse and .print for require("vendor/constants").propagate. 
This removes the need to pass a callback, which is a nice improvement.
 2013-06-17 16:30:32 -04:00
Ben Newman 0f87e8ee87 Rename Woodchipper-related stuff. 
No functional changes introduced by this commit.

Renamed:

    woodchipper.js -> constants.js
    Woodchipper -> ConstantVisitor
    debranch -> propagate
 2013-06-17 16:21:51 -04:00
Paul O’Shannessy c79a59b599 Improve JSXTransformer 
The biggest improvement is that we'll now insert each parsed JSX script
back into a `<script>` tag with the body set. This allows the browser to
execute these scripts normally. Using `Function(functionBody)` or
`eval(functionBody)` both execute in window scope, but `var` assignments
don't actually get set on window (unlike everywhere else).

I also did some cleanup to make the code a little bit more readable.
In my minimal test cases this didn't break anything (scripts loaded in
the right order).
 2013-06-17 10:52:16 -07:00
Paul O’Shannessy 06cff60bc1 Sync latest JSX transform - all children passed as separate arguments 
This was a part of e1fe13d0cb upstream.
 2013-06-13 18:18:54 -07:00
Ben Newman c740373b31 Fix some silly uses of Function.prototype.bind in jasmine-support.js. 2013-06-03 13:20:13 -04:00
Ben Newman 03f92bb155 Polyfill Function.prototype.bind during tests. 2013-06-03 13:20:13 -04:00
Ben Newman f8af93237a Use bin/jsx and browserify to build a jasmine bundle. 2013-06-03 13:20:13 -04:00
Paul Seiffert 510ced1d13 Removed duplicate object type check 2013-05-31 07:13:49 +02:00
Paul Seiffert b03f04ff24 Fixing Bug in JSX transformer 
The bug fixed by this commit prevented the correct parsing of
`var` statements with multiple variables being declared. Instead
of trying to parse a whole 'variable declarations' (a `var`
statement with all its declarations), this visitor now only
parses single 'variable declarators'.
 2013-05-30 20:51:15 +02:00
Paul O’Shannessy 75897c2dcd Initial public release 2013-05-29 12:54:02 -07:00