Commit Graph
19463 Commits
Author SHA1 Message Date
Paul O’Shannessy e63eab111c Merge pull request #1553 from givingstage/invalid_checksum_warning_spacing
Fixed spacing of invalid checksum warning
2014-05-20 11:23:19 -07:00
Paul O’Shannessy 6c595d55dc Merge pull request #1571 from spicyj/style-test
Switch style test to pass in jsdom
2014-05-20 11:22:30 -07:00
remixz 765ee8e5d0 Merge upstream changes 2014-05-19 20:12:57 -07:00
Ben Alpert 2d26451821 Add configuration for running tests with Jest
Can be run with `node_modules/.bin/jest` for now; didn't want to disturb the grunt setup.

Right now one test fails with:

```
 FAIL  browser/ui/__tests__/ReactDOMComponent-test.js (1.423s)
● ReactDOMComponent › updateDOM › it should update styles when mutating style object
  - Expected: '0' toEqual: '0.5'
        at Spec.<anonymous> (src/browser/ui/__tests__/ReactDOMComponent-test.js:99:33)
```

which I can only assume is a jsdom problem -- no other asserts fail.
2014-05-19 16:58:33 -07:00
Ben Alpert 4e5ed8317b Switch style test to pass in jsdom
This should be testing approximately the same thing and passes in Jest.

Test Plan: Cherry-pick Jest config from #1528 and verify that running `jest`.
2014-05-19 16:56:30 -07:00
Ben Alpert e17086e5df Add componentWillReceiveProps setState test 2014-05-19 15:58:40 -07:00
Paul O’Shannessy 5933d97cb6 Merge pull request #1563 from spicyj/travis-no-sauce
Don't fail Travis on sauce failures
2014-05-19 13:28:09 -07:00
Ben Alpert 8db8e60a38 Don't fail Travis on sauce failures
Fixes #1496.
2014-05-19 13:23:07 -07:00
Paul O’Shannessy ab58ecefa7 Merge pull request #1564 from spicyj/hop-ie8
Use Object.prototype.hasOwnProperty for doc in IE8
2014-05-19 13:15:25 -07:00
Ben Alpert 550795445e Use Object.prototype.hasOwnProperty for doc in IE8
Test Plan: Loaded ballmer-peak example in IE8 without errors and interacted with the text field.
2014-05-19 13:09:47 -07:00
Paul O’Shannessy 0c6bee049e Merge pull request #1189 from spicyj/hasown
Add hasOwnProperty checks where appropriate
2014-05-19 09:38:56 -07:00
Ben Alpert 4935d04d50 Allow unmounting title tag
cf. #1376.

This is useful for SVG. Dynamically adding and removing `<title>` elements in SVG still won't work properly because of getMarkupWrap but this at least lets you include it in initial render and then unmount the entire `<svg>` without problems.
2014-05-18 23:19:51 -07:00
Nate Hunzaker 0614cfa43e Load scripts in parallel 2014-05-18 16:34:40 -04:00
Ben Alpert 66291d2761 Merge pull request #1558 from nhunzaker/fix-1530
Fix 1530 - Asynchronously load scripts with JSX transformer
2014-05-18 13:04:11 -07:00
Nate Hunzaker bc79f623a1 Asynchronously load scripts with JSX transformer. 2014-05-18 15:41:41 -04:00
Andrew Davey 2b38795769 Rebased on master 2014-05-18 17:51:14 +01:00
Andrew Davey fc5bb9c9b2 Add sourceMap option to react-tools transform
Allow tools like grunt-react to include inline source maps in the
generated JavaScript. Browserify can then combine these source maps when
bundling everything together.

Usage:

```
var transform = require('react-tools').transform;
var output = transform(jsxContent, {
  sourceMap: true,
  sourceFilename: 'source.jsx'
});
```

The `output` will have an inline source map comment appended.
2014-05-18 17:42:35 +01:00
Mark IJbema 59616672d7 Make sure it works when we have no css transitions 2014-05-18 11:31:24 +02:00
Mark IJbema cd7b8aa0b1 Added event parameter 2014-05-18 11:29:29 +02:00
Ben Alpert 1baca43391 Mention PropTypes in top-level API
cf. #449
2014-05-18 00:15:35 -07:00
Ben Alpert f1a5a4c58e Be more specific with createClass, renderComponent
Closes #371.
2014-05-18 00:15:35 -07:00
Ben Alpert 566af16e64 Tweak getting started wording 2014-05-18 00:15:35 -07:00
Joshua Ma de1f783188 Update todomvc dispatcher to match docs, add AppDispatcher test 2014-05-17 22:01:18 -07:00
Joshua Ma f12a376f34 Update Flux Dispatcher.dispatch and waitFor examples
The previous examples didn't properly work when 1) a Store callback does
waitFor on Stores that haven't been reached yet and 2) a Store callback
waits on another Store that is already waiting.

The updated example uses constructs Promises up front and then
asynchronously resolves them.
2014-05-17 21:17:08 -07:00
Thomas Shafer 0a7128c70f Fixed spacing of invalid checksum warning 2014-05-17 20:04:52 -07:00
Ben Alpert e9653aad6a Merge pull request #1552 from t3chnoboy/master
Update Jasmine link
2014-05-17 18:33:51 -07:00
Dmitry Mazuro 8192b8c27f Update Jasmine link 2014-05-18 04:30:02 +03:00
Ben Alpert 78958fe0f5 Remove references to autoflow
Most references were removed in 6e59561; this should be the last.
2014-05-17 15:15:26 -07:00
Ben Alpert 6c331fba07 Add hasOwnProperty checks where appropriate
For boolean-like objects, I've added hasOwnProperty checks in addition to the existing truthiness check even though for most of these dicts, we leave out false keys instead of setting them explicitly to false.

In DOMPropertyOperations, we don't need to check hasOwnProperty if the property is in isStandardName because (with the exception of getPossibleStandardName) the dicts on DOMProperty will now be consistently populated with every valid attribute.
2014-05-16 10:59:51 -07:00
Paul O’Shannessy 4558e2c4bc Merge pull request #1491 from naturalatlas/itemscope
Added support for itemscope, itemtype, itemprop attributes.
2014-05-15 14:48:51 -07:00
Jan Kassens 46de927a28 Merge pull request #1537 from chenglou/rm-filter-attrs
Remove filterAttributes.js
2014-05-15 12:16:35 -07:00
Cheng Lou 80a5463a2c Remove filterAttributes.js
This is no longer needed because of https://github.com/facebook/react/commit/089a494a1f0cc1892f1525fd746bac10c5a55175

mutateHTMLNodeWithMarkup.js was the only one using it.
2014-05-15 14:14:38 -04:00
Andreas Svensson 3bec9f070f Guard against contentEditable with children props 2014-05-15 11:08:25 +02:00
Ben Alpert c913c95908 Update Simulate docs to reflect reality
cf. #1532, #1445.
2014-05-14 21:39:00 -07:00
remixz 3f31ec463f Change harmony option to "harmony=true" 2014-05-14 15:50:35 -07:00
remixz 65c258a7b7 Add harmony transform support in browser (Fixes GH-1420)
I implemented this by checking for `type="text/jsx;harmony"`, since this
has a bit of a cleaner implementation rather than parsing a JSON object
out of a data attribute. If in the future there are other options to
pass, it would make sense to move to a system like that.

Along with adding support, there is also a new example added that's
the basic-jsx example with Harmony syntax.
2014-05-13 22:07:02 -07:00
Daniel Schonfeld 7d91277a50 warn when shouldComponentUpdate() returns undefined 2014-05-13 22:44:00 -04:00
Pete Hunt b66202eb98 Merge pull request #1487 from somethingkindawierd/master
Adds svg mask and pattern dom components
2014-05-13 11:28:59 -07:00
Ben Alpert 808a54f410 Batch subupdates caused by any state update
With this, multiple setState calls triggered by a componentDidUpdate handler (or similar) will be batched together, regardless of if the original setState call was in a batching context.

I also cleaned up some inconsistencies with the order of component updates and callbacks in situations where one component's update directly causes another to update.

Fixes #1147. Helps with #1353 and #1245 as well, though doesn't completely fix them yet.

Test Plan:
grunt test
2014-05-13 10:50:26 -07:00
Paul O’Shannessy a00199ddd2 Merge pull request #1358 from spicyj/one-transaction
Share reconcile transaction in batched updates
2014-05-13 10:47:03 -07:00
Josh Duck 29f3f74c52 Make perf show all exclusive time, not just render time.
Currently require('ReactDefaultPerf').printExclusive() shows render
time and aggregate componentMount time.

This makes it show exclusive mount time by tracking a stack.
2014-05-12 16:39:09 -07:00
Pete Hunt 7268f44c94 Merge pull request #1504 from spicyj/flux-621
Start Flux video at 10m21s
2014-05-12 13:44:21 -07:00
Pete Hunt e4f80f301d Merge pull request #1516 from syranide/es5err
Preemptively error when required ES5 shim/shams are not available
2014-05-12 13:40:00 -07:00
Ben Alpert d46e1588f9 Update Flux README to point at website post/docs 2014-05-12 01:33:53 -07:00
Ben Alpert 76abdddae8 todomvc-flux: Depend on uglify-js, not uglifyjs
Fixes #1505.

Confusingly, the uglify-js package provides the `uglifyjs` binary and `npm run-script build` didn't work if uglify-js wasn't installed globally; now it does.
2014-05-12 01:14:01 -07:00
Andreas Svensson 659b7981e1 Preemptively error when required ES5 shim/shams are not available 2014-05-11 21:20:07 +02:00
Ben Alpert 6b1c546602 Add missing emitChange() to Flux docs 2014-05-10 17:50:26 -03:00
Ben Alpert 6b758ef283 Merge pull request #1503 from dybskiy/patch-2
Update flux-todo-list.md
2014-05-09 15:38:18 -03:00
Ben Alpert 39a0dbaebe Start Flux video at 10m21s 2014-05-09 15:34:12 -03:00
Yuriy Dybskiy d5a5840d31 Update flux-todo-list.md
Fix broken link to todomvc-flux repo

@spicyj cla signed
2014-05-09 11:11:42 -07:00