Facebook/react
1
0 Fork 0
mirror of https://github.com/facebook/react.git synced 2025-11-01 09:12:30 +00:00
Code Issues Packages Projects Releases Wiki Activity
19,463 Commits 681 Branches 148 Tags
d5e955d3c0c1fa2494de0ab33be9cd90c65aff1e
Commit Graph
19463 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Basarat Ali Syed b7fe1ac0fc 📝 link to docs and not the blog post 2015-06-09 11:33:33 +10:00
Paul O’Shannessy 8488cb4dac fix japanese docs permalinks 2015-06-08 18:18:57 -07:00
Paul O’Shannessy 2b53acb00a Merge pull request #4045 from davemeetsworld/add-warning-for-mispelling-of-componentWillReceiveProps 
Added warning for mispelling of componentWillReceiveProps and updated…
 2015-06-08 15:12:40 -07:00
David Baker 2d8c4be000 Added warning for mispelling of componentWillReceiveProps and updated tests 2015-06-08 22:44:30 +01:00
Paul O’Shannessy 5955379753 Merge pull request #4060 from cody/addons 
Fix addon name in npm Readme
 2015-06-08 14:00:20 -07:00
Paul O’Shannessy a74138bdee Fix docblock of ReactFragment 2015-06-08 13:49:29 -07:00
Stefan Dombrowski c9ab11f5ff Fix addon name in npm Readme 2015-06-08 22:39:12 +02:00
Ben Alpert 6b8ed9b64e Merge pull request #3884 from glenjamin/patch-3 
Document boolean attributes in JSX
 2015-06-08 13:28:39 -07:00
Paul O’Shannessy 7f7528c454 Merge pull request #4059 from jquense/patch-3 
fix my embarrassing amount of typos in this 4 line change
 2015-06-08 13:01:15 -07:00
Benjamin Woodruff f27d130323 Merge pull request #4040 from PiPeep/eslint-updates 
Update eslint-related dependencies
 2015-06-08 13:00:13 -07:00
Jason Quense 813649cbc7 fix my embarrassing amount of typos in this 4 line change 2015-06-08 15:59:30 -04:00
Paul O’Shannessy 09993a1379 Merge pull request #4054 from jquense/patch-2 
Update npm Readme to new method of accessing addons
 2015-06-08 12:53:28 -07:00
Ben Alpert 8614dd3cf9 Merge pull request #3984 from neojski/uppercase-node-name 
Always toLowerCase when comparing nodeName or tagName
 2015-06-08 11:44:56 -07:00
Ben Alpert 0e3ae67418 Merge pull request #4043 from spicyj/80 
Remove line length lint warning
 2015-06-08 10:40:42 -07:00
Ben Alpert 39f232b9aa Merge pull request #4042 from spicyj/warn-dom-props 
Warn when accessing .props, .setProps on DOM components
 2015-06-08 10:40:26 -07:00
Ben Alpert bfcad9614a Warn when accessing .props, .setProps on DOM components 2015-06-08 10:36:20 -07:00
Benjamin Woodruff 52eca1eb69 Update eslint-related dependencies 
- babel-eslint ^3.1.14 fixes babel/babel-eslint#120
- babel updated from ^5.3.3 to ^3.5.5, which changes stuff, I guess
- eslint updated from ^0.21.2 to ^0.22.1, which makes `no-shadow` also
  check class declarations
 2015-06-08 08:41:13 -07:00
Jason Quense 7fa8c79d40 Update docs to new method of accessing addons 2015-06-07 19:07:36 -04:00
Andreas Savvides ae83e90ec7 [#3964] Add note about React's onChange vs. DOM's oninput 2015-06-07 10:39:08 +01:00
Tomasz Kołodziejski 2bb69328ae Always toLowerCase when comparing nodeName or tagName 
In xml node name casing is exactly the same as the node was originally named.
Make sure to convert node and tag names to lower case before making any node
and tag name checks.

Fixes #3960.
 2015-06-06 10:28:43 +02:00
Basarat Ali Syed b994d076d1 📝 document changes for classes 
Taking https://github.com/facebook/react/pull/4013#discussion_r31829922 into account
 2015-06-06 10:23:41 +10:00
Ben Alpert ba81b60ad8 Merge pull request #4037 from spicyj/ref-trans 
Only enqueue attachRefs if refs are present
 2015-06-05 12:42:09 -07:00
Ben Alpert edee1c7ed7 Merge pull request #4035 from spicyj/dc-os 
Convert select/option to not use wrappers
 2015-06-05 12:41:34 -07:00
Benjamin Woodruff 0dab63b905 Merge pull request #4034 from PiPeep/eslint-rules-as-a-plugin 
Load custom eslint rules as plugin, w/o --rulesdir
 2015-06-05 10:43:02 -07:00
Ben Alpert c6837507f9 Only enqueue attachRefs if refs are present 
for #4036
 2015-06-04 22:57:46 -07:00
Ben Alpert 06de43d73e Remove line length lint warning 
...because the current situation isn't helpful; no one looks at the list. Our style guide hasn't changed.
 2015-06-04 18:14:31 -07:00
Ben Alpert abfd151b90 Convert select/option to not use wrappers 2015-06-04 18:13:54 -07:00
Ben Alpert 806ff23f03 Merge pull request #4033 from spicyj/dc-events 
Convert form, iframe, img to not use wrappers
 2015-06-04 17:23:48 -07:00
Benjamin Woodruff 30cce21ae6 Load custom eslint rules as plugin, w/o --rulesdir 
This allows us to load the eslint rules without requiring command-line
arguments, which avoids breaking editors with eslint plugins.

https://github.com/eslint/eslint/issues/2180#issuecomment-87722150
 2015-06-04 17:04:45 -07:00
Benjamin Woodruff 58302a71c4 Merge pull request #4032 from PiPeep/babel-eslint-no-unused-vars 
Roll back to babel-eslint 3.1.9
 2015-06-04 15:53:04 -07:00
Ben Alpert a825380840 Convert form, iframe, img to not use wrappers 
Test Plan:
Tested manually that rendering an `<img />` triggers its onLoad handler.
 2015-06-04 15:52:34 -07:00
Benjamin Woodruff 40eb94d13e Roll back to babel-eslint 3.1.9 
spicyj noticed newer versions of babel-eslint seemed not to error on
no-unused-vars, and I was able to repro. It seems like something broke
between 3.1.9 and 3.1.10. (Smaller repro case and babel-eslint bug
report to come)

His commit failed on travis, but not on his local machine:
https://travis-ci.org/facebook/react/jobs/65468729
 2015-06-04 15:43:41 -07:00
Benjamin Woodruff 1f307ae118 Merge pull request #4029 from PiPeep/warning-invariant-rules-take-two 
Fix problems with/improve warning and invariant rules (take two)
 2015-06-04 15:10:13 -07:00
Benjamin Woodruff 2fa1b2c810 Attempt to simplify/fix warnAndMonitorForKeyUse 
> The two callers of this function have different warning configs
> internally (static_upstream/core/createWarning.js) so we can't sync it
> like this without changing behavior. We should just split this out
> into two separate warning calls probably – this code is a little
> overabstracted.

https://github.com/facebook/react/pull/4021#discussion_r31690020
@spicyj

I think completely removing warnAndMonitorForKeyUse is a bit difficult, without
duplicating a ton of code. This at least ensures that the format string passed
to `warning` is unique. Plus, because the FB internal code in question only
matches the beginning of the format string, I think there should be zero
internal changes that need to be made to support this refactor.
 2015-06-04 15:07:17 -07:00
Paul O’Shannessy da27129f73 Merge pull request #3913 from edvinerikson/edvinerikson/better-warning-message 
Added component displayName to warning message in ReactUpdateQueue.js
 2015-06-04 15:00:36 -07:00
Ben Alpert aacd7ac57d Merge pull request #4030 from spicyj/dc-button 
Convert ReactDOMButton
 2015-06-04 14:47:58 -07:00
Benjamin Woodruff c91fd8ac14 Check warning/invariant calls have good messages 
The `warning` implementation checked that the message is long enough to
be useful. See commit f5038829d for more information.

It makes more sense to move this into a lint rule, and also to apply it
for both `warning` and `invariant`. We can safely remove stuff from the
`warning` implementation as we replace the function internally anyways.

https://github.com/facebook/react/pull/4021#issuecomment-108694976
@spicyj
 2015-06-04 14:19:22 -07:00
Ben Alpert 9dbc29e276 Convert ReactDOMButton 2015-06-04 13:59:32 -07:00
Sebastian Markbåge 2d9a0846f1 Merge pull request #3940 from troutowicz/context_processing 
Process childContextTypes via internal constructor
 2015-06-04 13:54:14 -07:00
Ben Alpert d993475e9e Merge pull request #4027 from spicyj/dc-textarea 
Convert ReactDOMTextarea to not be a wrapper
 2015-06-04 13:53:43 -07:00
Ben Alpert 67a4f0e852 Merge pull request #4028 from spicyj/npm-run-lint 
Fix `npm run lint`
 2015-06-04 13:37:00 -07:00
Ben Alpert d2e7e56cc4 Convert ReactDOMTextarea to not be a wrapper 2015-06-04 13:36:46 -07:00
Paul O’Shannessy 2b195cb1ca Merge pull request #3941 from troutowicz/testing_type 
Assert instance type using internal constructor
 2015-06-04 13:31:23 -07:00
Ben Alpert b1538e36e3 Fix npm run lint 
Broke in #4021.
 2015-06-04 13:20:42 -07:00
Paul O’Shannessy d3db430baf Merge pull request #4022 from zpao/fix-undefined-location 
Use correct location when running LinkedValueUtils proptype checks
 2015-06-04 13:02:54 -07:00
Edvin Erikson fa9382654a reversed line 54 (no-op message) in ReactUpdateQueue.js and added it to the line above 2015-06-04 21:47:35 +02:00
Edvin Erikson 58edaab705 Added component displayName to warning message in ReactUpdateQueue.js 2015-06-04 21:47:34 +02:00
Ben Alpert e04015a4a2 Merge pull request #4011 from spicyj/cfpc 
Inline createFullPageComponent in ReactDOMComponent
 2015-06-04 12:44:02 -07:00
Benjamin Woodruff aecc48d877 Fix wording of warning-and-invariant-args linter 
The wording for an incorrect number of arguments based on counting %s
substitutions. The previous wording was backwards and a bit yoda-like
leading to possible ambiguity.
 2015-06-04 10:51:15 -07:00
Benjamin Woodruff 9760e13f36 Merge pull request #4007 from PiPeep/eslint-plugin-react 
Enable more eslint-plugin-react rules
 2015-06-04 09:51:47 -07:00