Brian Vaughn
d53ae2ea8a
Refactored TreeContext to use less memoization (based on feedback from Sebastian)
2019-04-22 10:19:59 -07:00
Brian Vaughn
70be637d48
Don't schedule an update with React unless the curent element was invalidated
2019-04-22 09:37:55 -07:00
Brian Vaughn
5970bf4b40
Changed polling approach. Fixed remove event typo.
2019-04-22 09:37:55 -07:00
Brian Vaughn
3de18de25e
Tried to implement two setState pattern, but it does not feel right
2019-04-22 09:37:55 -07:00
Brian Vaughn
957c389566
Adding polling and initial stab at not serializing duplicate inspected Element props
2019-04-22 09:37:34 -07:00
Brian Vaughn
c6b19cc141
Refactored insepected element cache to use the context API
2019-04-22 09:37:34 -07:00
Brian Vaughn
09b023a6e6
Naive suspense implementation for selected element panel
...
This commit leaves a few major things uunresolved:
* We aren't yet polling for updates
* We aren't yet using the two setState pattern
* The resource cache will grow unbounded over time because we aren't yet clearing items from it
* The renderer interface is not smart enough to avoid resending unchanged data between requests
2019-04-22 09:37:34 -07:00
Brian Vaughn
76b29ad0a9
Merge pull request #201 from gaearon/scroll-fix
...
Fix scrolling to selected row in collapsed mode
2019-04-22 09:37:15 -07:00
Brian Vaughn
52652f3456
Toggle method no longer emits 'mutated' event unless it mutated the store
2019-04-21 12:20:23 -07:00
Brian Vaughn
91f74a5134
Fixed focus styles for OwnersStack dropdown toggle button
2019-04-21 08:59:24 -07:00
Brian Vaughn
09b995ab1c
Tidied up CSS variables
2019-04-21 08:38:58 -07:00
Brian Vaughn
66df03d179
Renamed CSS var color-text-color to color-text
2019-04-21 08:29:51 -07:00
Brian Vaughn
8220df734c
Tweaked hover and focus colors. Temporarily disabled Tooltip.
2019-04-21 08:23:20 -07:00
Brian Vaughn
a129089891
Tweaking focus/active colors and only showing focus rect on tab
2019-04-20 15:44:24 -07:00
Brian Vaughn
403bf49a78
Use new @reach/tooltip
2019-04-20 14:29:03 -07:00
Brian Vaughn
4b9082eea1
Changed style and position of search-for-element button to more closely matchin Chrome ( based on user testing)
2019-04-20 10:44:03 -07:00
Dan Abramov
4ffdffb598
Fix scrolling to selected row in collapsed mode
2019-04-20 16:20:03 +01:00
Dan
efb5855c8c
Nits
2019-04-19 13:17:17 +01:00
Dan
3e657a6031
Prettier
2019-04-19 13:09:25 +01:00
Dan Abramov
37dd1ec8f8
Merge branch 'master' into more-suspensey-stuff
2019-04-19 13:09:01 +01:00
Brian Vaughn
f286c0d901
Increased contrast for selected+inactive background color
2019-04-18 18:19:10 -07:00
Brian Vaughn
131e2e52db
Merge pull request #188 from gaearon/humble-search
...
Don't select search result unless user does something
2019-04-18 18:04:28 -07:00
Brian Vaughn
60b614f527
Renamed TREE_OPERATION_RESET_CHILDREN -> TREE_OPERATION_REORDER_CHILDREN
2019-04-18 17:59:53 -07:00
Brian Vaughn
24736e4ff5
Hardened reorder child invariants
2019-04-18 17:58:48 -07:00
Dan Abramov
3d09b4aaa5
Don't select search result unless user does something
2019-04-19 01:54:39 +01:00
Dan Abramov
b0c0a11f1b
Revert accidental change
2019-04-19 01:41:00 +01:00
Dan Abramov
534dfb0ca2
Optimize: don't recreate ID arrays all the time
2019-04-19 01:13:25 +01:00
Dan Abramov
8830ba890c
Fix more Suspense traversal bugs
2019-04-19 01:09:57 +01:00
Dan Abramov
ccecde76d1
Harden assertions
2019-04-19 00:29:49 +01:00
Brian Vaughn
3dfbf8ad6b
Added a new invariant to the store (bridge operations handler)
2019-04-18 15:40:50 -07:00
Brian Vaughn
d6e829d7a5
Fixed bug in reset-children to properly calculate new root weight
2019-04-18 09:54:26 -07:00
Brian Vaughn
358e63ac3d
Fixed a Suspense toggling bug that incorrectly impacted tree weight
2019-04-18 09:38:41 -07:00
Dan Abramov
6a13ffd231
Traverse the previous current tree when switching from primary to fallback
2019-04-18 16:22:50 +01:00
Brian Vaughn
456e937b83
Merge pull request #178 from gaearon/removal-integrity
...
Assert removal happens in the right order
2019-04-18 08:16:22 -07:00
Dan Abramov
d02d93712e
Assert removal happens in the right order
2019-04-18 16:02:08 +01:00
Brian Vaughn
08279fb342
Merge pull request #174 from robertknight/mousedown-tab-select
...
Select tab when the mouse is pressed
2019-04-18 08:00:01 -07:00
Lucas Cordeiro
6df050e726
Assign timeoutID to avoid multiple requests
2019-04-18 06:46:06 -03:00
Robert Knight
c2865dbab9
Select tab when the mouse is pressed
...
Selecting the tab when the mouse is pressed rather than only when it is
released makes tab switching feel faster and also matches how the Chrome dev
tools behave.
The previous tab selection handler which listens for the radio button's
selection has been kept for the benefit of interaction methods which
don't trigger the mousedown handler.
2019-04-18 08:16:52 +01:00
Brian Vaughn
0d932d770b
Merge pull request #168 from bvaughn/collapse-nodes-by-default
...
Configurable tree default collapsed/expanded behavior
2019-04-17 13:29:25 -07:00
Brian Vaughn
634d4fece2
Added more inline comments
2019-04-17 13:03:18 -07:00
Brian Vaughn
3fb9f6cdaa
Improve contrast for light mode
2019-04-17 11:40:55 -07:00
Brian Vaughn
74be389124
Fixed a bug with re-ordering of children within a collapsed node
2019-04-17 09:39:54 -07:00
Brian Vaughn
178e89927a
Fixed some edge cases with collapsed by default. Still some bugs existing.
2019-04-17 07:45:33 -07:00
Brian Vaughn
037bb0034c
Throw if root node is collapsed
2019-04-16 14:10:06 -07:00
Brian Vaughn
4b64d7c017
Support configurable node/tree collapsed by default behavior
2019-04-16 13:59:36 -07:00
Brian Vaughn
b76372c93d
Fixed an edge case profiling bug where the number of commits was wrong
2019-04-13 18:29:39 -07:00
Brian Vaughn
00f6466ec1
Temporarily disabled hooks lint failure for Tree useEffect
2019-04-13 15:49:06 -07:00
Brian Vaughn
97f089bdfe
Merge pull request #148 from gaearon/scroll-consistent
...
Consistently scroll component name into view
2019-04-13 15:39:25 -07:00
Brian Vaughn
518f3d75f8
Tweaked an inline comment.
2019-04-13 15:38:56 -07:00
Brian Vaughn
b2cf896e8c
Fixed misplaced padding in Tree
2019-04-13 15:33:10 -07:00