Commit Graph
3981 Commits
Author SHA1 Message Date
Sverre Johansen c28059e39b Don't add 'px' to strokeDashoffset CSS Properties
This is a SVG CSS Property. The standard expects values or percentages, and adding "px" to the value will break it.

http://www.w3.org/TR/SVG/painting.html#StrokeDashoffsetProperty
2015-03-24 17:52:02 +00:00
Paul O’Shannessy cb05e2f85b Merge pull request #3271 from delftswa2014/fix/todo-example
Added the key attribute into the todo example
2015-03-23 14:54:08 -07:00
Paul O’Shannessy 90f8a89ac4 Merge pull request #3488 from delftswa2014/grunt-coverage-fix
Removed build:test from test:coverage.
2015-03-23 14:49:56 -07:00
PNikray e931aaab4a Removed build:test from test:coverage.
This was a duplicate task for build:withCodeCoverageLogging.
It should now properly output the lines which are not covered.
2015-03-23 21:32:49 +01:00
Paul O’Shannessy 11983d8d6b Merge pull request #3483 from julen/docs/document-body-footgun
Docs: do not render components to `document.body`
2015-03-23 11:09:48 -07:00
Paul O’Shannessy dd2e2ecaee Merge pull request #3481 from mertkahyaoglu/master
minor fixes in package.json
2015-03-23 09:45:13 -07:00
Julen Ruiz Aizpuru d83596620f Docs: do not render components to document.body
Rendering to `document.body` in the examples is conveniently short, but it can
be misleading at the same time, especially for newcomers.

While it's possible to render React components to `document.body`, any 3rd
party scripts can also mess up with it, and it can have unintended consequences
and be source of difficult-to-trace bugs.
2015-03-23 13:59:24 +01:00
Mert Kahyaoğlu 31bab53cc8 minor fixes in package.json 2015-03-22 22:09:24 +02:00
Ben Alpert 5dee15273f Merge pull request #3475 from MaximAbramchuck/patch-1
Add missing semicolon
2015-03-21 13:43:22 -07:00
Maxim Abramchuk 9b70e82246 Add missing semicolon 2015-03-21 23:11:45 +03:00
Ben Alpert ed3e6ecb9b Merge pull request #3472 from mertkahyaoglu/master
move getReactRootElementInContainer to ReactMount.js
2015-03-20 12:29:53 -07:00
Mert Kahyaoğlu 63aa7259b9 move getReactRootElementInContainer to ReactMount.js
getReactRootElementInContainer.js file contains one function used only
in ReactMount.js.
2015-03-20 20:50:11 +02:00
Paul O’Shannessy 786055415b Merge pull request #3129
Put comma after any non-whitespace non-comment characters in JSXExpression
2015-03-20 10:32:11 -07:00
Jason Miller ef796790ec Put comma after any non-comments, non-whitespace in JSXEspression
Fixes #1673
Closes #3129
2015-03-20 10:27:21 -07:00
Ben Alpert 70f16cc936 Merge pull request #3471 from mertkahyaoglu/master
fix doc comments and typos
2015-03-20 10:02:49 -07:00
Mert Kahyaoğlu 0c1eca7dfc fix doc comments and typos 2015-03-20 18:21:29 +02:00
Ben Alpert 7fe5a3aadd Merge pull request #3442 from spicyj/kill-initializeTouchEvents
Kill React.initializeTouchEvents for good
2015-03-19 14:15:26 -07:00
Ben Alpert 41e5518135 Merge pull request #3464 from martomi/html-tags
Examples - Fix a closing html paragraph tag.
2015-03-19 13:09:09 -07:00
Martin Mihaylov d7bf64396a Fix the closing html paragraph tag. 2015-03-19 20:56:49 +01:00
Joseph Savona f707f74c8a Merge pull request #3463 from josephsavona/relay-components
Building The Facebook News Feed With Relay
2015-03-19 12:56:21 -07:00
Joseph Savona 85e7598ef1 Building with Relay blog post 2015-03-19 12:53:49 -07:00
Ben Alpert 1a102a2ed8 Merge pull request #3456 from cody/html-jsx
Fix HTML to JSX converter to work with https
2015-03-19 12:45:41 -07:00
Stefan Dombrowski 89b17330ac Fix HTML to JSX converter to work with https 2015-03-19 00:33:14 +01:00
Christoph Pojer d86790f4b6 Merge pull request #3441 from cpojer/rm-perf
Remove perf folder
2015-03-18 12:28:55 -07:00
Ben Alpert a321247ee5 More lint fixes 2015-03-17 14:17:03 -07:00
Ben Alpert 26664315a6 Merge pull request #3438 from spicyj/lint
Lint fixes
2015-03-17 14:14:57 -07:00
Christoph Pojer 0098168b60 Merge pull request #3439 from cpojer/dom-node-warn
Add warning for getDOMNode calls.
2015-03-17 14:14:16 -07:00
Ben Alpert 9c4c2f58ea Kill React.initializeTouchEvents for good
Now that #1169 is fixed, the only thing this is used for is to determine whether `onTouchTap` causes touch listeners to be added. The only internal uses of TapEventPlugin are where touch events are already initialized (so this doesn't make a difference) and we don't support `onTouchTap` as part of the public API so this should be safe.
2015-03-17 14:12:26 -07:00
cpojer fb23276178 Add warning for getDOMNode calls. 2015-03-17 14:08:04 -07:00
cpojer 7291942550 Remove perf folder 2015-03-17 13:40:11 -07:00
Ben Alpert c34fa7f3d2 Lint fixes 2015-03-17 13:30:15 -07:00
Ben Alpert 9a6fa5eb7d Merge pull request #3430 from fourcolors/patch-1
fix grammar in comments
2015-03-17 11:08:40 -07:00
Ben Alpert 5d9b228e03 Merge pull request #3433 from mihaip/master
Include the owner name when warning about createElement(null/undefined).
2015-03-16 22:21:33 -07:00
Mihai Parparita 60a101eced Include the owner name when warning about createElement(null/undefined).
Makes it easier to find the callsite that needs to be fixed.
2015-03-16 22:05:29 -07:00
Sebastian Markbåge dc9dcdba86 Merge pull request #3431 from sebmarkbage/ignoreowner
Don't use owner to determine statefulness
2015-03-16 18:08:21 -07:00
Sebastian Markbage 50cbdbc9ab Don't use owner to determine statefulness
This reverts an early commit that made it so that elements from two
different owner in the same slot wouldn't share state.

That behavior was helpful, and we did hit a case which was solved by this.
However, this pattern is extremely uncommon. I've yet to even find the
original case, let alone any existing cases in our codebase.

Therefore, we're dropping this to simplify elements and enable new
optimizations.
2015-03-16 18:05:15 -07:00
Paul O’Shannessy c48ccc5742 0.13 blog post, starter kit 2015-03-16 16:59:22 -07:00
Paul O’Shannessy 77f011f82f Update Readme for 0.13.1 2015-03-16 16:59:21 -07:00
Paul O’Shannessy efc88bad76 Changelog for 0.13.1 2015-03-16 16:59:21 -07:00
Jim 87e14c5ef8 Merge pull request #3176 from jsfb/webcomponent-to-vendor-thirdparty
Added webcomponents.js and a simple unit test verifying a document fragment as a valid React container
2015-03-16 16:40:22 -07:00
Jim 12059299f3 Added webcomponents.js and a simple unit test verifying a document fragment as a valid React container. 2015-03-16 16:37:05 -07:00
Jim 73f4dc59d8 Merge pull request #3169 from jsfb/mount-into-shadowdom
Allow rendering into document fragments. Fixes #840
2015-03-16 16:15:03 -07:00
Paul O’Shannessy 10112672b1 Merge pull request #3395 from Simek/reactComponentExpect-cleanup
toBeDOMComponentWithChildCount readability
2015-03-16 16:14:48 -07:00
Sterling Cobb b59e7e60b5 fix grammer in comments 2015-03-16 17:10:14 -06:00
Paul O’Shannessy dacd4db1fa Merge pull request #3427 from zpao/full-page-dom-components
Ensure FullPageComponents are treated as DOM components
2015-03-16 15:39:40 -07:00
Paul O’Shannessy 99cbaed836 Ensure FullPageComponents are treated as DOM components
We currently override a couple DOM components. We need to ensure everything we
override is still treated as a DOM component, even if it has a composite
component wrapper.
2015-03-16 15:18:39 -07:00
Paul O’Shannessy 93e67a0a5b Merge pull request #3425 from zpao/fix-pure-test
Fix PureRender test to use providesModule
2015-03-16 15:14:26 -07:00
Ben Alpert 0a312bba89 Merge pull request #3414 from spicyj/gh-3407
Fix up Perf a bit better for 0.13
2015-03-16 14:04:28 -07:00
Paul O’Shannessy bb0fc28fac Fix PureRender test to use providesModule 2015-03-16 13:56:43 -07:00
Paul O’Shannessy b0a59a643a Merge pull request #3381 from zpao/jsx-nonstrictmodule
Fix module option parsing of jsx command
2015-03-16 13:24:35 -07:00